LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu> To: akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [patch 12/22] fuse: fix page invalidation Date: Wed, 28 Feb 2007 00:14:54 +0100 [thread overview] Message-ID: <20070227231644.084963200@szeredi.hu> (raw) In-Reply-To: 20070227231442.627972152@szeredi.hu [-- Attachment #1: fuse_invalidate_fix.patch --] [-- Type: text/plain, Size: 3414 bytes --] From: Miklos Szeredi <mszeredi@suse.cz> Other than truncate, there are two cases, when fuse tries to get rid of cached pages: a) in open, if KEEP_CACHE flag is not set) b) in getattr, if file size changed spontaneously Until now invalidate_mapping_pages() were used, which didn't get rid of mapped pages. This is wrong, and becomes more wrong as dirty pages are introduced. So instead properly invalidate all pages with invalidate_inode_pages2(). If the size of the file shrunk, truncate pages outside the new size beforehand. Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> --- Index: linux/fs/fuse/file.c =================================================================== --- linux.orig/fs/fuse/file.c 2007-02-27 14:41:10.000000000 +0100 +++ linux/fs/fuse/file.c 2007-02-27 14:41:11.000000000 +0100 @@ -86,7 +86,7 @@ void fuse_finish_open(struct inode *inod if (outarg->open_flags & FOPEN_DIRECT_IO) file->f_op = &fuse_direct_io_file_operations; if (!(outarg->open_flags & FOPEN_KEEP_CACHE)) - invalidate_mapping_pages(inode->i_mapping, 0, -1); + invalidate_inode_pages2(inode->i_mapping); ff->fh = outarg->fh; file->private_data = fuse_file_get(ff); } Index: linux/fs/fuse/inode.c =================================================================== --- linux.orig/fs/fuse/inode.c 2007-02-27 14:41:10.000000000 +0100 +++ linux/fs/fuse/inode.c 2007-02-27 14:41:11.000000000 +0100 @@ -112,17 +112,22 @@ static int fuse_remount_fs(struct super_ void fuse_change_attributes(struct inode *inode, struct fuse_attr *attr) { struct fuse_conn *fc = get_fuse_conn(inode); - if (S_ISREG(inode->i_mode) && i_size_read(inode) != attr->size) - invalidate_mapping_pages(inode->i_mapping, 0, -1); + loff_t oldsize = i_size_read(inode); + + spin_lock(&fc->lock); + i_size_write(inode, attr->size); + spin_unlock(&fc->lock); + if (S_ISREG(inode->i_mode)) { + if (oldsize > attr->size) + fuse_vmtruncate(inode, attr->size); + invalidate_inode_pages2(inode->i_mapping); + } inode->i_ino = attr->ino; inode->i_mode = (inode->i_mode & S_IFMT) + (attr->mode & 07777); inode->i_nlink = attr->nlink; inode->i_uid = attr->uid; inode->i_gid = attr->gid; - spin_lock(&fc->lock); - i_size_write(inode, attr->size); - spin_unlock(&fc->lock); inode->i_blocks = attr->blocks; inode->i_atime.tv_sec = attr->atime; inode->i_atime.tv_nsec = attr->atimensec; Index: linux/fs/fuse/dir.c =================================================================== --- linux.orig/fs/fuse/dir.c 2007-02-27 14:41:10.000000000 +0100 +++ linux/fs/fuse/dir.c 2007-02-27 14:41:11.000000000 +0100 @@ -979,7 +979,7 @@ static void iattr_to_fattr(struct iattr } } -static void fuse_vmtruncate(struct inode *inode, loff_t offset) +void fuse_vmtruncate(struct inode *inode, loff_t offset) { struct address_space *mapping = inode->i_mapping; unmap_mapping_range(mapping, offset + PAGE_SIZE - 1, 0, 1); Index: linux/fs/fuse/fuse_i.h =================================================================== --- linux.orig/fs/fuse/fuse_i.h 2007-02-27 14:41:10.000000000 +0100 +++ linux/fs/fuse/fuse_i.h 2007-02-27 14:41:11.000000000 +0100 @@ -565,3 +565,8 @@ int fuse_ctl_add_conn(struct fuse_conn * * Remove connection from control filesystem */ void fuse_ctl_remove_conn(struct fuse_conn *fc); + +/** + * Truncate inode + */ +void fuse_vmtruncate(struct inode *inode, loff_t offset); --
next prev parent reply other threads:[~2007-02-27 23:21 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-02-27 23:14 [patch 00/22] misc VFS/VM patches and fuse writable shared mapping support Miklos Szeredi 2007-02-27 23:14 ` [patch 01/22] update ctime and mtime for mmaped write Miklos Szeredi 2007-02-28 14:16 ` Peter Staubach 2007-02-28 17:06 ` Miklos Szeredi 2007-02-28 17:21 ` Peter Staubach 2007-02-28 17:51 ` Miklos Szeredi 2007-02-28 20:01 ` Peter Staubach 2007-02-28 20:35 ` Miklos Szeredi 2007-02-28 20:58 ` Miklos Szeredi 2007-02-28 21:09 ` Peter Staubach 2007-03-01 7:25 ` Miklos Szeredi 2007-02-27 23:14 ` [patch 02/22] fix quadratic behavior of shrink_dcache_parent() Miklos Szeredi 2007-02-27 23:14 ` [patch 03/22] fix deadlock in balance_dirty_pages Miklos Szeredi 2007-02-27 23:14 ` [patch 04/22] fix deadlock in throttle_vm_writeout Miklos Szeredi 2007-02-27 23:14 ` [patch 05/22] balance dirty pages from loop device Miklos Szeredi 2007-02-27 23:14 ` [patch 06/22] consolidate generic_writepages and mpage_writepages Miklos Szeredi 2007-02-27 23:14 ` [patch 07/22] add filesystem subtype support Miklos Szeredi 2007-02-27 23:14 ` [patch 08/22] fuse: update backing_dev_info congestion state Miklos Szeredi 2007-02-27 23:14 ` [patch 09/22] fuse: fix reserved request wake up Miklos Szeredi 2007-02-27 23:14 ` [patch 10/22] fuse: add reference counting to fuse_file Miklos Szeredi 2007-02-27 23:14 ` [patch 11/22] fuse: add truncation semaphore Miklos Szeredi 2007-02-27 23:14 ` Miklos Szeredi [this message] 2007-02-27 23:14 ` [patch 13/22] fuse: add list of writable files to fuse_inode Miklos Szeredi 2007-02-27 23:14 ` [patch 14/22] fuse: add helper for asynchronous writes Miklos Szeredi 2007-02-27 23:14 ` [patch 15/22] add non-owner variant of down_read_trylock() Miklos Szeredi 2007-02-27 23:14 ` [patch 16/22] fuse: add fuse_writepage() function Miklos Szeredi 2007-02-27 23:14 ` [patch 17/22] fuse: writable shared mmap support Miklos Szeredi 2007-02-27 23:15 ` [patch 18/22] fuse: add fuse_writepages() function Miklos Szeredi 2007-02-27 23:15 ` [patch 19/22] export sync_sb() to modules Miklos Szeredi 2007-02-27 23:15 ` [patch 20/22] fuse: make dirty stats available Miklos Szeredi 2007-02-27 23:15 ` [patch 21/22] fuse: limit dirty pages Miklos Szeredi 2007-02-27 23:15 ` [patch 22/22] fuse: allow big write requests Miklos Szeredi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20070227231644.084963200@szeredi.hu \ --to=miklos@szeredi.hu \ --cc=akpm@linux-foundation.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).