LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Alex Williamson <alex.williamson@hp.com>,
	Kevin Stansell <kstansel@us.ibm.com>
Subject: [patch] Add insmod option to force the use of the backup timer.
Date: Wed, 28 Feb 2007 11:23:46 +0100	[thread overview]
Message-ID: <20070228102346.115707000@suse.de> (raw)

[-- Attachment #1: serial-8250-backup-timerPatch --]
[-- Type: text/plain, Size: 1813 bytes --]

The test which automatically enables the backup timer on some HP
machines doesn't trigger on other hardware which needs the backup
timer too.

This patch add a way to enable it manually (8250.use_backup_timer=1)
to deal with these machines.

Signed-off-by: Gerd Hoffmann <kraxel@suse.de>
Cc: Alex Williamson <alex.williamson@hp.com>
Cc: Kevin Stansell <kstansel@us.ibm.com>
---
 drivers/serial/8250.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Index: vanilla-2.6.21-rc2/drivers/serial/8250.c
===================================================================
--- vanilla-2.6.21-rc2.orig/drivers/serial/8250.c
+++ vanilla-2.6.21-rc2/drivers/serial/8250.c
@@ -52,8 +52,8 @@
  *                is unsafe when used on edge-triggered interrupts.
  */
 static unsigned int share_irqs = SERIAL8250_SHARE_IRQS;
-
 static unsigned int nr_uarts = CONFIG_SERIAL_8250_RUNTIME_UARTS;
+static unsigned int use_backup_timer;
 
 /*
  * Debugging.
@@ -1729,7 +1729,7 @@ static int serial8250_startup(struct uar
 		 * If the interrupt is not reasserted, setup a timer to
 		 * kick the UART on a regular basis.
 		 */
-		if (iir & UART_IIR_NO_INT) {
+		if (iir & UART_IIR_NO_INT || use_backup_timer) {
 			pr_debug("ttyS%d - using backup timer\n", port->line);
 			up->timer.function = serial8250_backup_timeout;
 			up->timer.data = (unsigned long)up;
@@ -2805,6 +2805,9 @@ module_param(share_irqs, uint, 0644);
 MODULE_PARM_DESC(share_irqs, "Share IRQs with other non-8250/16x50 devices"
 	" (unsafe)");
 
+module_param(use_backup_timer, uint, 0644);
+MODULE_PARM_DESC(use_backup_timer, "use backup timer");
+
 module_param(nr_uarts, uint, 0644);
 MODULE_PARM_DESC(nr_uarts, "Maximum number of UARTs supported. (1-" __MODULE_STRING(CONFIG_SERIAL_8250_NR_UARTS) ")");
 

-- 
Gerd Hoffmann <kraxel@suse.de>


             reply	other threads:[~2007-02-28 10:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-28 10:23 Gerd Hoffmann [this message]
2007-02-28 18:55 ` Dave Jones
2007-03-01 13:20   ` Gerd Hoffmann
2007-03-06  3:03     ` Andrew Morton
2007-03-06  4:22       ` Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070228102346.115707000@suse.de \
    --to=kraxel@suse.de \
    --cc=alex.williamson@hp.com \
    --cc=kstansel@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [patch] Add insmod option to force the use of the backup timer.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).