LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jean Tourrilhes <jt@hpl.hp.com>
To: Greg KH <gregkh@suse.de>
Cc: "David S. Miller" <davem@davemloft.net>,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.20] kobject net ifindex + rename
Date: Wed, 28 Feb 2007 10:43:14 -0800	[thread overview]
Message-ID: <20070228184314.GC6134@bougret.hpl.hp.com> (raw)
In-Reply-To: <20070228153617.GA5670@suse.de>

On Wed, Feb 28, 2007 at 07:36:17AM -0800, Greg KH wrote:
> On Tue, Feb 27, 2007 at 05:27:41PM -0800, Jean Tourrilhes wrote:
> > diff -u -p linux/drivers/base/class.j1.c linux/drivers/base/class.c
> > --- linux/drivers/base/class.j1.c	2007-02-26 18:38:10.000000000 -0800
> > +++ linux/drivers/base/class.c	2007-02-27 15:52:37.000000000 -0800
> > @@ -841,6 +841,8 @@ int class_device_rename(struct class_dev
> 
> This function is not in the 2.6.21-rc2 kernel, so you might want to
> rework this patch a bit :)

	It was a trial balloon to gather feedback. I will do.

> Also, it's userspace that causes the rename to happen, so it knows it
> did it, why should the kernel have to emit a message to tell userspace
> again what just happened?

	Username is not one big program, but a collection of program,
and one program does not know what another program do.
	In particular, udev does not know when people are using
iproute2 to rename interface and loose its marbles. We don't really
want to ban iproute2 or udev ;-)

> thanks,
> 
> greg k-h

	Have fun...

	Jean

  reply	other threads:[~2007-02-28 18:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-28  1:27 Jean Tourrilhes
2007-02-28  9:16 ` Johannes Berg
2007-02-28 18:51   ` Jean Tourrilhes
2007-02-28 19:03     ` Johannes Berg
2007-02-28  9:34 ` Jarek Poplawski
2007-02-28  9:52   ` Jarek Poplawski
2007-02-28 18:45   ` Jean Tourrilhes
2007-03-01  7:42     ` Jarek Poplawski
2007-03-01 19:27       ` Jean Tourrilhes
2007-03-02  9:18         ` Jarek Poplawski
2007-02-28 15:36 ` Greg KH
2007-02-28 18:43   ` Jean Tourrilhes [this message]
2007-03-01  0:26   ` Jean Tourrilhes
2007-03-01  0:37     ` Johannes Berg
2007-03-01  0:51       ` Jean Tourrilhes
2007-03-01  0:57         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070228184314.GC6134@bougret.hpl.hp.com \
    --to=jt@hpl.hp.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH 2.6.20] kobject net ifindex + rename' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).