LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jean Tourrilhes <jt@hpl.hp.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	"David S. Miller" <davem@davemloft.net>,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.20] kobject net ifindex + rename
Date: Wed, 28 Feb 2007 10:51:17 -0800	[thread overview]
Message-ID: <20070228185117.GE6134@bougret.hpl.hp.com> (raw)
In-Reply-To: <1172654165.3681.31.camel@johannes.berg>

On Wed, Feb 28, 2007 at 10:16:05AM +0100, Johannes Berg wrote:
> Hi,
> 
> > 	Patch for 2.6.20 is attached.
> 
> ... and in the meantime netdevices aren't class_device any more :) IOW,
> your patch isn't going to work any more.

	That's why I always specify the kernel version. I'll look into
that, I'm sure it's not the end of the world ;-)

> Also, I think wireless could benefit from this as well.

	In which sense ? Wireless interface are regular netdevices.

> >         The kobject framework is well designed, so adding these
> > features is trivial change and won't run the risk of breaking anything
> > (famous last words). Obviously, hotplug apps are free to ignore those
> > additional features.
> 
> Why not just add this to base kobject_rename instead? That way,
> userspace is notified for all renames in sysfs.
> The patch then collapses down to the change in net's sysfs code to add
> the ifindex to the environment, and another change in kobject to invoke
> a new event when a name changes and show the old name.

	I'm just trying to follow the established pattern. Both
class_device_add() and class_device_del() are generating the
event. Also, I'm not sure if other subsystem would benefit from it, I
don't want to generate too many useless events.

> johannes

	Thanks !

	Jean


  reply	other threads:[~2007-02-28 18:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-28  1:27 Jean Tourrilhes
2007-02-28  9:16 ` Johannes Berg
2007-02-28 18:51   ` Jean Tourrilhes [this message]
2007-02-28 19:03     ` Johannes Berg
2007-02-28  9:34 ` Jarek Poplawski
2007-02-28  9:52   ` Jarek Poplawski
2007-02-28 18:45   ` Jean Tourrilhes
2007-03-01  7:42     ` Jarek Poplawski
2007-03-01 19:27       ` Jean Tourrilhes
2007-03-02  9:18         ` Jarek Poplawski
2007-02-28 15:36 ` Greg KH
2007-02-28 18:43   ` Jean Tourrilhes
2007-03-01  0:26   ` Jean Tourrilhes
2007-03-01  0:37     ` Johannes Berg
2007-03-01  0:51       ` Jean Tourrilhes
2007-03-01  0:57         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070228185117.GE6134@bougret.hpl.hp.com \
    --to=jt@hpl.hp.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@suse.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH 2.6.20] kobject net ifindex + rename' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).