LKML Archive on
help / color / mirror / Atom feed
From: David Gibson <>
To: Andrew Morton <>,,
Subject: Re: [PATCH 1/2] Define FIXED_PORT flag for serial_core
Date: Thu, 1 Mar 2007 10:44:24 +1100	[thread overview]
Message-ID: <20070228234424.GD3048@localhost.localdomain> (raw)
In-Reply-To: <>

On Wed, Feb 28, 2007 at 10:26:30PM +0000, Russell King wrote:
> On Tue, Feb 20, 2007 at 02:19:51PM +1100, David Gibson wrote:
> > Therefore, this patch defines a UPF_FIXED_PORT flag for the uart_port
> > structure.  If this flag is set when the serial port is configured,
> > any attempts to alter the port's type, io address, irq or base clock
> > with setserial are ignored.
> I've been wondering about this, and it is questionable whether we
> should allow any serial port which isn't owned by the legacy platform
> device (the one called "serial8250", iow by the 8250 driver itself)
> to have the base addresses and interrupts changed.
> IOW, we apply this "fixed port" to any port registered by probe
> modules external to the 8250 driver itself, such as PCI, PNP, etc.

Sounds reasonable to me.  But maybe in that case we should invert the

David Gibson			| I'll have my music baroque, and my code
david AT	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!

  reply	other threads:[~2007-03-01  0:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-20  3:17 Use resource_size_t for serial MMIO addresses David Gibson
2007-02-20  3:19 ` [PATCH 1/2] Define FIXED_PORT flag for serial_core David Gibson
2007-02-20 13:07   ` Alan
2007-02-28 22:26   ` Russell King
2007-02-28 23:44     ` David Gibson [this message]
2007-03-01 10:30       ` Russell King
2007-03-02  1:57         ` David Gibson
2007-02-20  3:19 ` [PATCH 2/2] Use resource_size_t for serial port IO addresses David Gibson
2007-02-20 13:06   ` Alan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070228234424.GD3048@localhost.localdomain \ \ \ \ \
    --subject='Re: [PATCH 1/2] Define FIXED_PORT flag for serial_core' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).