LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: "Fernando Luis Vázquez Cao" <fernando@oss.ntt.co.jp>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	fastboot@lists.osdl.org, ebiederm@xmission.com, ak@suse.de,
	akpm@linux-foundation.org, judith@linux-foundation.org
Subject: Re: [PATCH 5/5] Move definition of hard_smp_processor_id to asm/smp.h - alpha, m32r, powerpc, s390, sparc, sparc64, um
Date: Thu, 1 Mar 2007 10:03:48 +0100	[thread overview]
Message-ID: <20070301090348.GA8405@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <1172733503.1498.275.camel@sebastian.intellilink.co.jp>

On Thu, Mar 01, 2007 at 04:18:23PM +0900, Fernando Luis Vázquez Cao wrote:
> Move definition of hard_smp_processor_id to asm/smp.h on alpha, m32r,
> powerpc, s390, sparc, sparc64, and um architectures.
> 
> Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
> ---
> 
> diff -urNp linux-2.6.21-rc2/include/asm-alpha/smp.h linux-2.6.21-rc2-hwcpuid/include/asm-alpha/smp.h
> --- linux-2.6.21-rc2/include/asm-alpha/smp.h	2007-02-05 03:44:54.000000000 +0900
> +++ linux-2.6.21-rc2-hwcpuid/include/asm-alpha/smp.h	2007-03-07 13:34:14.000000000 +0900
> @@ -51,6 +51,7 @@ int smp_call_function_on_cpu(void (*func
> 
>  #else /* CONFIG_SMP */
> 
> +#define hard_smp_processor_id()		0
>  #define smp_call_function_on_cpu(func,info,retry,wait,cpu)    ({ 0; })
> 
>  #endif /* CONFIG_SMP */

/me thinks you should merge this patch with patch 1. Otherwise there is no
hard_smp_processor_id() defined on any architecture if only patch 1 is
applied. That would break a git bisect search.

  reply	other threads:[~2007-03-01  9:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-01  7:18 Fernando Luis Vázquez Cao
2007-03-01  9:03 ` Heiko Carstens [this message]
2007-03-02  8:31   ` Fernando Luis Vázquez Cao
2007-03-02  8:39     ` Andrew Morton
2007-03-02  8:43       ` Fernando Luis Vázquez Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070301090348.GA8405@osiris.boeblingen.de.ibm.com \
    --to=heiko.carstens@de.ibm.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=fastboot@lists.osdl.org \
    --cc=fernando@oss.ntt.co.jp \
    --cc=judith@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 5/5] Move definition of hard_smp_processor_id to asm/smp.h - alpha, m32r, powerpc, s390, sparc, sparc64, um' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).