LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bernhard Walle <bwalle@suse.de>
To: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Fastboot] [PATCH 1/1] - platform_kernel_launch_event is noop on generic kernel
Date: Thu, 1 Mar 2007 14:03:36 +0100	[thread overview]
Message-ID: <20070301130336.GB18853@strauss.suse.de> (raw)
In-Reply-To: <20070301125736.GA18853@strauss.suse.de>

* Bernhard Walle <bwalle@suse.de> [2007-03-01 13:57]:
> * Horms <horms@verge.net.au> [2007-03-01 05:22]:
> > On Wed, Feb 28, 2007 at 01:45:17PM -0600, John Keller wrote:
> > > Add a missing #define for the platform_kernel_launch_event.
> > > Without this fix, a call to platform_kernel_launch_event()
> > > becomes a noop on generic kernels. SN systems require this
> > > fix to successfully kdump/kexec from certain hardware errors.
> > >
> > > Signed-off-by: John Keller <jpk@sgi.com>
> > 
> > I made a similar change when porting to xen, but I hadn't thought
> > to see if mainline linux needs it to.
> > 
> > Acked-by: Simon Horman <horms@verge.net.au>
> 
> I think there's an additional change needed. Without that, it leads to
> a NULL pointer dereference.

Maybe I should also get my editor right ... ;):

---
 include/asm-ia64/machvec.h |    2 ++
 1 file changed, 2 insertions(+)

Index: b/include/asm-ia64/machvec.h
===================================================================
--- a/include/asm-ia64/machvec.h
+++ b/include/asm-ia64/machvec.h
@@ -168,6 +168,7 @@ extern void machvec_tlb_migrate_finish (
 #  define platform_setup_msi_irq	ia64_mv.setup_msi_irq
 #  define platform_teardown_msi_irq	ia64_mv.teardown_msi_irq
 #  define platform_pci_fixup_bus	ia64_mv.pci_fixup_bus
+#  define platform_kernel_launch_event	ia64_mv.kernel_launch_event
 # endif
 
 /* __attribute__((__aligned__(16))) is required to make size of the
@@ -269,6 +270,7 @@ struct ia64_machine_vector {
 	platform_setup_msi_irq,			\
 	platform_teardown_msi_irq,		\
 	platform_pci_fixup_bus,			\
+	platform_kernel_launch_event            \
 }
 
 extern struct ia64_machine_vector ia64_mv;

  reply	other threads:[~2007-03-01 13:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-28 19:45 [PATCH 1/1] - platform_kernel_launch_event is noop on generic kernel John Keller
2007-03-01  4:22 ` [Fastboot] " Horms
2007-03-01 12:57   ` Bernhard Walle
2007-03-01 13:03     ` Bernhard Walle [this message]
2007-03-06  2:40       ` Jay Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070301130336.GB18853@strauss.suse.de \
    --to=bwalle@suse.de \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).