LKML Archive on
help / color / mirror / Atom feed
From: David Brownell <>
To: Ben Nizette <>
Cc: Dmitry Torokhov <>,
	pHilipp Zabel <>,
	Andrew Morton <>,
	Haavard Skinnemoen <>,
	Linux Kernel list <>
Subject: Re: [patch 2.6.21-rc2] gpio_keys driver shouldn't be ARM-specific
Date: Thu, 1 Mar 2007 16:54:18 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thursday 01 March 2007 4:18 pm, Ben Nizette wrote:
> David Brownell wrote:
> > The gpio_keys driver is wrongly ARM-specific; it can't build on
> > other platforms with GPIO suport.  This fixes that problem.
> > 
> I did up a similar patch a few days back, you beat me too it ;).  I've 
> been using this driver on AVR32 for a while now.

I know various folk have been doing that very thing ...

> The other thing was that this driver only depends on the machine 
> supporting your generic GPIO conventions.  Currently the Kconfig entry 
> for gpio_keys reads:
> 	depends on (ARCH_SA1100 || ARCH_PXA || ARCH_S3C2410)
> With the || AVR32 I've added to my version it's getting a bit out of 
> hand!  Anyone else think it would be worth introducing a GPIO_FRAMEWORK 
> symbol selected by each machine which supports it and just set the 
> gpio_keys dependency to that?

Earlier today I posted a patch adding CONFIG_GENERIC_GPIO, and
I think that will get merged soonish ...

- Dave

> Ben.

  reply	other threads:[~2007-03-02  1:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-01 23:51 David Brownell
2007-03-02  0:18 ` Ben Nizette
2007-03-02  0:54   ` David Brownell [this message]
2007-03-02  2:21     ` Ben Nizette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [patch 2.6.21-rc2] gpio_keys driver shouldn'\''t be ARM-specific' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).