LKML Archive on
help / color / mirror / Atom feed
From: Jay Vosburgh <>
To: Andrew Morton <>
Cc: Jaroslav Kysela <>,
	LKML <>,
	Stephen Hemminger <>,
	Oleg Nesterov <>,, Andy Gospodarek <>
Subject: Re: [PATCH] bonding: replace system timer with work queue
Date: Thu, 01 Mar 2007 09:00:29 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Andrew Morton <> wrote:

>On Wed, 28 Feb 2007 10:12:01 +0100 (CET) Jaroslav Kysela <> wrote:
>> ==================
>> bonding: replace system timer with work queue
>> This patch replaces system timer with work queue in monitor functions.
>> The reason for this change is that bonding handlers calls various
>> sleeping functions from the timer handler which is not allowed.
>Which sleeping functions?  I'd have expected the kernel to spew runtime
>warnings when this happens, but I don't recall any such reports.

	This affects one specific mode (balance-alb) in one specific
case (moving MAC addresses around, which happens during failover or
initialization), and a full fix is more complicated than just a switch
to work queues, although that is part of the full fix.  There are three
things going on: calls to sleeping functions with locks held, the same
calls from the timer context, and rtnl hold issues.

	The actual functions affected are various things called by
notifier NETDEV_CHANGEADDR callbacks started by dev_set_mac_address() as
well as some of the driver level set_mac_address functions that may

	Andy Gospodarek <> and I have been working
jointly on a two phased fix for these problems: he's working up the
short term fix, which includes the changeover to workqueues, and I've
been working on the long term fix, which involves refactoring the
bonding link monitoring and failover system.  Jaroslav's patch looks to
be a subset of the patch Andy is working on.


	-Jay Vosburgh, IBM Linux Technology Center,

      parent reply	other threads:[~2007-03-01 17:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-28  9:12 Jaroslav Kysela
2007-02-28 22:18 ` Stephen Hemminger
2007-03-01  7:35 ` Andrew Morton
2007-03-01 16:00   ` Stephen Hemminger
2007-03-01 17:00   ` Jay Vosburgh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] bonding: replace system timer with work queue' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).