From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965190AbXCBB5d (ORCPT ); Thu, 1 Mar 2007 20:57:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965330AbXCBB5d (ORCPT ); Thu, 1 Mar 2007 20:57:33 -0500 Received: from ozlabs.org ([203.10.76.45]:43012 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965190AbXCBB5d (ORCPT ); Thu, 1 Mar 2007 20:57:33 -0500 Date: Fri, 2 Mar 2007 12:57:29 +1100 From: David Gibson To: Andrew Morton , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: Re: [PATCH 1/2] Define FIXED_PORT flag for serial_core Message-ID: <20070302015729.GB1687@localhost.localdomain> Mail-Followup-To: Andrew Morton , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org References: <20070220031717.GI17818@localhost.localdomain> <20070220031951.56492DDD09@ozlabs.org> <20070228222630.GA11999@flint.arm.linux.org.uk> <20070228234424.GD3048@localhost.localdomain> <20070301103004.GA25033@flint.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070301103004.GA25033@flint.arm.linux.org.uk> User-Agent: Mutt/1.5.12-2006-07-14 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 01, 2007 at 10:30:04AM +0000, Russell King wrote: > On Thu, Mar 01, 2007 at 10:44:24AM +1100, David Gibson wrote: > > On Wed, Feb 28, 2007 at 10:26:30PM +0000, Russell King wrote: > > > On Tue, Feb 20, 2007 at 02:19:51PM +1100, David Gibson wrote: > > > > Therefore, this patch defines a UPF_FIXED_PORT flag for the uart_port > > > > structure. If this flag is set when the serial port is configured, > > > > any attempts to alter the port's type, io address, irq or base clock > > > > with setserial are ignored. > > > > > > I've been wondering about this, and it is questionable whether we > > > should allow any serial port which isn't owned by the legacy platform > > > device (the one called "serial8250", iow by the 8250 driver itself) > > > to have the base addresses and interrupts changed. > > > > > > IOW, we apply this "fixed port" to any port registered by probe > > > modules external to the 8250 driver itself, such as PCI, PNP, etc. > > > > Sounds reasonable to me. But maybe in that case we should invert the > > sense of the flag. UPF_MOVABLE_PORT or UPF_USER_CONFIGURABLE or > > something. > > I was thinking about not even having a flag, but instead checking for > port->dev == &serial8250_isa_devs->dev. Hmm.. ok. Will you spin a patch, or should I? -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson