LKML Archive on
help / color / mirror / Atom feed
From: "Ahmed S. Darwish" <>
To: Amit Choudhary <>
Cc: Linux Kernel <>
Subject: Re: [PATCH] drivers/media/video/videocodec.c: check kmalloc() return value.
Date: Mon, 12 Mar 2007 12:45:48 +0200	[thread overview]
Message-ID: <20070312104548.GA26264@Ahmed> (raw)
In-Reply-To: <>

Hi Amit,

On Thu, Mar 08, 2007 at 11:14:01PM -0800, Amit Choudhary wrote:
> Description: Check the return value of kmalloc() in function 
> videocodec_build_table(), in file drivers/media/video/videocodec.c.

No need for `Description:'. This line is automatically put in the logs 
as a patch description if the patch got accepted. 

It's better not to use very large lines. 

Also there's no need to specify the exact function in the log, it's already
displayed in the patch.

> Signed-off-by: Amit Choudhary <>

As said in Documentation/SubmittingPatches put a "---" line after
Signed-off-by signature.


Ahmed S. Darwish

      parent reply	other threads:[~2007-03-12 10:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-09  7:14 Amit Choudhary
2007-03-09  9:04 ` Andrey Panin
2007-03-12 10:45 ` Ahmed S. Darwish [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070312104548.GA26264@Ahmed \ \ \ \
    --subject='Re: [PATCH] drivers/media/video/videocodec.c: check kmalloc() return value.' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox