From: "Ahmed S. Darwish" <darwish.07@gmail.com> To: Amit Choudhary <amit2030@gmail.com> Cc: Linux Kernel <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] drivers/media/video/videocodec.c: check kmalloc() return value. Date: Mon, 12 Mar 2007 12:45:48 +0200 Message-ID: <20070312104548.GA26264@Ahmed> (raw) In-Reply-To: <20070308231401.42679647.amit2030@gmail.com> Hi Amit, On Thu, Mar 08, 2007 at 11:14:01PM -0800, Amit Choudhary wrote: > Description: Check the return value of kmalloc() in function > videocodec_build_table(), in file drivers/media/video/videocodec.c. No need for `Description:'. This line is automatically put in the logs as a patch description if the patch got accepted. It's better not to use very large lines. Also there's no need to specify the exact function in the log, it's already displayed in the patch. > > Signed-off-by: Amit Choudhary <amit2030@gmail.com> > As said in Documentation/SubmittingPatches put a "---" line after Signed-off-by signature. Thanks, -- Ahmed S. Darwish http://darwish.07.googlepages.com
prev parent reply index Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-03-09 7:14 Amit Choudhary 2007-03-09 9:04 ` Andrey Panin 2007-03-12 10:45 ` Ahmed S. Darwish [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20070312104548.GA26264@Ahmed \ --to=darwish.07@gmail.com \ --cc=amit2030@gmail.com \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lkml.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lkml.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lkml.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lkml.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lkml.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lkml.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lkml.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lkml.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lkml.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lkml.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lkml.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git