LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Srivatsa Vaddagiri <vatsa@in.ibm.com>
To: Anton Blanchard <anton@samba.org>
Cc: Pavel Machek <pavel@ucw.cz>, "Rafael J. Wysocki" <rjw@sisk.pl>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Oleg Nesterov <oleg@tv-sign.ru>, Andrew Morton <akpm@osdl.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Aneesh Kumar <aneesh.kumar@gmail.com>,
	Gautham R Shenoy <ego@in.ibm.com>
Subject: Re: [PATCH] kthread_should_stop_check_freeze (was: Re: [PATCH -mm 3/7] Freezer: Remove PF_NOFREEZE from rcutorture thread)
Date: Tue, 13 Mar 2007 08:44:11 +0530	[thread overview]
Message-ID: <20070313031411.GC9881@in.ibm.com> (raw)
In-Reply-To: <20070312224524.GB807@kryten>

On Mon, Mar 12, 2007 at 05:45:24PM -0500, Anton Blanchard wrote:
> Then please document it _clearly_ with the kthread code somewhere. 

Document as well in the kernel_thread() API, as I notice people still
use kernel_thread() some places (ex: rtasd.c in powerpc arch)?

> The reason I brought this up is I had no idea we had to put the freezer gunk
> in all kernel thread loops and Ive been writing kernel threads for years.

I noticed that in the Powerpc code (atleast for rtas kernel thread)
here:

	http://lkml.org/lkml/2007/1/9/61

That was not a serious problem perhaps because process freezer was mostly used
in software suspend and only those platforms supporting software suspend
had to worry abt it.

But now we intend to use process freezer for CPU hotplug as well, so all
platforms wanting to support CPU hotplug better support process freezer!

P.S : I believe kprobes is already using process freezer as well.

-- 
Regards,
vatsa

  reply	other threads:[~2007-03-13  3:07 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-26  7:00 [PATCH -mm 0/6] Freezer changes Rafael J. Wysocki
2007-02-26  7:02 ` [PATCH -mm 1/6] Freezer: Read PF_BORROWED_MM in a nonracy way Rafael J. Wysocki
2007-02-26  7:05 ` [PATCH -mm 2/6] Freezer: Fix memory ordering in refrigerator Rafael J. Wysocki
2007-02-26 11:32   ` Oleg Nesterov
2007-02-26  7:06 ` [PATCH -mm 3/6] Freezer: Close theoretical race between refrigerator and thaw_tasks Rafael J. Wysocki
2007-02-26  7:08 ` [PATCH -mm 4/6] Freezer: Remove PF_NOFREEZE from rcutorture thread Rafael J. Wysocki
2007-02-26  7:11 ` [PATCH -mm 5/6] Freezer: Remove PF_NOFREEZE from bluetooth threads Rafael J. Wysocki
2007-02-26  7:13 ` [PATCH -mm 6/6] Freezer: Add try_to_freeze calls to all kernel threads Rafael J. Wysocki
2007-03-01 15:05 ` [PATCH -mm 0/7] Freezer changes (take 2) Rafael J. Wysocki
2007-03-01 15:06   ` [PATCH -mm 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way Rafael J. Wysocki
2007-03-01 15:08   ` [PATCH -mm 2/7] Freezer: Close theoretical race between refrigerator and thaw_tasks Rafael J. Wysocki
2007-03-01 16:39     ` Pavel Machek
2007-03-01 15:09   ` [PATCH -mm 3/7] Freezer: Remove PF_NOFREEZE from rcutorture thread Rafael J. Wysocki
2007-03-01 19:38     ` Anton Blanchard
2007-03-01 19:54       ` Rafael J. Wysocki
2007-03-02 21:35         ` Paul E. McKenney
2007-03-02 22:16           ` Anton Blanchard
2007-03-02 23:33           ` Oleg Nesterov
2007-03-03  0:58             ` Paul E. McKenney
2007-03-03 17:32               ` Oleg Nesterov
2007-03-04  4:34                 ` Srivatsa Vaddagiri
2007-03-11 17:49                 ` [PATCH] kthread_should_stop_check_freeze (was: Re: [PATCH -mm 3/7] Freezer: Remove PF_NOFREEZE from rcutorture thread) Rafael J. Wysocki
2007-03-12  4:38                   ` Paul E. McKenney
2007-03-12  8:14                     ` Pavel Machek
2007-03-12 11:19                       ` Rafael J. Wysocki
2007-03-12 12:23                         ` Oleg Nesterov
2007-03-12 13:24                           ` [PATCH] kthread_should_stop_check_freeze Cedric Le Goater
2007-03-12 18:25                             ` Rafael J. Wysocki
2007-03-12 22:39                         ` [PATCH] kthread_should_stop_check_freeze (was: Re: [PATCH -mm 3/7] Freezer: Remove PF_NOFREEZE from rcutorture thread) Pavel Machek
2007-03-12 22:45                           ` Anton Blanchard
2007-03-13  3:14                             ` Srivatsa Vaddagiri [this message]
2007-03-13  9:16                               ` Christoph Hellwig
2007-03-13  9:58                                 ` Srivatsa Vaddagiri
2007-03-13 10:20                                   ` Christoph Hellwig
2007-03-20 18:08                             ` Pavel Machek
2007-03-13  0:58                           ` Paul E. McKenney
2007-03-20 18:10                             ` Pavel Machek
2007-03-13  5:27                   ` Gautham R Shenoy
2007-03-13  5:42                     ` Srivatsa Vaddagiri
2007-03-03  1:03             ` [PATCH -mm 3/7] Freezer: Remove PF_NOFREEZE from rcutorture thread Rafael J. Wysocki
2007-03-02  6:57     ` Gautham R Shenoy
2007-03-02 21:46       ` Paul E. McKenney
2007-03-01 15:10   ` [PATCH -mm 4/7] Freezer: Remove PF_NOFREEZE from bluetooth threads Rafael J. Wysocki
2007-03-01 15:12   ` [PATCH -mm 5/7] Freezer: Add try_to_freeze calls to all kernel threads Rafael J. Wysocki
2007-03-01 15:15   ` [PATCH -mm 6/7] Freezer: Fix vfork problem Rafael J. Wysocki
2007-03-01 15:17   ` [PATCH -mm 7/7] Freezer: Take kernel_execve into consideration Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070313031411.GC9881@in.ibm.com \
    --to=vatsa@in.ibm.com \
    --cc=akpm@osdl.org \
    --cc=aneesh.kumar@gmail.com \
    --cc=anton@samba.org \
    --cc=ego@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    --subject='Re: [PATCH] kthread_should_stop_check_freeze (was: Re: [PATCH -mm 3/7] Freezer: Remove PF_NOFREEZE from rcutorture thread)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).