LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Kandan Venkataraman <kven709@cse.unsw.EDU.AU>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] Loop device - Tracking page writes made to a loop device through mmap
Date: Tue, 13 Mar 2007 20:32:44 +0000	[thread overview]
Message-ID: <20070313203244.GA13914@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0703140712080.18655@williams.orchestra.cse.unsw.EDU.AU>

On Wed, Mar 14, 2007 at 07:21:41AM +1100, Kandan Venkataraman wrote:
> All comments have been taken care of.
> 
> Description:
> 
> A  file_operations structure variable called loop_fops is initialised with
> the default block device file operations (def_blk_fops).
> The mmap operation is overriden with a new function called loop_file_mmap.

NACK.  block device driver should never ever play around with file
operations themselves.  If you want functionality like the one you
have please don't overload the loop driver, but start a new (character)
driver doing specificaly what you want.  And even then I'm not sure
we'd want functionality like this in the mainline tree, but at least
we can have an open discussion if it's done properly.


  reply	other threads:[~2007-03-13 20:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-13 20:21 Kandan Venkataraman
2007-03-13 20:32 ` Christoph Hellwig [this message]
2007-03-14 22:57   ` Kandan Venkataraman
  -- strict thread matches above, loose matches on Subject: below --
2007-03-08  3:01 Kandan Venkataraman
2007-03-01  5:25 Kandan Venkataraman
2007-03-01 21:58 ` Randy Dunlap
2007-03-02 10:31   ` Kandan Venkataraman
2007-03-02 11:13   ` Kandan Venkataraman
2007-03-02 16:52     ` Randy Dunlap
2007-03-02 23:21       ` Kandan Venkataraman
2007-03-02 23:28       ` Kandan Venkataraman
2007-03-03  5:46       ` Kandan Venkataraman
2007-03-01  1:40 Kandan Venkataraman
2007-03-01 19:52 ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070313203244.GA13914@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=kven709@cse.unsw.EDU.AU \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] Loop device - Tracking page writes made to a loop device through mmap' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).