From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1161196AbXCNMZe@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1161196AbXCNMZe (ORCPT <rfc822;w@1wt.eu>);
	Wed, 14 Mar 2007 08:25:34 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161212AbXCNMZe
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 14 Mar 2007 08:25:34 -0400
Received: from mx2.mail.elte.hu ([157.181.151.9]:52156 "EHLO mx2.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1161196AbXCNMZd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 14 Mar 2007 08:25:33 -0400
Date: Wed, 14 Mar 2007 13:24:53 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>, linux-kernel@vger.kernel.org,
       Andrew Morton <akpm@linux-foundation.org>, Adrian Bunk <bunk@stusta.de>,
       Alexander Viro <viro@ftp.linux.org.uk>
Subject: Re: [PATCH 58/59] sysctl: Reimplement the sysctl proc support
Message-ID: <20070314122453.GA5775@elte.hu>
References: <m1ac0jc4no.fsf@ebiederm.dsl.xmission.com> <11689657073389-git-send-email-ebiederm@xmission.com> <20070314103832.GA16104@elte.hu> <b6fcc0a0703140348o18a4b24fye3dcbad593cf83a5@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b6fcc0a0703140348o18a4b24fye3dcbad593cf83a5@mail.gmail.com>
User-Agent: Mutt/1.4.2.2i
X-ELTE-VirusStatus: clean
X-ELTE-SpamScore: -2.0
X-ELTE-SpamLevel: 
X-ELTE-SpamCheck: no
X-ELTE-SpamVersion: ELTE 2.0 
X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.0.3
	-2.0 BAYES_00               BODY: Bayesian spam probability is 0 to 1%
	[score: 0.0000]
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org


* Alexey Dobriyan <adobriyan@gmail.com> wrote:

> On 3/14/07, Ingo Molnar <mingo@elte.hu> wrote:
> > #define PROCNAME_PML    "sys/kernel/preempt_max_latency"
> >
> > static __init int latency_fs_init(void)
> > {
> >         struct proc_dir_entry *entry;
> >
> >         if (!(entry = create_proc_entry(PROCNAME_PML, 0644, NULL)))
> >                 printk("latency_fs_init(): can't create %s\n",
> >PROCNAME_PML);
> >
> > with your change that broke because beyond /proc/sys/ there are no 
> > real proc entries anymore, there's no de->subdir directory for 
> > xlate_proc_name() to find. While the latency tracer isnt upstream, 
> > this change in semantics does not seem to be intended (the changelog 
> > is certainly silent about it).
> 
> Use register_sysctl_table() for sysctls.

yes - i just wanted to point out the incompatibility and subtle breakage 
that this change caused. I'll now have to convert the current code over 
to sysctl_table, which isnt that hard but not trivial either, and i 
certainly could make use that time for other purposes.

	Ingo