From: "Ahmed S. Darwish" <darwish.07@gmail.com> To: hannes-kernel@saeurebad.de Cc: kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org, trivial@kernel.org Subject: Re: [PATCH 2.6.21-rc4] kernel/exit: Fix a comment and code contradiction Date: Sat, 17 Mar 2007 17:00:21 +0200 Message-ID: <20070317150021.GA3618@Ahmed> (raw) In-Reply-To: <20070317093856.GB32496@leiferikson> [Johannes please use replay-to-all to notify all readers] On 2007-03-17 9:45:36 Johannes Weiner wrote: > On Sat, Mar 17, 2007 at 08:21:32AM +0200, Ahmed S. Darwish wrote: > > Comment in release_task() claims that group leader's parent process > > is signalled only if it desires so, which is not true. > > AFAIS, `if it wants notification' means, it does not ignore its children > via SIG_IGN als handler for SIGCHLD. > AFAIK, exit_signal = -1 means that the parent don't want to be signalled, like what happenes when using CLONE_THREAD. But it's even signalled in that case (after issuing a BUG): BUG_ON(leader->exit_signal == -1); do_notify_parent(leader, leader->exit_signal); > do_notify_parent() checks if the parent wants to get informed about the > child states. > Yes it does the check but it notifies the given task_struct anyway: BUG_ON(sig == -1); [ Continue parent notification normally ] -- Ahmed S. Darwish http://darwish.07.googlepages.com
prev parent reply index Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-03-17 6:21 Ahmed S. Darwish 2007-03-17 9:45 ` Johannes Weiner 2007-03-17 15:00 ` Ahmed S. Darwish [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20070317150021.GA3618@Ahmed \ --to=darwish.07@gmail.com \ --cc=hannes-kernel@saeurebad.de \ --cc=kernel-janitors@lists.osdl.org \ --cc=linux-kernel@vger.kernel.org \ --cc=trivial@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lkml.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lkml.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lkml.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lkml.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lkml.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lkml.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lkml.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lkml.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lkml.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lkml.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lkml.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git