LKML Archive on
help / color / mirror / Atom feed
* drivers/infiniband/ulp/ipoib/ipoib_main.c: use-after-free
@ 2007-03-19  9:23 Adrian Bunk
  2007-03-19  9:46 ` [ofa-general] " Michael S. Tsirkin
  0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2007-03-19  9:23 UTC (permalink / raw)
  To: Michael S. Tsirkin
  Cc: Roland Dreier, mshefty, halr, openib-general, linux-kernel

The Coverity checker spotted the following code introduced by
commit 839fcaba355abaffb7b44f0f4504093acb0b11cf:

<--  snip  -->

static void path_rec_completion(int status,
                                struct ib_sa_path_rec *pathrec,
                                void *path_ptr)
                list_for_each_entry(neigh, &path->neigh_list, list) {
                        neigh->ah = path->ah;
                        memcpy(&neigh->dgid.raw, &path->pathrec.dgid.raw,
                               sizeof(union ib_gid));

                        if (ipoib_cm_enabled(dev, neigh->neighbour)) {
                                if (!ipoib_cm_get(neigh))
                                        ipoib_cm_set(neigh, ipoib_cm_create_tx(dev,
                                if (!ipoib_cm_get(neigh)) {
                                        if (neigh->ah)
                                        ipoib_neigh_free(dev, neigh);

                        while ((skb = __skb_dequeue(&neigh->queue)))
                                __skb_queue_tail(&skqueue, skb);

<--  snip  -->

Notice that before the continue "neigh" gets freed, but the 
list_for_each_entry() for() loop uses it.



       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-03-22 18:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-03-19  9:23 drivers/infiniband/ulp/ipoib/ipoib_main.c: use-after-free Adrian Bunk
2007-03-19  9:46 ` [ofa-general] " Michael S. Tsirkin
2007-03-22 18:04   ` Roland Dreier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).