LKML Archive on
help / color / mirror / Atom feed
* [PATCH][0/5][resend] floppy.c: first round of cleanup patches - the simple stuff
@ 2007-03-19 15:09 Jesper Juhl
  0 siblings, 0 replies; only message in thread
From: Jesper Juhl @ 2007-03-19 15:09 UTC (permalink / raw)
  To: Andrew Morton
  Cc: LKML, Andi Kleen, Trent Waddington, Bartlomiej Zolnierkiewicz,
	Alan Cox, Jesper Juhl

Greetings people,

A while back I promised to do some floppy.c cleanups and created an initial 
set of patches. Those patches got some good feedback but never got merged.
I want to continue with more substantial cleanups, but it would be nice to get 
the initial (rather trivial) bits in first so I can submit further patches on 

I've been using these patches myself without any problems and they have also 
been Ack'ed by a few people;
	Alan Cox said:
		"Acked-by: Alan Cox <>
		 for the set of 5 patches. Its a beginning and removing the dead wood so
		 you can see what is actually there is a good a beginning as any other."
	Bartlomiej Zolnierkiewicz said:
		"Seconded, looks like a good beginning.
		 You may also add my ACK for the whole set."

Andi Kleen commented that the real problem with floppy.c is the basic code 
logic and that most of the code I'm fixing up here probably has to be 
replaced later anyway - there's no doubt that's correct, but I need to start 
somewhere and starting with these small patches makes the file a lot easier 
for me to work with and I think they are a nice little initial cleanup until 
I get a chance to do something more substantial (which probably won't be for 
another month and a half since I'm currently without internet connectivity at 

There are 5 patches in this series. They are based on current Linus -git and 
are incremental.

These are the patches (they'll be posted to the same recipients as this 
mail) :

       [PATCH][1/5][resend] floppy.c: Initial (partial) CodingStyle cleanup
       [PATCH][2/5][resend] floppy.c: Remove pointless register keywords
       [PATCH][3/5][resend] floppy.c: Remove dead/commented out code
       [PATCH][4/5][resend] floppy.c: Add explicit/better printk() levels
       [PATCH][5/5][resend] floppy.c: Fix device_create_file() warning

The Cc list is composed of people who expressed interrest in this cleanup +
people who look like original authors of the code (for whom I could locate
email addresses) etc.

Andrew: Could you please merge these into -mm? And if you could push them to 
Linus after a bit of time in -mm that would be greatly appreciated as well.

Kind regards,

 Jesper Juhl <>

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-03-19 15:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-03-19 15:09 [PATCH][0/5][resend] floppy.c: first round of cleanup patches - the simple stuff Jesper Juhl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).