LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Johannes Weiner <hannes-kernel@saeurebad.de>
To: kernel list <linux-kernel@vger.kernel.org>
Subject: Re: "reboot" swsusp mode leaves moon icon blinking
Date: Tue, 20 Mar 2007 17:50:59 +0100	[thread overview]
Message-ID: <20070320165058.GA15888@leiferikson> (raw)
In-Reply-To: <20070320123245.GA19019@elf.ucw.cz>

Hi,

On Tue, Mar 20, 2007 at 01:32:45PM +0100, Pavel Machek wrote:
> Date: Tue, 20 Mar 2007 13:32:45 +0100
> From: Pavel Machek <pavel@ucw.cz>
> To: "Rafael J. Wysocki" <rjw@sisk.pl>,
> 	kernel list <linux-kernel@vger.kernel.org>
> Cc: Andrew Morton <akpm@osdl.org>
> Subject: "reboot" swsusp mode leaves moon icon blinking
> 
> Hi!
> 
> ...and cause is really simple.
> 
> During resume, we do not know that "reboot" method was used, so we
> assume plaform and make the led blink...

What does the "reboot" swsusp mean?

I am having this (or a similar problem):

	echo shutdown > /sys/power/disk; echo disk > /sys/power/state

suspends normally.  But after a resume, the moon keeps blinking _and_
I don't get ACPI events anymore.  At least all ibm-acpi features refuse
to work (hotkeys, lcd-brightness, lid, ...).

I saved some /proc files (interrupts, acpi/processor/power, ...) and
compared them before the suspend and after the resume but I could not
find any differences.

> diff --git a/kernel/power/disk.c b/kernel/power/disk.c
> index 873cdf8..dee0ff4 100644
> --- a/kernel/power/disk.c
> +++ b/kernel/power/disk.c
> @@ -241,18 +241,11 @@ static int software_resume(void)
>  		goto Done;
>  	}
>  
> -	error = platform_prepare();
> -	if (error) {
> -		swsusp_free();
> -		goto Thaw;
> -	}
> -

What is platform_prepare() actually good for when _resuming_? I tried to
follow the function calls and it seems to disable a lot of thing instead
of re-enabling them...?

=Hannes

  reply	other threads:[~2007-03-20 16:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-20 12:32 Pavel Machek
2007-03-20 16:50 ` Johannes Weiner [this message]
2007-03-20 17:00   ` Rafael J. Wysocki
2007-03-20 18:01   ` Pavel Machek
2007-03-20 22:11     ` Johannes Weiner
2007-03-20 17:05 ` Rafael J. Wysocki
2007-03-20 17:20   ` Pavel Machek
2007-03-20 21:03     ` Rafael J. Wysocki
2007-03-20 22:10       ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070320165058.GA15888@leiferikson \
    --to=hannes-kernel@saeurebad.de \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: "reboot" swsusp mode leaves moon icon blinking' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).