LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Pavel Machek <pavel@ucw.cz>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] swsusp: Do not use page flags
Date: Tue, 20 Mar 2007 22:18:16 +0100	[thread overview]
Message-ID: <200703202218.16820.rjw@sisk.pl> (raw)
In-Reply-To: <20070319173127.72c3419d.akpm@linux-foundation.org>

On Tuesday, 20 March 2007 01:31, Andrew Morton wrote:
> On Mon, 12 Mar 2007 22:19:20 +0100
> "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> 
> > Make swsusp use memory bitmaps instead of page flags for marking 'nosave' and
> > free pages.  This allows us to 'recycle' two page flags that can be used for other
> > purposes.  Also, the memory needed to store the bitmaps is allocated when
> > necessary (ie. before the suspend) and freed after the resume which is more
> > reasonable.
> > 
> > The patch is designed to minimize the amount of changes and there are some nice
> > simplifications and optimizations possible on top of it.  I am going to
> > implement them separately in the future.
> 
> Blows up with ia64 allmodconfig due to CONFIG_PM=y, CONFIG_SOFTWARE_SUSPEND=n:
> 
> kernel/power/main.c:223: error: redefinition of 'software_suspend'
> include/linux/suspend.h:46: error: previous definition of 'software_suspend' was here
> 
> I had a look at fixing it, but it's unobvious why we're compiling most of
> kernel/power/main.c when CONFIG_SOFTWARE_SUSPEND=n so I'll send this series
> back for repair please.

Well, it was sufficient to add #ifdef CONFIG_SOFTWARE_SUSPEND around the
definition of software_suspend() in kernel/power/main.c.

The following series of patches compiles with CONFIG_SOFTWARE_SUSPEND=n too.

Greetings,
Rafael


  parent reply	other threads:[~2007-03-20 21:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-12 21:14 [PATCH 0/3] swsusp: Stop using " Rafael J. Wysocki
2007-03-12 21:16 ` [PATCH 1/3] swsusp: Use inline functions for changing " Rafael J. Wysocki
2007-03-12 21:19 ` [PATCH 2/3] swsusp: Do not use " Rafael J. Wysocki
2007-03-15 19:08   ` Andrew Morton
2007-03-15 21:05     ` Rafael J. Wysocki
2007-03-15 21:29       ` Andrew Morton
2007-03-15 22:19         ` Jiri Kosina
2007-03-15 22:23           ` Andrew Morton
2007-03-16  0:01             ` Rafael J. Wysocki
2007-03-15 23:05         ` Pavel Machek
2007-03-20  0:31   ` Andrew Morton
2007-03-20 13:18     ` Pavel Machek
2007-03-20 21:18     ` Rafael J. Wysocki [this message]
2007-03-20 21:20       ` [PATCH 1/5] swsusp: Use inline functions for changing " Rafael J. Wysocki
2007-03-20 21:22       ` [PATCH 2/5] swsusp: do not use " Rafael J. Wysocki
2007-03-20 21:25       ` [PATCH 3/5] mm: remove unused " Rafael J. Wysocki
2007-03-20 21:26       ` [PATCH 4/5] swsusp: fix error paths in snapshot_open Rafael J. Wysocki
2007-03-20 22:16         ` Pavel Machek
2007-03-20 22:24           ` Rafael J. Wysocki
2007-03-20 22:24             ` Pavel Machek
2007-03-20 22:52               ` Rafael J. Wysocki
2007-03-20 21:28       ` [PATCH 5/5] swsusp: Use GFP_KERNEL for creating basic data structures Rafael J. Wysocki
2007-03-20 22:17         ` Pavel Machek
2007-03-12 21:20 ` [PATCH 3/3] mm: Remove unused page flags Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200703202218.16820.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --subject='Re: [PATCH 2/3] swsusp: Do not use page flags' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).