From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751010AbXCUK0J (ORCPT ); Wed, 21 Mar 2007 06:26:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751831AbXCUK0I (ORCPT ); Wed, 21 Mar 2007 06:26:08 -0400 Received: from moutng.kundenserver.de ([212.227.126.177]:51730 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010AbXCUK0H (ORCPT ); Wed, 21 Mar 2007 06:26:07 -0400 From: Arnd Bergmann To: bryan.wu@analog.com Subject: Re: [PATCH -mm 1/4] Blackfin: architecture update patch Date: Wed, 21 Mar 2007 11:25:39 +0100 User-Agent: KMail/1.9.6 Cc: Andrew Morton , Paul Mundt , bert hubert , linux-kernel@vger.kernel.org References: <1174471618.5648.50.camel@roc-desktop> In-Reply-To: <1174471618.5648.50.camel@roc-desktop> X-Face: >j"dOR3XO=^3iw?0`(E1wZ/&le9!.ok[JrI=S~VlsF~}"P\+jx.GT@=?utf-8?q?=0A=09-oaEG?=,9Ba>v;3>:kcw#yO5?B:l{(Ln.2)=?utf-8?q?=27=7Dfw07+4-=26=5E=7CScOpE=3F=5D=5EXdv=5B/zWkA7=60=25M!DxZ=0A=09?= =?utf-8?q?8MJ=2EU5?="hi+2yT(k`PF~Zt;tfT,i,JXf=x@eLP{7B:"GyA\=UnN) =?utf-8?q?=26=26qdaA=3A=7D-Y*=7D=3A3YvzV9=0A=09=7E=273a=7E7I=7CWQ=5D?=<50*%U-6Ewmxfzdn/CK_E/ouMU(r?FAQG/ev^JyuX.%(By`" =?utf-8?q?L=5F=0A=09H=3Dbj?=)"y7*XOqz|SS"mrZ$`Q_syCd MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200703211125.39816.arnd@arndb.de> X-Provags-ID: V01U2FsdGVkX19m8gzt4OoGRsJT+hqrAdreNbkY/28G23Y+T9W z2mgZB3Ipp8kaojeQwcwrErofsjFSAPtCqqOqpxijcnYFq/jxQ 1tiyIhy2l7l08KdQFfdIg== Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 21 March 2007, Wu, Bryan wrote: > @@ -97,6 +97,11 @@ static inline void leds_switch(int flag) > /* > * The idle loop on BFIN > */ > +#ifdef CONFIG_IDLE_L1 > +static inline void default_idle(void)__attribute__((l1_text)); > +void cpu_idle(void)__attribute__((l1_text)); > +#endif > + A forward declaration for an inline function seems rather pointless. Moreover, marking default_idle both l1_text and inline seems contradicting, right? > diff -purN linux-2.6-orig/include/asm-blackfin/asm-offsets.h linux-2.6/include/asm-blackfin/asm-offsets.h > --- linux-2.6-orig/include/asm-blackfin/asm-offsets.h 1970-01-01 08:00:00.000000000 +0800 > +++ linux-2.6/include/asm-blackfin/asm-offsets.h 2007-03-21 15:21:10.000000000 +0800 > @@ -0,0 +1,89 @@ > +#ifndef __ASM_OFFSETS_H__ > +#define __ASM_OFFSETS_H__ > +/* > + * DO NOT MODIFY. > + * > + * This file was generated by Kbuild This file should be in the exclude list for your diff, it is generally not shipped with the kernel sources. > +#ifndef __ASSEMBLY__ > + > +static inline unsigned char readb(volatile unsigned char *addr) > +{ The prototype for this should normally contain an __iomem. This kind of error is normally caught by running 'make C=1' to use the 'sparse' tool. If you have not run that yet, you should start to, as it finds a number of common bugs. > +/* > + * Map some physical address range into the kernel address space. > + */ > +static inline void *__ioremap(unsigned long physaddr, unsigned long size, > + int cacheflag) > +{ > + return (void *)physaddr; > +} Likewise, this should return an __iomem pointer. The rest of the patch looks good to me. Arnd <><