LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] FRV: Fix unannotated variable declarations
@ 2007-03-21 17:06 David Howells
2007-03-22 2:17 ` Yasunori Goto
0 siblings, 1 reply; 2+ messages in thread
From: David Howells @ 2007-03-21 17:06 UTC (permalink / raw)
To: torvalds, akpm, y-goto; +Cc: linux-kernel, dhowells
From: David Howells <dhowells@redhat.com>
Fix unannotated variable declarations. Variables that have allocation section
annotations (such as __meminitdata) on their definitions must also have them on
their declarations as not doing so may affect the addressing mode used by the
compiler and may result in a linker error.
Signed-Off-By: David Howells <dhowells@redhat.com>
---
include/linux/bootmem.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/bootmem.h b/include/linux/bootmem.h
index 2275f27..81c07cd 100644
--- a/include/linux/bootmem.h
+++ b/include/linux/bootmem.h
@@ -108,7 +108,7 @@ static inline void *alloc_remap(int nid, unsigned long size)
#endif /* CONFIG_HAVE_ARCH_ALLOC_REMAP */
extern unsigned long __meminitdata nr_kernel_pages;
-extern unsigned long nr_all_pages;
+extern unsigned long __meminitdata nr_all_pages;
extern void *alloc_large_system_hash(const char *tablename,
unsigned long bucketsize,
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] FRV: Fix unannotated variable declarations
2007-03-21 17:06 [PATCH] FRV: Fix unannotated variable declarations David Howells
@ 2007-03-22 2:17 ` Yasunori Goto
0 siblings, 0 replies; 2+ messages in thread
From: Yasunori Goto @ 2007-03-22 2:17 UTC (permalink / raw)
To: David Howells; +Cc: torvalds, akpm, linux-kernel
> From: David Howells <dhowells@redhat.com>
>
> Fix unannotated variable declarations. Variables that have allocation section
> annotations (such as __meminitdata) on their definitions must also have them on
> their declarations as not doing so may affect the addressing mode used by the
> compiler and may result in a linker error.
Right. Thanks.
Acked-by: Yasunori Goto <y-goto@jp.fujitsu.com>
--
Yasunori Goto
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-22 2:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-03-21 17:06 [PATCH] FRV: Fix unannotated variable declarations David Howells
2007-03-22 2:17 ` Yasunori Goto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).