[PATCH 2/2] Export deferrable timer through workqueue and use it in ondemand governor

[PATCH 2/2] Export deferrable timer through workqueue and use it in ondemand governor

[Venkatesh Pallipadi]

Add a new deferrable delayed work init. This can be used to schedule work
that are 'unimportant' when CPU is idle and can be called later, when CPU
eventually comes out of idle.

Use this init in cpufreq ondemand governor.
 
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>

Index: new/drivers/cpufreq/cpufreq_ondemand.c
===================================================================
--- new.orig/drivers/cpufreq/cpufreq_ondemand.c	2007-03-21 09:16:52.000000000 -0800
+++ new/drivers/cpufreq/cpufreq_ondemand.c	2007-03-21 09:18:08.000000000 -0800
@@ -470,7 +470,7 @@
 	dbs_info->enable = 1;
 	ondemand_powersave_bias_init();
 	dbs_info->sample_type = DBS_NORMAL_SAMPLE;
-	INIT_DELAYED_WORK(&dbs_info->work, do_dbs_timer);
+	INIT_DELAYED_WORK_DEF(&dbs_info->work, do_dbs_timer);
 	queue_delayed_work_on(dbs_info->cpu, kondemand_wq, &dbs_info->work,
 	                      delay);
 }
Index: new/include/linux/workqueue.h
===================================================================
--- new.orig/include/linux/workqueue.h	2007-03-21 09:16:52.000000000 -0800
+++ new/include/linux/workqueue.h	2007-03-21 09:18:08.000000000 -0800
@@ -115,6 +115,12 @@
 		init_timer(&(_work)->timer);			\
 	} while (0)
 
+#define INIT_DELAYED_WORK_DEF(_work, _func)			\
+	do {							\
+		INIT_WORK(&(_work)->work, (_func));		\
+		init_timer_deferrable(&(_work)->timer);		\
+	} while (0)
+
 #define INIT_DELAYED_WORK_NAR(_work, _func)			\
 	do {							\
 		INIT_WORK_NAR(&(_work)->work, (_func));		\

Re: [PATCH 2/2] Export deferrable timer through workqueue and use it in ondemand governor

[Dave Jones]

On Wed, Mar 21, 2007 at 01:23:40PM -0700, Venkatesh Pallipadi wrote:
 > 
 > 
 > Add a new deferrable delayed work init. This can be used to schedule work
 > that are 'unimportant' when CPU is idle and can be called later, when CPU
 > eventually comes out of idle.
 > 
 > Use this init in cpufreq ondemand governor.
 >  
 > Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>

drivers/cpufreq/cpufreq_ondemand.c: In function 'dbs_timer_init':
drivers/cpufreq/cpufreq_ondemand.c:473: error: implicit declaration of function 'init_timer_deferrable'

	Dave

-- 
http://www.codemonkey.org.uk

Re: [PATCH 2/2] Export deferrable timer through workqueue and use it in ondemand governor

[Venki Pallipadi]

On Mar 21, 2007, at 3:04 PM, Dave Jones wrote:

> On Wed, Mar 21, 2007 at 01:23:40PM -0700, Venkatesh Pallipadi wrote:
>>
>>
>> Add a new deferrable delayed work init. This can be used to  
>> schedule work
>> that are 'unimportant' when CPU is idle and can be called later,  
>> when CPU
>> eventually comes out of idle.
>>
>> Use this init in cpufreq ondemand governor.
>>
>> Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
>
> drivers/cpufreq/cpufreq_ondemand.c: In function 'dbs_timer_init':
> drivers/cpufreq/cpufreq_ondemand.c:473: error: implicit declaration  
> of function 'init_timer_deferrable'
>
>


init_timer_deferrable is defined in
[PATCH 1/2] Add support for deferrable timers
http://www.ussg.iu.edu/hypermail/linux/kernel/0703.2/2064.html

Do you get this error after that patch?

Thanks,
~Venki

Re: [PATCH 2/2] Export deferrable timer through workqueue and use it in ondemand governor

[Dave Jones]

On Wed, Mar 21, 2007 at 03:19:45PM -0700, Venki Pallipadi wrote:

 > init_timer_deferrable is defined in
 > [PATCH 1/2] Add support for deferrable timers
 > http://www.ussg.iu.edu/hypermail/linux/kernel/0703.2/2064.html
 > 
 > Do you get this error after that patch?

Ah, looks like I had 1/2 from the previous iteration of this patch.

	Dave

-- 
http://www.codemonkey.org.uk