LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Problem with fix-rmmod-read-write-races-in-proc-entries.patch in 2.6.21-rc4-mm1
@ 2007-03-22  8:14 Eric Dumazet
  2007-03-22  8:28 ` Al Viro
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2007-03-22  8:14 UTC (permalink / raw)
  To: Alexey Dobriyan; +Cc: Andrew Morton, linux kernel

Hi Alexey,

It seems you are fix-rmmod-read-write-races-in-proc-entries.patch author ?

/proc/kcore is no longer seekable (or mappable)

Also, do we really need to proxy via proc_reg_file_ops files that are not provided by a module ?

I think not.

Could you please add in proc_get_inode() a check against de->proc_fops->owner ?

if (de->proc_fops) {
#ifdef CONFIG_MODULE
    if (S_ISREG(inode->i_mode) && de->proc_fops->owner)
        inode->i_fop = &proc_reg_file_ops;
    else
#endif
        inode->i_fop = de->proc_fops;
}

Maybe the whole proc_reg_XXX() functions could be omitted for a kernel without module support ?

Thank you
Eric

^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: Problem with fix-rmmod-read-write-races-in-proc-entries.patch in 2.6.21-rc4-mm1
  2007-03-22  8:14 Problem with fix-rmmod-read-write-races-in-proc-entries.patch in 2.6.21-rc4-mm1 Eric Dumazet
@ 2007-03-22  8:28 ` Al Viro
  0 siblings, 0 replies; 2+ messages in thread
From: Al Viro @ 2007-03-22  8:28 UTC (permalink / raw)
  To: Eric Dumazet; +Cc: Alexey Dobriyan, Andrew Morton, linux kernel

On Thu, Mar 22, 2007 at 09:14:45AM +0100, Eric Dumazet wrote:
> Also, do we really need to proxy via proc_reg_file_ops files that are not provided by a module ?
> 
> I think not.
> 
> Could you please add in proc_get_inode() a check against de->proc_fops->owner ?

Let's _not_.  Bugs that depend on whether driver is built modular are
hell to deal with.

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-22  8:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-03-22  8:14 Problem with fix-rmmod-read-write-races-in-proc-entries.patch in 2.6.21-rc4-mm1 Eric Dumazet
2007-03-22  8:28 ` Al Viro

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).