Re: [linux-pm] [patch 2/2] clk_must_disable() implementation on AT91

[Pavel Machek <pavel@ucw.cz>]

Hi!

> This supports the new clk_must_disable() interface for AT91 systems:
> 
>  - Implement the call, replacing at91_suspend_entering_slow_clock()
>    and eliminating various "that's not exported" build warnings;
> 
>  - Use it in three drivers: USB Host, USB Peripheral, and RS232 serial.
> 
> Briefly, those are three of the drivers that need to act differently when
> going into deeper sleep states (suspend-to-RAM, vs standby), since among
> other things they can't act as wakeup event sources without using the
> clocks which are disabled in those deeper sleep states.
> 
> (The at91_ethernet driver would be another such driver, but it doesn't
> currently implement wake-on-LAN even in the "standby" mode.)
> 
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

FWIW, it looks okay to me. But you probably need to cc akpm if you
want it merged...

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html