Re: mm snapshot broken-out-2007-03-24-00-14.tar.gz uploaded

Re: mm snapshot broken-out-2007-03-24-00-14.tar.gz uploaded

[Michal Piotrowski]

Hi,

akpm@linux-foundation.org napisał(a):
> The mm snapshot broken-out-2007-03-24-00-14.tar.gz has been uploaded to
> 
>    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-03-24-00-14.tar.gz
> 
> It contains the following patches against 2.6.21-rc4:

Bryan, your patch (blackfin-arch-2.6.21-rc4-mm1-update.patch) doesn't apply
clean. I've got a lot of "1 out of 1 hunk FAILED -- rejects in file".

Applying patch patches/blackfin-arch-2.6.21-rc4-mm1-update.patch
patching file arch/blackfin/Kconfig
patching file arch/blackfin/Makefile
patching file arch/blackfin/kernel/Makefile
patching file arch/blackfin/kernel/asm-offsets.c
Hunk #1 FAILED at 6.
1 out of 1 hunk FAILED -- rejects in file arch/blackfin/kernel/asm-offsets.c
patching file arch/blackfin/kernel/bfin_dma_5xx.c
Hunk #1 FAILED at 6.
1 out of 17 hunks FAILED -- rejects in file arch/blackfin/kernel/bfin_dma_5xx.c
patching file arch/blackfin/kernel/bfin_gpio.c
Hunk #1 FAILED at 6.
1 out of 12 hunks FAILED -- rejects in file arch/blackfin/kernel/bfin_gpio.c
patching file arch/blackfin/kernel/bfin_ksyms.c
Hunk #1 FAILED at 6.
1 out of 1 hunk FAILED -- rejects in file arch/blackfin/kernel/bfin_ksyms.c
patching file arch/blackfin/kernel/dma-mapping.c
Hunk #1 FAILED at 6.
1 out of 5 hunks FAILED -- rejects in file arch/blackfin/kernel/dma-mapping.c
patching file arch/blackfin/kernel/dualcore_test.c
Hunk #1 FAILED at 6.
1 out of 1 hunk FAILED -- rejects in file arch/blackfin/kernel/dualcore_test.c
patching file arch/blackfin/kernel/entry.S
Hunk #1 FAILED at 6.
1 out of 2 hunks FAILED -- rejects in file arch/blackfin/kernel/entry.S
patching file arch/blackfin/kernel/flat.c
patching file arch/blackfin/kernel/init_task.c
Hunk #1 FAILED at 6.
1 out of 3 hunks FAILED -- rejects in file arch/blackfin/kernel/init_task.c

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group (PL)
(http://www.stardust.webpages.pl/ltg/)
LTG - Linux Testers Group (EN)
(http://www.stardust.webpages.pl/linux_testers_group_en/)

Re: mm snapshot broken-out-2007-03-24-00-14.tar.gz uploaded

[Michal Piotrowski]

On 24/03/07, akpm@linux-foundation.org <akpm@linux-foundation.org> wrote:
> The mm snapshot broken-out-2007-03-24-00-14.tar.gz has been uploaded to
>
>    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-03-24-00-14.tar.gz
>
> It contains the following patches against 2.6.21-rc4:
>

Please drop net-uninline-skb_put-fix.patch

In file included from include/linux/if_ether.h:111,
                 from include/linux/netdevice.h:29,
                 from include/net/sock.h:48,
                 from kernel/audit.c:54:
include/linux/skbuff.h: In function 'skb_put':
include/linux/skbuff.h:885: warning: implicit declaration of function
'skb_over_panic'
  CC      kernel/auditfilter.o
In file included from include/linux/netlink.h:139,
                 from kernel/auditfilter.c:28:
include/linux/skbuff.h: In function 'skb_put':
include/linux/skbuff.h:885: warning: implicit declaration of function
'skb_over_panic'
  CC      kernel/auditsc.o
In file included from include/linux/netlink.h:139,
                 from kernel/auditsc.c:59:
include/linux/skbuff.h: In function 'skb_put':
include/linux/skbuff.h:885: warning: implicit declaration of function
'skb_over_panic'
  CC      kernel/ksysfs.o
  CC      kernel/softlockup.o
  CC      kernel/relay.o
  CC      kernel/utsname_sysctl.o
  CC      kernel/delayacct.o
In file included from include/linux/netlink.h:139,
                 from include/linux/genetlink.h:4,
                 from include/net/genetlink.h:4,
                 from include/linux/taskstats_kern.h:12,
                 from include/linux/delayacct.h:21,
                 from kernel/delayacct.c:20:
include/linux/skbuff.h: In function 'skb_put':
include/linux/skbuff.h:885: warning: implicit declaration of function
'skb_over_panic'
  CC      kernel/taskstats.o
In file included from include/linux/netlink.h:139,
                 from include/linux/genetlink.h:4,
                 from include/net/genetlink.h:4,
                 from include/linux/taskstats_kern.h:12,
                 from kernel/taskstats.c:20:
include/linux/skbuff.h: In function 'skb_put':
include/linux/skbuff.h:885: warning: implicit declaration of function
'skb_over_panic'

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group (PL)
(http://www.stardust.webpages.pl/ltg/)
LTG - Linux Testers Group (EN)
(http://www.stardust.webpages.pl/linux_testers_group_en/)

Re: mm snapshot broken-out-2007-03-24-00-14.tar.gz uploaded

[Andrew Morton]

On Sat, 24 Mar 2007 12:35:33 +0100 Michal Piotrowski <michal.k.k.piotrowski@gmail.com> wrote:

> 
> akpm@linux-foundation.org napisał(a):
> > The mm snapshot broken-out-2007-03-24-00-14.tar.gz has been uploaded to
> > 
> >    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-03-24-00-14.tar.gz
> > 
> > It contains the following patches against 2.6.21-rc4:
> 
> Bryan, your patch (blackfin-arch-2.6.21-rc4-mm1-update.patch) doesn't apply
> clean. I've got a lot of "1 out of 1 hunk FAILED -- rejects in file".
> 
> Applying patch patches/blackfin-arch-2.6.21-rc4-mm1-update.patch
> patching file arch/blackfin/Kconfig
> patching file arch/blackfin/Makefile
> patching file arch/blackfin/kernel/Makefile
> patching file arch/blackfin/kernel/asm-offsets.c
> Hunk #1 FAILED at 6.
> 1 out of 1 hunk FAILED -- rejects in file arch/blackfin/kernel/asm-offsets.c
> patching file arch/blackfin/kernel/bfin_dma_5xx.c

That's because it contains CVS control strings.  I fixed it locally,
but please don't add CVS control strings to the kernel.

Re: mm snapshot broken-out-2007-03-24-00-14.tar.gz uploaded

[Michal Piotrowski]

On 24/03/07, akpm@linux-foundation.org <akpm@linux-foundation.org> wrote:
> The mm snapshot broken-out-2007-03-24-00-14.tar.gz has been uploaded to
>
>    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-03-24-00-14.tar.gz
>

My network doesn't work
"RTNETLINK answers: Invalid argument"

git-net* patches?

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group (PL)
(http://www.stardust.webpages.pl/ltg/)
LTG - Linux Testers Group (EN)
(http://www.stardust.webpages.pl/linux_testers_group_en/)

Re: mm snapshot broken-out-2007-03-24-00-14.tar.gz uploaded

[Andrew Morton]

On Sat, 24 Mar 2007 18:18:42 +0100 "Michal Piotrowski" <michal.k.k.piotrowski@gmail.com> wrote:

> On 24/03/07, akpm@linux-foundation.org <akpm@linux-foundation.org> wrote:
> > The mm snapshot broken-out-2007-03-24-00-14.tar.gz has been uploaded to
> >
> >    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-03-24-00-14.tar.gz
> >
> 
> My network doesn't work
> "RTNETLINK answers: Invalid argument"
> 
> git-net* patches?
> 

There's a huge collision between git-net and git-wireless which I haven't
started to look at yet.  I suggest you forget about that particular
snapshot.

Re: mm snapshot broken-out-2007-03-24-00-14.tar.gz uploaded

[David Miller]

From: Andrew Morton <akpm@linux-foundation.org>
Date: Sat, 24 Mar 2007 10:16:53 -0800

> On Sat, 24 Mar 2007 18:18:42 +0100 "Michal Piotrowski" <michal.k.k.piotrowski@gmail.com> wrote:
> 
> > On 24/03/07, akpm@linux-foundation.org <akpm@linux-foundation.org> wrote:
> > > The mm snapshot broken-out-2007-03-24-00-14.tar.gz has been uploaded to
> > >
> > >    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-03-24-00-14.tar.gz
> > >
> > 
> > My network doesn't work
> > "RTNETLINK answers: Invalid argument"
> > 
> > git-net* patches?
> > 
> 
> There's a huge collision between git-net and git-wireless which I haven't
> started to look at yet.  I suggest you forget about that particular
> snapshot.

We fixed that bug about a day after you likely took a snapshot
of the net-2.6.22 tree.

Here is the fix:

commit 65f96c1f4b549a3c3c19cebf9f0795c0d8fb35f0
Author: Thomas Graf <tgraf@suug.ch>
Date:   Thu Mar 22 21:41:06 2007 -0700

    [RTNL]: Properly return rntl message handler
    
    Signed-off-by: Thomas Graf <tgraf@suug.ch>
    Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 35ce9f7..3a295e3 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -122,10 +122,10 @@ static rtnl_doit_func rtnl_get_doit(int protocol, int msgindex)
 	struct rtnl_link *tab;
 
 	tab = rtnl_msg_handlers[protocol];
-	if (tab == NULL || tab->doit == NULL)
+	if (tab == NULL || tab[msgindex].doit == NULL)
 		tab = rtnl_msg_handlers[PF_UNSPEC];
 
-	return tab ? tab->doit : NULL;
+	return tab ? tab[msgindex].doit : NULL;
 }
 
 static rtnl_dumpit_func rtnl_get_dumpit(int protocol, int msgindex)
@@ -133,10 +133,10 @@ static rtnl_dumpit_func rtnl_get_dumpit(int protocol, int msgindex)
 	struct rtnl_link *tab;
 
 	tab = rtnl_msg_handlers[protocol];
-	if (tab == NULL || tab->dumpit == NULL)
+	if (tab == NULL || tab[msgindex].dumpit == NULL)
 		tab = rtnl_msg_handlers[PF_UNSPEC];
 
-	return tab ? tab->dumpit : NULL;
+	return tab ? tab[msgindex].dumpit : NULL;
 }
 
 /**

Re: mm snapshot broken-out-2007-03-24-00-14.tar.gz uploaded

[Michal Piotrowski]

David Miller napisał(a):
> From: Andrew Morton <akpm@linux-foundation.org>
> Date: Sat, 24 Mar 2007 10:16:53 -0800
> 
>> On Sat, 24 Mar 2007 18:18:42 +0100 "Michal Piotrowski" <michal.k.k.piotrowski@gmail.com> wrote:
>>
>>> On 24/03/07, akpm@linux-foundation.org <akpm@linux-foundation.org> wrote:
>>>> The mm snapshot broken-out-2007-03-24-00-14.tar.gz has been uploaded to
>>>>
>>>>    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-03-24-00-14.tar.gz
>>>>
>>> My network doesn't work
>>> "RTNETLINK answers: Invalid argument"
>>>
>>> git-net* patches?
>>>
>> There's a huge collision between git-net and git-wireless which I haven't
>> started to look at yet.  I suggest you forget about that particular
>> snapshot.
> 
> We fixed that bug about a day after you likely took a snapshot
> of the net-2.6.22 tree.
> 
> Here is the fix:
> 

Problem fixed, thanks.

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group (PL)
(http://www.stardust.webpages.pl/ltg/)
LTG - Linux Testers Group (EN)
(http://www.stardust.webpages.pl/linux_testers_group_en/)