LKML Archive on
help / color / mirror / Atom feed
From: Andrew Morton <>
To: Jean Delvare <>
Cc: LKML <>,
	Rudolf Marek <>,
	Alexey Dobriyan <>,
	Dave Jones <>
Subject: Re: [PATCH 1/2] MSR: Add support for safe variants
Date: Sun, 25 Mar 2007 14:22:15 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sun, 25 Mar 2007 14:18:23 +0200 Jean Delvare <> wrote:

> Add support for _safe (exception handled) variants of rdmsr_on_cpu 
> and wrmsr_on_cpu.  This is needed for the upcoming coretemp hardware
> monitoring driver, which might step into non-existing (poorly
> documented) MSR.

Crappy changelog.  What do these functions do?  What is "safe" about them? 
This is described in neither the changelog nor the code comments, but it
should be described in both.

Also, Andi presently has several MSR patches queued (most prominently
but I'm not including them in -mm due to rejects.  If I get a properly
changlogged and commented version of this patch I can merge it, but it
might get wrecked again when the x86_64 tree gets sorted out.

  reply	other threads:[~2007-03-25 22:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-25 12:18 Jean Delvare
2007-03-25 22:22 ` Andrew Morton [this message]
2007-03-26 11:29   ` Jean Delvare
2007-03-26 11:55     ` Andrew Morton
2007-03-26 11:57 Mikael Pettersson
2007-03-26 12:09 ` Jean Delvare
2007-03-28 21:04   ` Rudolf Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 1/2] MSR: Add support for safe variants' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).