LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] INPUT: Delete unused source file drivers/input/power.c.
@ 2007-03-25 20:28 Robert P. J. Day
  2007-03-25 22:39 ` Andrew Morton
  0 siblings, 1 reply; 4+ messages in thread
From: Robert P. J. Day @ 2007-03-25 20:28 UTC (permalink / raw)
  To: Linux Kernel Mailing List; +Cc: Andrew Morton


Delete the never-compiled source file drivers/input/power.c, and
remove its entry from the corresponding Makefile, as there is no
Kconfig file that refers to the config option INPUT_POWER.

Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

---

diff --git a/drivers/input/Makefile b/drivers/input/Makefile
index da575de..b4cd106 100644
--- a/drivers/input/Makefile
+++ b/drivers/input/Makefile
@@ -13,7 +13,6 @@ obj-$(CONFIG_INPUT_MOUSEDEV)	+= mousedev.o
 obj-$(CONFIG_INPUT_JOYDEV)	+= joydev.o
 obj-$(CONFIG_INPUT_EVDEV)	+= evdev.o
 obj-$(CONFIG_INPUT_TSDEV)	+= tsdev.o
-obj-$(CONFIG_INPUT_POWER)	+= power.o
 obj-$(CONFIG_INPUT_EVBUG)	+= evbug.o

 obj-$(CONFIG_INPUT_KEYBOARD)	+= keyboard/
diff --git a/drivers/input/power.c b/drivers/input/power.c
deleted file mode 100644
index ee82464..0000000
--- a/drivers/input/power.c
+++ /dev/null
@@ -1,166 +0,0 @@
-/*
- * $Id: power.c,v 1.10 2001/09/25 09:17:15 vojtech Exp $
- *
- *  Copyright (c) 2001 "Crazy" James Simmons
- *
- *  Input driver Power Management.
- *
- *  Sponsored by Transvirtual Technology.
- */
-
-/*
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
- *
- * Should you need to contact me, the author, you can do so by
- * e-mail - mail your message to <jsimmons@transvirtual.com>.
- */
-
-#include <linux/module.h>
-#include <linux/input.h>
-#include <linux/slab.h>
-#include <linux/init.h>
-#include <linux/tty.h>
-#include <linux/delay.h>
-#include <linux/pm.h>
-
-static struct input_handler power_handler;
-
-/*
- * Power management can't be done in a interrupt context. So we have to
- * use keventd.
- */
-static int suspend_button_pushed = 0;
-static void suspend_button_task_handler(void *data)
-{
-        udelay(200); /* debounce */
-        suspend_button_pushed = 0;
-}
-
-static DECLARE_WORK(suspend_button_task, suspend_button_task_handler, NULL);
-
-static void power_event(struct input_handle *handle, unsigned int type,
-		        unsigned int code, int down)
-{
-	struct input_dev *dev = handle->dev;
-
-	printk("Entering power_event\n");
-
-	if (type == EV_PWR) {
-		switch (code) {
-			case KEY_SUSPEND:
-				printk("Powering down entire device\n");
-
-				if (!suspend_button_pushed) {
-                			suspend_button_pushed = 1;
-                        		schedule_work(&suspend_button_task);
-                		}
-				break;
-			case KEY_POWER:
-				/* Hum power down the machine. */
-				break;
-			default:
-				return;
-		}
-	}
-
-	if (type == EV_KEY) {
-		switch (code) {
-			case KEY_SUSPEND:
-				printk("Powering down input device\n");
-				/* This is risky. See pm.h for details. */
-				if (dev->state != PM_RESUME)
-					dev->state = PM_RESUME;
-				else
-					dev->state = PM_SUSPEND;
-				pm_send(dev->pm_dev, dev->state, dev);
-				break;
-			case KEY_POWER:
-				/* Turn the input device off completely ? */
-				break;
-			default:
-				return;
-		}
-	}
-	return;
-}
-
-static struct input_handle *power_connect(struct input_handler *handler,
-					  struct input_dev *dev,
-					  const struct input_device_id *id)
-{
-	struct input_handle *handle;
-
-	if (!(handle = kzalloc(sizeof(struct input_handle), GFP_KERNEL)))
-		return NULL;
-
-	handle->dev = dev;
-	handle->handler = handler;
-
-	input_open_device(handle);
-
-	printk(KERN_INFO "power.c: Adding power management to input layer\n");
-	return handle;
-}
-
-static void power_disconnect(struct input_handle *handle)
-{
-	input_close_device(handle);
-	kfree(handle);
-}
-
-static const struct input_device_id power_ids[] = {
-	{
-		.flags = INPUT_DEVICE_ID_MATCH_EVBIT | INPUT_DEVICE_ID_MATCH_KEYBIT,
-		.evbit = { BIT(EV_KEY) },
-		.keybit = { [LONG(KEY_SUSPEND)] = BIT(KEY_SUSPEND) }
-	},
-	{
-		.flags = INPUT_DEVICE_ID_MATCH_EVBIT | INPUT_DEVICE_ID_MATCH_KEYBIT,
-		.evbit = { BIT(EV_KEY) },
-		.keybit = { [LONG(KEY_POWER)] = BIT(KEY_POWER) }
-	},
-	{
-		.flags = INPUT_DEVICE_ID_MATCH_EVBIT,
-		.evbit = { BIT(EV_PWR) },
-	},
-	{ }, 	/* Terminating entry */
-};
-
-MODULE_DEVICE_TABLE(input, power_ids);
-
-static struct input_handler power_handler = {
-	.event =	power_event,
-	.connect =	power_connect,
-	.disconnect =	power_disconnect,
-	.name =		"power",
-	.id_table =	power_ids,
-};
-
-static int __init power_init(void)
-{
-	return input_register_handler(&power_handler);
-}
-
-static void __exit power_exit(void)
-{
-	input_unregister_handler(&power_handler);
-}
-
-module_init(power_init);
-module_exit(power_exit);
-
-MODULE_AUTHOR("James Simmons <jsimmons@transvirtual.com>");
-MODULE_DESCRIPTION("Input Power Management driver");
-MODULE_LICENSE("GPL");
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] INPUT: Delete unused source file drivers/input/power.c.
  2007-03-25 20:28 [PATCH] INPUT: Delete unused source file drivers/input/power.c Robert P. J. Day
@ 2007-03-25 22:39 ` Andrew Morton
  2007-03-26  0:22   ` Dmitry Torokhov
  2007-03-26  8:05   ` Robert P. J. Day
  0 siblings, 2 replies; 4+ messages in thread
From: Andrew Morton @ 2007-03-25 22:39 UTC (permalink / raw)
  To: Robert P. J. Day; +Cc: Linux Kernel Mailing List, Dmitry Torokhov

On Sun, 25 Mar 2007 16:28:39 -0400 (EDT) "Robert P. J. Day" <rpjday@mindspring.com> wrote:

> Delete the never-compiled source file drivers/input/power.c, and
> remove its entry from the corresponding Makefile, as there is no
> Kconfig file that refers to the config option INPUT_POWER.

Please cc the maintainer when he's this easy to find ;)

There are significant-looking patches against input.c in the git-input
tree - if it's presently dead I suspect that it'll be coming back to
life soon.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] INPUT: Delete unused source file drivers/input/power.c.
  2007-03-25 22:39 ` Andrew Morton
@ 2007-03-26  0:22   ` Dmitry Torokhov
  2007-03-26  8:05   ` Robert P. J. Day
  1 sibling, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2007-03-26  0:22 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Robert P. J. Day, Linux Kernel Mailing List

On Sunday 25 March 2007 18:39, Andrew Morton wrote:
> On Sun, 25 Mar 2007 16:28:39 -0400 (EDT) "Robert P. J. Day" <rpjday@mindspring.com> wrote:
> 
> > Delete the never-compiled source file drivers/input/power.c, and
> > remove its entry from the corresponding Makefile, as there is no
> > Kconfig file that refers to the config option INPUT_POWER.
> 
> Please cc the maintainer when he's this easy to find ;)
> 
> There are significant-looking patches against input.c in the git-input
> tree - if it's presently dead I suspect that it'll be coming back to
> life soon.
> 

Actually it is just me being anal and trying to keep even dead modules
compilable... I think it is time for power.c to go. Now that we have ACPI
using input layer to report buttons/lid I don't see it coming back.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] INPUT: Delete unused source file drivers/input/power.c.
  2007-03-25 22:39 ` Andrew Morton
  2007-03-26  0:22   ` Dmitry Torokhov
@ 2007-03-26  8:05   ` Robert P. J. Day
  1 sibling, 0 replies; 4+ messages in thread
From: Robert P. J. Day @ 2007-03-26  8:05 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Linux Kernel Mailing List, Dmitry Torokhov

On Sun, 25 Mar 2007, Andrew Morton wrote:

> On Sun, 25 Mar 2007 16:28:39 -0400 (EDT) "Robert P. J. Day" <rpjday@mindspring.com> wrote:
>
> > Delete the never-compiled source file drivers/input/power.c, and
> > remove its entry from the corresponding Makefile, as there is no
> > Kconfig file that refers to the config option INPUT_POWER.
>
> Please cc the maintainer when he's this easy to find ;)

ah, my bad, sorry.

> There are significant-looking patches against input.c in the
> git-input tree - if it's presently dead I suspect that it'll be
> coming back to life soon.

ok, i was just going by the total lack of reference and date of 2001
in the source file.

rday
-- 
========================================================================
Robert P. J. Day Linux Consulting, Training and Annoying Kernel
Pedantry Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-03-26  8:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-03-25 20:28 [PATCH] INPUT: Delete unused source file drivers/input/power.c Robert P. J. Day
2007-03-25 22:39 ` Andrew Morton
2007-03-26  0:22   ` Dmitry Torokhov
2007-03-26  8:05   ` Robert P. J. Day

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).