LKML Archive on
help / color / mirror / Atom feed
From: Mikael Pettersson <>
Subject: Re: [PATCH 1/2] MSR: Add support for safe variants
Date: Mon, 26 Mar 2007 13:57:29 +0200 (MEST)	[thread overview]
Message-ID: <> (raw)

On Mon, 26 Mar 2007 13:29:37 +0200, Jean Delvare wrote:
> * * * * * Updated patch * * * * *
> From: Rudolf Marek <>
> Add safe (exception handled) variants of rdmsr_on_cpu and wrmsr_on_cpu.
> You should use these when the target MSR may not actually exist, as
> doing so could trigger an exception which the regular functions do not
> handle. The safe variants are slower, though.
> The upcoming coretemp hardware monitoring driver will need this.

Maybe I'm in the minority here, but I for one strongly believe
that any attempt to access an MSR "which might not be there" is
inherently wrong. It implies that your HW detection is incomplete,
which in combination with MSR accesses means that you may end up
accessing MSRs that aren't at all what you think they should be.

Who supplies these imprecise MSR definitions anyway?
Intel manuals? ACPI?


             reply	other threads:[~2007-03-26 11:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-26 11:57 Mikael Pettersson [this message]
2007-03-26 12:09 ` Jean Delvare
2007-03-28 21:04   ` Rudolf Marek
  -- strict thread matches above, loose matches on Subject: below --
2007-03-25 12:18 Jean Delvare
2007-03-25 22:22 ` Andrew Morton
2007-03-26 11:29   ` Jean Delvare
2007-03-26 11:55     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 1/2] MSR: Add support for safe variants' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).