LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Miklos Szeredi <miklos@szeredi.hu>, linux-kernel@vger.kernel.org
Subject: Re: [patch] add file position info to proc
Date: Tue, 27 Mar 2007 14:36:29 -0700	[thread overview]
Message-ID: <20070327143629.9c8953db.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070327212419.GA5817@ucw.cz>

On Tue, 27 Mar 2007 21:24:20 +0000
Pavel Machek <pavel@ucw.cz> wrote:

> Hi!
> 
> > From: Miklos Szeredi <mszeredi@suse.cz>
> > 
> > This patch adds support for finding out the current file position,
> > open flags and possibly other info in the future.
> > 
> > These new entries are added:
> > 
> >   /proc/PID/fdinfo/FD
> >   /proc/PID/task/TID/fdinfo/FD
> > 
> > For each fd the information is provided in the following format:
> > 
> > pos:	1234
> > flags:	0100002
> 
> Octal? Maybe we should use more traditional hex here?

Good point.  The O_foo flags are per-arch, so this field has the potential
to be subtly different on different architectures, which is unpleasing.

> Or even list flags by name?

urg.  Simple enough to do (lookup table, please).  But is it worth it? 
Perhaps just remove that field?

  parent reply	other threads:[~2007-03-27 21:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-24 22:04 Miklos Szeredi
2007-03-25 23:45 ` Andrew Morton
2007-03-26  0:05   ` Neil Brown
2007-03-26  9:41   ` Folkert van Heusden
2007-03-27 21:55   ` Dave Hansen
2007-03-27  0:45 ` Andrew Morton
2007-03-27  7:08   ` Miklos Szeredi
2007-03-27  7:35     ` Andrew Morton
2007-03-27 21:24 ` Pavel Machek
2007-03-27 21:33   ` Jörn Engel
2007-03-27 21:36   ` Andrew Morton [this message]
2007-03-27 21:43     ` Miklos Szeredi
2007-03-27 22:33       ` Pavel Machek
2007-03-27 23:05         ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070327143629.9c8953db.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=pavel@ucw.cz \
    --subject='Re: [patch] add file position info to proc' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).