LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: "Jan Beulich" <jbeulich@novell.com>
Cc: <sam@ravnborg.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix dependency generation
Date: Thu, 29 Mar 2007 09:38:38 -0700	[thread overview]
Message-ID: <20070329093838.d5b2d88a.randy.dunlap@oracle.com> (raw)
In-Reply-To: <460C0020.76E4.0078.0@novell.com>

On Thu, 29 Mar 2007 17:06:24 +0100 Jan Beulich wrote:

> >>> Randy Dunlap <randy.dunlap@oracle.com> 29.03.07 17:39 >>>
> >> --- linux-2.6.21-rc5/scripts/basic/fixdep.c	2007-02-04 19:44:54.000000000 +0100
> >> +++ 2.6.21-rc5-fixdep-mod/scripts/basic/fixdep.c	2007-03-29 11:11:10.000000000 +0200
> >> @@ -29,8 +29,7 @@
> >>   * option which is mentioned in any of the listed prequisites.
> >>   *
> >>   * To be exact, split-include populates a tree in include/config/,
> >> - * e.g. include/config/his/driver.h, which contains the #define/#undef
> >> - * for the CONFIG_HIS_DRIVER option.
> >
> >I don't see why you deleted the line above.
> 
> Because it is no longer true. These files are empty as of 2.6.18.

We seem to be talking about different lines above.  Yes, the files
are empty, but they are named based on the CONFIG_symbol name, which
is what I was trying to get at.  So how about a comment like this:

 * To be exact, split-include populates a tree in include/config/,
 * e.g., include/config/sysctl/syscall.h,
 * for the CONFIG_SYSCTL_SYSCALL option, when that option
 * is enabled (=y or =m).


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  reply	other threads:[~2007-03-29 16:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-29  9:27 Jan Beulich
2007-03-29 15:39 ` Randy Dunlap
2007-03-29 16:06   ` Jan Beulich
2007-03-29 16:38     ` Randy Dunlap [this message]
2007-03-30  9:14       ` Jan Beulich
2007-03-30 15:17         ` Randy Dunlap
2007-03-30 15:08 ` Sam Ravnborg
2007-03-30 15:43   ` Jan Beulich
2007-03-30 17:14     ` Jeff Dike
2007-03-31  6:42 ` Sam Ravnborg
2007-03-31  7:39   ` [PATCH 1/2] kconfig: factor out code in conf_spilt_config Sam Ravnborg
2007-03-31  7:40   ` [PATCH 2/2] kconfig/kbuild: fix dependency problem Sam Ravnborg
2007-03-31 16:11   ` [PATCH] fix dependency generation Roman Zippel
2007-04-01 18:45     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070329093838.d5b2d88a.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --subject='Re: [PATCH] fix dependency generation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).