LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* 2.6.21-rc5-mm2
@ 2007-03-27  5:16 Andrew Morton
  2007-03-27 10:04 ` 2.6.21-rc5-mm2 William Lee Irwin III
                   ` (6 more replies)
  0 siblings, 7 replies; 29+ messages in thread
From: Andrew Morton @ 2007-03-27  5:16 UTC (permalink / raw)
  To: linux-kernel


ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc5/2.6.21-rc5-mm2/


- This is the same as 2.6.12-rc5-mm1, except the staircase deadline CPU
  scheduler has been added.


Boilerplate:

- See the `hot-fixes' directory for any important updates to this patchset.

- To fetch an -mm tree using git, use (for example)

  git-fetch git://git.kernel.org/pub/scm/linux/kernel/git/smurf/linux-trees.git tag v2.6.16-rc2-mm1
  git-checkout -b local-v2.6.16-rc2-mm1 v2.6.16-rc2-mm1

- -mm kernel commit activity can be reviewed by subscribing to the
  mm-commits mailing list.

        echo "subscribe mm-commits" | mail majordomo@vger.kernel.org

- If you hit a bug in -mm and it is not obvious which patch caused it, it is
  most valuable if you can perform a bisection search to identify which patch
  introduced the bug.  Instructions for this process are at

        http://www.zip.com.au/~akpm/linux/patches/stuff/bisecting-mm-trees.txt

  But beware that this process takes some time (around ten rebuilds and
  reboots), so consider reporting the bug first and if we cannot immediately
  identify the faulty patch, then perform the bisection search.

- When reporting bugs, please try to Cc: the relevant maintainer and mailing
  list on any email.

- When reporting bugs in this kernel via email, please also rewrite the
  email Subject: in some manner to reflect the nature of the bug.  Some
  developers filter by Subject: when looking for messages to read.

- Occasional snapshots of the -mm lineup are uploaded to
  ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/ and are announced on
  the mm-commits list.



Changes since 2.6.21-rc5-mm1:

+sched-dont-renice-kernel-threads.patch
+sched-remove-sleepavg-from-proc.patch
+sched-implement-staircase-deadline-cpu-scheduler.patch
+sched-remove-noninteractive-flag.patch
+sched-document-sd-cpu-scheduler.patch

 scheduler-of-the-day.


All 1082 patches:

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc5/2.6.21-rc5-mm2/patch-series


^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: 2.6.21-rc5-mm2
  2007-03-27  5:16 2.6.21-rc5-mm2 Andrew Morton
@ 2007-03-27 10:04 ` William Lee Irwin III
  2007-03-28 17:02 ` 2.6.21-rc5-mm2 Andreas Mohr
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 29+ messages in thread
From: William Lee Irwin III @ 2007-03-27 10:04 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel

On Mon, Mar 26, 2007 at 09:16:27PM -0800, Andrew Morton wrote:
> - This is the same as 2.6.12-rc5-mm1, except the staircase deadline CPU
>   scheduler has been added.

This boots without incident on the Altix I've got where prior versions
of RSDL all had issues. Count RSDL as fixed here.


-- wli

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: 2.6.21-rc5-mm2
  2007-03-27  5:16 2.6.21-rc5-mm2 Andrew Morton
  2007-03-27 10:04 ` 2.6.21-rc5-mm2 William Lee Irwin III
@ 2007-03-28 17:02 ` Andreas Mohr
  2007-03-28 17:33   ` 2.6.21-rc5-mm2 Andreas Mohr
  2007-03-28 17:42 ` 2.6.21-rc5-mm2 Christian
                   ` (4 subsequent siblings)
  6 siblings, 1 reply; 29+ messages in thread
From: Andreas Mohr @ 2007-03-28 17:02 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Con Kolivas, Jan Engelhardt, Greg KH, linux-kernel

Hi,

On Mon, Mar 26, 2007 at 09:16:27PM -0800, Andrew Morton wrote:
> 
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc5/2.6.21-rc5-mm2/
> 
> 
> - This is the same as 2.6.12-rc5-mm1, except the staircase deadline CPU
>   scheduler has been added.

OOPS (hand-pasted), happens on roughly 85% of bootups, didn't seem to
occur during my several previous 2.6.21-rc4-mm1 bootups:

-----
...
Setting up ICE socket directory /tmp/.ICE-unix...done.
BUG: unable to handle kernel NULL pointer dereference at virtual address 00000024
!!!!! ======> last sysfs file: block/loop7/removable <=======
Process init
trace:
show_trace_log_lvl+0x1a
show_stack_log_lvl+0x9d
show_registers+0x1c0
die+0xe5
do_page_fault+0x432
error_code+0x71
sysfs_drop_dentry+0x30
sysfs_hash_and_remove+0x8e
sysfs_remove_file+0xd
device_remove_file+0x1c
device_del+0x1ed
device_unregister+0x26
device_destroy+0x8a
vcs_remove_sysfs+0x1a
con_close+0x4c
release_dev+0x1f0
tty_release+0xa
__fput+0xb8
fput+0x31
filp_close+0x54
put_files_struct+0x7c
do_exit+0x1e3
sys_exit_group+0x0
sys_exit_group+0xf
syscall_call+0x7
EIP: __iget+0x6
Fixing recursive fault but reboot is needed!
-----

Any hints? Possibly existing bug surfaced due to RSDL scheduling timing
differences? I did NOT test -mm1 to check this.

P3/700 UP i815 IDE ext3, Debian unstable.

Further .config available on request.

Note that something killed my /bin/run-parts (Debian) and S10portmap files
(and possibly some others are corrupted??), so it might be something fishy
(but this fishiness could also have uncovered this OOPS, so...).
Restoring those files didn't change the status quo.

CC'd relevant maintainers/recent submitters.

Andreas Mohr

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: 2.6.21-rc5-mm2
  2007-03-28 17:02 ` 2.6.21-rc5-mm2 Andreas Mohr
@ 2007-03-28 17:33   ` Andreas Mohr
  2007-03-28 17:45     ` 2.6.21-rc5-mm2 Andreas Mohr
  0 siblings, 1 reply; 29+ messages in thread
From: Andreas Mohr @ 2007-03-28 17:33 UTC (permalink / raw)
  To: Andreas Mohr
  Cc: Andrew Morton, Con Kolivas, Jan Engelhardt, Greg KH, linux-kernel

Hi,

On Wed, Mar 28, 2007 at 07:02:14PM +0200, Andreas Mohr wrote:
> Hi,
> 
> On Mon, Mar 26, 2007 at 09:16:27PM -0800, Andrew Morton wrote:
> > 
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc5/2.6.21-rc5-mm2/
> > 
> > 
> > - This is the same as 2.6.12-rc5-mm1, except the staircase deadline CPU
> >   scheduler has been added.
> 
> OOPS (hand-pasted), happens on roughly 85% of bootups, didn't seem to
> occur during my several previous 2.6.21-rc4-mm1 bootups:

Still happens after having added just-published RSDL fixup patch and
reinstalled resulting kernel package.

.config diff between -rc4-mm1 and -rc5-mm1 is negligible.
Interesting items in current .config:
CONFIG_SWAP_PREFETCH=y
CONFIG_SYSFS_DEPRECATED=y
CONFIG_RT_MUTEXES=y
CONFIG_TICK_ONESHOT=y
CONFIG_HIGH_RES_TIMERS=y
CONFIG_PREEMPT_VOLUNTARY=y
CONFIG_X86_UP_APIC=y
CONFIG_X86_UP_IOAPIC=y
CONFIG_X86_LOCAL_APIC=y
CONFIG_X86_IO_APIC=y
CONFIG_ADAPTIVE_READAHEAD=y
CONFIG_HZ=250
CONFIG_X86_PM_TIMER=y
# CONFIG_CPU_IDLE is not set
CONFIG_PNP=y
CONFIG_PNPACPI=y
CONFIG_BLK_DEV_LOOP=m
CONFIG_BLK_DEV_CRYPTOLOOP=m
CONFIG_BLK_DEV_IDEACPI=y
CONFIG_RTC=y

Thanks,

Andreas Mohr

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: 2.6.21-rc5-mm2
  2007-03-27  5:16 2.6.21-rc5-mm2 Andrew Morton
  2007-03-27 10:04 ` 2.6.21-rc5-mm2 William Lee Irwin III
  2007-03-28 17:02 ` 2.6.21-rc5-mm2 Andreas Mohr
@ 2007-03-28 17:42 ` Christian
  2007-03-28 17:55   ` 2.6.21-rc5-mm2 Pallipadi, Venkatesh
  2007-03-28 18:36 ` 2.6.21-rc5-mm2 Badari Pulavarty
                   ` (3 subsequent siblings)
  6 siblings, 1 reply; 29+ messages in thread
From: Christian @ 2007-03-28 17:42 UTC (permalink / raw)
  To: linux-kernel

Hello lkml!

I have a problem with the new cpuidle infrastructure. My system locks up hard 
on bootup with the message ACPI cpuidle could not initialize cpu0 and cpu1. 
When I deselect cpuidle in the kernel config everything works fine again.
My system is AMD64 X2 with NForce4 chipset.

-Christian

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: 2.6.21-rc5-mm2
  2007-03-28 17:33   ` 2.6.21-rc5-mm2 Andreas Mohr
@ 2007-03-28 17:45     ` Andreas Mohr
  2007-03-28 18:04       ` tty OOPS (Re: 2.6.21-rc5-mm2) Andreas Mohr
  0 siblings, 1 reply; 29+ messages in thread
From: Andreas Mohr @ 2007-03-28 17:45 UTC (permalink / raw)
  To: Andreas Mohr
  Cc: Andrew Morton, Con Kolivas, Jan Engelhardt, Greg KH, linux-kernel

Hi,

just wanted to add that when analyzing the backtrace I found the comment
at drivers/char/vt.c/con_close() to be VERY suspicious...
(need to take tty_mutex to prevent concurrent thread tty access).
This might just be what happened here despite trying to protect against it.

Andreas Mohr

^ permalink raw reply	[flat|nested] 29+ messages in thread

* RE: 2.6.21-rc5-mm2
  2007-03-28 17:42 ` 2.6.21-rc5-mm2 Christian
@ 2007-03-28 17:55   ` Pallipadi, Venkatesh
  0 siblings, 0 replies; 29+ messages in thread
From: Pallipadi, Venkatesh @ 2007-03-28 17:55 UTC (permalink / raw)
  To: Christian, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 907 bytes --]


 
Patch attached here should fix the issue.

Thanks,
Venki


>-----Original Message-----
>From: linux-kernel-owner@vger.kernel.org 
>[mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of Christian
>Sent: Wednesday, March 28, 2007 10:42 AM
>To: linux-kernel@vger.kernel.org
>Subject: Re: 2.6.21-rc5-mm2
>
>Hello lkml!
>
>I have a problem with the new cpuidle infrastructure. My 
>system locks up hard 
>on bootup with the message ACPI cpuidle could not initialize 
>cpu0 and cpu1. 
>When I deselect cpuidle in the kernel config everything works 
>fine again.
>My system is AMD64 X2 with NForce4 chipset.
>
>-Christian
>-
>To unsubscribe from this list: send the line "unsubscribe 
>linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/
>

[-- Attachment #2: Type: message/rfc822, Size: 4254 bytes --]

From: <akpm@linux-foundation.org>
To: <lenb@kernel.org>
Cc: <linux-acpi@vger.kernel.org>, <akpm@linux-foundation.org>, "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>, <larry.finger@lwfinger.net>
Subject: [patch 1/4] cuidle: fix boot hang
Date: Mon, 26 Mar 2007 22:38:46 -0700
Message-ID: <200703270538.l2R5ckE5007930@shell0.pdx.osdl.net>

From: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>

Patch for cpuidle boot hang reported by Larry Finger here.
http://www.ussg.iu.edu/hypermail/linux/kernel/0703.2/2025.html

Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Len Brown <lenb@kernel.org>
Cc: Larry Finger <larry.finger@lwfinger.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/cpuidle/cpuidle.c |   26 +++++++++++++++++++-------
 drivers/cpuidle/driver.c  |    4 ++--
 2 files changed, 21 insertions(+), 9 deletions(-)

diff -puN drivers/cpuidle/cpuidle.c~cpuidle-fix-boot-hang drivers/cpuidle/cpuidle.c
--- a/drivers/cpuidle/cpuidle.c~cpuidle-fix-boot-hang
+++ a/drivers/cpuidle/cpuidle.c
@@ -119,6 +119,7 @@ static int cpuidle_add_device(struct sys
 
 	dev = &per_cpu(cpuidle_devices, cpu);
 
+	dev->cpu = cpu;
 	mutex_lock(&cpuidle_lock);
 	if (cpu_is_offline(cpu)) {
 		mutex_unlock(&cpuidle_lock);
@@ -129,15 +130,26 @@ static int cpuidle_add_device(struct sys
 		mutex_unlock(&cpuidle_lock);
 		return 0;
 	}
-	dev->status |= CPUIDLE_STATUS_DETECTED;
-	list_add(&dev->device_list, &cpuidle_detected_devices);
-	cpuidle_add_sysfs(sys_dev);
-	if (cpuidle_curr_driver)
-		cpuidle_attach_driver(dev);
-	if (cpuidle_curr_governor)
-		cpuidle_attach_governor(dev);
+	if (cpuidle_curr_driver) {
+		if (cpuidle_attach_driver(dev))
+			goto err_ret;
+	}
+
+	if (cpuidle_curr_governor) {
+		if (cpuidle_attach_governor(dev)) {
+			cpuidle_detach_driver(dev);
+			goto err_ret;
+		}
+	}
+
 	if (cpuidle_device_can_idle(dev))
 		cpuidle_install_idle_handler();
+
+	list_add(&dev->device_list, &cpuidle_detected_devices);
+	cpuidle_add_sysfs(sys_dev);
+	dev->status |= CPUIDLE_STATUS_DETECTED;
+
+err_ret:
 	mutex_unlock(&cpuidle_lock);
 
 	return 0;
diff -puN drivers/cpuidle/driver.c~cpuidle-fix-boot-hang drivers/cpuidle/driver.c
--- a/drivers/cpuidle/driver.c~cpuidle-fix-boot-hang
+++ a/drivers/cpuidle/driver.c
@@ -37,8 +37,8 @@ int cpuidle_attach_driver(struct cpuidle
 	ret = cpuidle_curr_driver->init(dev);
 	if (ret) {
 		module_put(cpuidle_curr_driver->owner);
-		printk(KERN_ERR "cpuidle: driver %s failed to attach to cpu %d\n",
-			cpuidle_curr_driver->name, dev->cpu);
+		printk(KERN_INFO "cpuidle: driver %s failed to attach to "
+			"cpu %d\n", cpuidle_curr_driver->name, dev->cpu);
 	} else {
 		if (dev->status & CPUIDLE_STATUS_GOVERNOR_ATTACHED)
 			cpuidle_rescan_device(dev);
_

^ permalink raw reply	[flat|nested] 29+ messages in thread

* tty OOPS (Re: 2.6.21-rc5-mm2)
  2007-03-28 17:45     ` 2.6.21-rc5-mm2 Andreas Mohr
@ 2007-03-28 18:04       ` Andreas Mohr
  2007-03-28 18:38         ` Alexey Dobriyan
  0 siblings, 1 reply; 29+ messages in thread
From: Andreas Mohr @ 2007-03-28 18:04 UTC (permalink / raw)
  To: Andreas Mohr; +Cc: Andrew Morton, Alexey Dobriyan, Greg KH, linux-kernel

Hi,

[unrelated maintainers removed, Alexey added]

On Wed, Mar 28, 2007 at 07:45:24PM +0200, Andreas Mohr wrote:
> Hi,
> 
> just wanted to add that when analyzing the backtrace I found the comment
> at drivers/char/vt.c/con_close() to be VERY suspicious...
> (need to take tty_mutex to prevent concurrent thread tty access).
> This might just be what happened here despite trying to protect against it.

OK, can we assume that one of

+protect-tty-drivers-list-with-tty_mutex.patch
+tty-minor-merge-correction.patch
+tty-in-tiocsctty-when-we-steal-a-tty-hang-it-up-fix.patch

is responsible / not implemented fully?

Andreas Mohr

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: 2.6.21-rc5-mm2
  2007-03-27  5:16 2.6.21-rc5-mm2 Andrew Morton
                   ` (2 preceding siblings ...)
  2007-03-28 17:42 ` 2.6.21-rc5-mm2 Christian
@ 2007-03-28 18:36 ` Badari Pulavarty
  2007-03-28 20:20 ` 2.6.21-rc5-mm2 OOPS and spinlock lockup Zan Lynx
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 29+ messages in thread
From: Badari Pulavarty @ 2007-03-28 18:36 UTC (permalink / raw)
  To: Andrew Morton; +Cc: lkml

On Mon, 2007-03-26 at 21:16 -0800, Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc5/2.6.21-rc5-mm2/
> 
> 
> - This is the same as 2.6.12-rc5-mm1, except the staircase deadline CPU
>   scheduler has been added.

Booted fine on my x86-64 and ppc64 machines.
Both failed to boot 2.6.21-rc4-mm1.

Thanks,
Badari


^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: tty OOPS (Re: 2.6.21-rc5-mm2)
  2007-03-28 18:04       ` tty OOPS (Re: 2.6.21-rc5-mm2) Andreas Mohr
@ 2007-03-28 18:38         ` Alexey Dobriyan
  2007-03-28 18:56           ` Alexey Dobriyan
  0 siblings, 1 reply; 29+ messages in thread
From: Alexey Dobriyan @ 2007-03-28 18:38 UTC (permalink / raw)
  To: Andreas Mohr; +Cc: Andrew Morton, Greg KH, linux-kernel

On Wed, Mar 28, 2007 at 08:04:46PM +0200, Andreas Mohr wrote:
> [unrelated maintainers removed, Alexey added]
>
> On Wed, Mar 28, 2007 at 07:45:24PM +0200, Andreas Mohr wrote:
> > Hi,
> >
> > just wanted to add that when analyzing the backtrace I found the comment
> > at drivers/char/vt.c/con_close() to be VERY suspicious...
> > (need to take tty_mutex to prevent concurrent thread tty access).
> > This might just be what happened here despite trying to protect against it.
>
> OK, can we assume that one of
>
> +protect-tty-drivers-list-with-tty_mutex.patch
> +tty-minor-merge-correction.patch
> +tty-in-tiocsctty-when-we-steal-a-tty-hang-it-up-fix.patch
>
> is responsible / not implemented fully?

#2 is just comment removal.

I may state the obvious, but __iget() in sysfs_drop_dentry() gets NULL
inode and you aren't failing on spin_lock one line above because of UP
without spinlock debugging.


^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: tty OOPS (Re: 2.6.21-rc5-mm2)
  2007-03-28 18:38         ` Alexey Dobriyan
@ 2007-03-28 18:56           ` Alexey Dobriyan
  2007-03-28 20:07             ` Andrew Morton
  2007-03-28 20:15             ` [FIXED] " Andreas Mohr
  0 siblings, 2 replies; 29+ messages in thread
From: Alexey Dobriyan @ 2007-03-28 18:56 UTC (permalink / raw)
  To: Andreas Mohr; +Cc: Andrew Morton, Greg KH, linux-kernel

On Wed, Mar 28, 2007 at 10:38:14PM +0400, Alexey Dobriyan wrote:
> On Wed, Mar 28, 2007 at 08:04:46PM +0200, Andreas Mohr wrote:
> > [unrelated maintainers removed, Alexey added]
> >
> > On Wed, Mar 28, 2007 at 07:45:24PM +0200, Andreas Mohr wrote:
> > > Hi,
> > >
> > > just wanted to add that when analyzing the backtrace I found the comment
> > > at drivers/char/vt.c/con_close() to be VERY suspicious...
> > > (need to take tty_mutex to prevent concurrent thread tty access).
> > > This might just be what happened here despite trying to protect against it.
> >
> > OK, can we assume that one of
> >
> > +protect-tty-drivers-list-with-tty_mutex.patch
> > +tty-minor-merge-correction.patch
> > +tty-in-tiocsctty-when-we-steal-a-tty-hang-it-up-fix.patch
> >
> > is responsible / not implemented fully?
>
> #2 is just comment removal.
>
> I may state the obvious, but __iget() in sysfs_drop_dentry() gets NULL
> inode and you aren't failing on spin_lock one line above because of UP
> without spinlock debugging.

The only suspicious new patch in -rc5-mm1 to me is
fix-sysfs-reclaim-crash.patch which removes "sd->s_dentry = NULL;". Note
that whole sysfs_drop_dentry() is NOP if ->s_dentry is NULL.

Could you try to revert it?

	Alexey, who knows very little about sysfs internals


^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: tty OOPS (Re: 2.6.21-rc5-mm2)
  2007-03-28 18:56           ` Alexey Dobriyan
@ 2007-03-28 20:07             ` Andrew Morton
  2007-03-29 12:48               ` Maneesh Soni
  2007-03-28 20:15             ` [FIXED] " Andreas Mohr
  1 sibling, 1 reply; 29+ messages in thread
From: Andrew Morton @ 2007-03-28 20:07 UTC (permalink / raw)
  To: Alexey Dobriyan
  Cc: Andreas Mohr, Greg KH, linux-kernel, Maneesh Soni, Dipankar Sarma

On Wed, 28 Mar 2007 22:56:32 +0400
Alexey Dobriyan <adobriyan@gmail.com> wrote:

> On Wed, Mar 28, 2007 at 10:38:14PM +0400, Alexey Dobriyan wrote:
> > On Wed, Mar 28, 2007 at 08:04:46PM +0200, Andreas Mohr wrote:
> > > [unrelated maintainers removed, Alexey added]
> > >
> > > On Wed, Mar 28, 2007 at 07:45:24PM +0200, Andreas Mohr wrote:
> > > > Hi,
> > > >
> > > > just wanted to add that when analyzing the backtrace I found the comment
> > > > at drivers/char/vt.c/con_close() to be VERY suspicious...
> > > > (need to take tty_mutex to prevent concurrent thread tty access).
> > > > This might just be what happened here despite trying to protect against it.
> > >
> > > OK, can we assume that one of
> > >
> > > +protect-tty-drivers-list-with-tty_mutex.patch
> > > +tty-minor-merge-correction.patch
> > > +tty-in-tiocsctty-when-we-steal-a-tty-hang-it-up-fix.patch
> > >
> > > is responsible / not implemented fully?
> >
> > #2 is just comment removal.
> >
> > I may state the obvious, but __iget() in sysfs_drop_dentry() gets NULL
> > inode and you aren't failing on spin_lock one line above because of UP
> > without spinlock debugging.
> 
> The only suspicious new patch in -rc5-mm1 to me is
> fix-sysfs-reclaim-crash.patch which removes "sd->s_dentry = NULL;". Note
> that whole sysfs_drop_dentry() is NOP if ->s_dentry is NULL.
> 
> Could you try to revert it?
> 
> 	Alexey, who knows very little about sysfs internals

cc's added.


Also added is the sad little missive I sent to the USB guys last night,
which is similar-looking:



Begin forwarded message:

Date: Wed, 28 Mar 2007 00:34:45 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: linux-usb-devel@lists.sourceforge.net
Subject: usb/sysfs oops in 2.6.21-rc5-mm1



I think the connector wasn't pushed in terribly well, so there might have
been some contact bounce.


[15813.836000] ipw2200: Firmware error detected.  Restarting.
[17200.268000] hub 2-0:1.0: port 1 disabled by hub (EMI?), re-enabling...
[17200.268000] usb 2-1: USB disconnect, address 4
[17200.268000] BUG: unable to handle kernel NULL pointer dereference at virtual address 00000024
[17200.268000]  printing eip:
[17200.268000] c016e447
[17200.268000] *pde = 00000000
[17200.268000] Oops: 0000 [#1]
[17200.268000] last sysfs file: block/sr0/size
[17200.268000] Modules linked in: udf i915 drm ipw2200 sonypi ipv6 autofs4 hidp l2cap sunrpc nf_conntrack_netbios_ns ipt_REJECT nf_conntrack_ipv4 xt_state nf_conntrack nfnetlink xt_tcpudp iptable_filter ip_tables x_tables cpufreq_ondemand video sbs button battery asus_acpi ac nvram hci_usb bluetooth ieee80211 ohci1394 ieee1394 joydev ieee80211_crypt snd_hda_intel snd_hda_codec ehci_hcd uhci_hcd sg snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device snd_pcm_oss snd_mixer_oss snd_pcm snd_timer snd sr_mod cdrom piix soundcore i2c_i801 snd_page_alloc i2c_core pcspkr generic ext3 jbd ide_disk ide_core
[17200.268000] CPU:    0
[17200.268000] EIP:    0060:[<c016e447>]    Not tainted VLI
[17200.268000] EFLAGS: 00010246   (2.6.21-rc5-mm1 #1)
[17200.268000] EIP is at __iget+0x3/0x48
[17200.268000] eax: 00000000   ebx: 00000000   ecx: 00000000   edx: c8a90514
[17200.268000] esi: c8a90514   edi: 00000000   ebp: c8cea5e4   esp: c210fe5c
[17200.268000] ds: 007b   es: 007b   fs: 00d8  gs: 0000  ss: 0068
[17200.268000] Process khubd (pid: 155, ti=c210e000 task=c209b6f0 task.ti=c210e000)
[17200.268000] Stack: c2493a14 c0192933 c8cea5e8 c0338373 c0338373 c8cea5e4 c0192a90 c889ba24 
[17200.268000]        c033836f c8a90514 c8cea58c c889ba08 c8556a40 df8918c0 c24e6418 c0230d46 
[17200.268000]        c889ba08 c889ba08 c0230dd8 c889ba08 c889ba00 df8918c0 c24e6418 c0230ffa 
[17200.268000] Call Trace:
[17200.268000]  [<c0192933>] sysfs_drop_dentry+0x2b/0xc3
[17200.268000]  [<c0192a90>] sysfs_hash_and_remove+0x86/0x12c
[17200.268000]  [<c0230d46>] device_remove_file+0x19/0x25
[17200.268000]  [<c0230dd8>] device_del+0x26/0x240
[17200.268000]  [<c0230ffa>] device_unregister+0x8/0x10
[17200.268000]  [<c026739a>] usb_remove_ep_files+0x4d/0x60
[17200.268000]  [<c0260031>] usb_new_device+0x199/0x1ab
[17200.268000]  [<c0266d14>] usb_remove_sysfs_intf_files+0x1e/0x43
[17200.268000]  [<c026312d>] usb_disable_device+0x55/0xbb
[17200.268000]  [<c0260415>] usb_disconnect+0x87/0x100
[17200.268000]  [<c0260842>] hub_thread+0x361/0xa70
[17200.268000]  [<c016d394>] d_lookup+0x16/0x31
[17200.268000]  [<c01174df>] __wake_up_common+0x31/0x4f
[17200.268000]  [<c0128754>] autoremove_wake_function+0x0/0x35
[17200.268000]  [<c02604e1>] hub_thread+0x0/0xa70
[17200.268000]  [<c01285f7>] kthread+0xa0/0xc9
[17200.268000]  [<c0128557>] kthread+0x0/0xc9
[17200.268000]  [<c010464f>] kernel_thread_helper+0x7/0x10
[17200.268000]  =======================
[17200.268000] Code: 00 00 00 89 d8 81 ce 00 02 00 00 e8 3e ba 01 00 8b 43 20 31 c9 89 f2 89 04 24 89 d8 e8 19 25 01 00 58 5b 5e c3 90 90 90 53 89 c3 <83> 78 24 00 74 05 ff 40 24 eb 38 ff 40 24 f6 80 2c 01 00 00 0f 
[17200.268000] EIP: [<c016e447>] __iget+0x3/0x48 SS:ESP 0068:c210fe5c
[17327.844000] ipw2200: Firmware error detected.  Restarting.


^ permalink raw reply	[flat|nested] 29+ messages in thread

* [FIXED] Re: tty OOPS (Re: 2.6.21-rc5-mm2)
  2007-03-28 18:56           ` Alexey Dobriyan
  2007-03-28 20:07             ` Andrew Morton
@ 2007-03-28 20:15             ` Andreas Mohr
  2007-03-28 21:08               ` Ethan Solomita
  2007-03-28 21:27               ` Ethan Solomita
  1 sibling, 2 replies; 29+ messages in thread
From: Andreas Mohr @ 2007-03-28 20:15 UTC (permalink / raw)
  To: Alexey Dobriyan
  Cc: Andreas Mohr, Andrew Morton, Maneesh Soni, Ethan Solomita,
	Greg KH, linux-kernel

Hi,

On Wed, Mar 28, 2007 at 10:56:32PM +0400, Alexey Dobriyan wrote:
> The only suspicious new patch in -rc5-mm1 to me is
> fix-sysfs-reclaim-crash.patch which removes "sd->s_dentry = NULL;". Note
> that whole sysfs_drop_dentry() is NOP if ->s_dentry is NULL.
> 
> Could you try to revert it?
> 
> 	Alexey, who knows very little about sysfs internals

Apparently that's still too much knowledge ;)

Or, in other words: 6 reboots already and not a single problem!

So yes, the removal of the NULLing line in this patch most likely
has caused this issue on my box.
Now the question is whether something as simple as that is a fully
correct fix or whether something should be done entirely differently.
I'll let people more familiar with those parts decide about it...

Thanks!

Andreas Mohr

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: 2.6.21-rc5-mm2 OOPS and spinlock lockup
  2007-03-27  5:16 2.6.21-rc5-mm2 Andrew Morton
                   ` (3 preceding siblings ...)
  2007-03-28 18:36 ` 2.6.21-rc5-mm2 Badari Pulavarty
@ 2007-03-28 20:20 ` Zan Lynx
  2007-03-28 20:50   ` Andrew Morton
  2007-03-29 17:53 ` 2.6.21-rc5-mm2 Badari Pulavarty
  2007-03-29 18:20 ` 2.6.21-rc5-mm2 - compile error on x86-64 Helge Hafting
  6 siblings, 1 reply; 29+ messages in thread
From: Zan Lynx @ 2007-03-28 20:20 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 4111 bytes --]

On Mon, 2007-03-26 at 21:16 -0800, Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc5/2.6.21-rc5-mm2/
> 
> 
> - This is the same as 2.6.12-rc5-mm1, except the staircase deadline CPU
>   scheduler has been added.

Here is the last bit of netconsole dump I had from my laptop when the
kernel died just now.

Note that the kernel is compiled with SMP but the laptop is one core
only. I have CONFIG_DEBUG_SPINLOCK=y and CONFIG_DEBUG_SPINLOCK_SLEEP=y

It's AMD-64.

[ 2597.436421] Hangcheck: hangcheck value past margin!
[ 2794.356033] Unable to handle kernel NULL pointer dereference at 00000000000000c0 RIP: 
[ 2794.356058]  [<ffffffff8020761f>] _raw_spin_lock+0x1f/0x140
[ 2794.356088] PGD 9f39067 PUD 9f38067 PMD 0 
[ 2794.356180] Oops: 0000 [1] PREEMPT SMP 
[ 2794.356261] last sysfs file: devices/system/cpu/cpu0/cpufreq/scaling_setspeed
[ 2794.356328] CPU 0 
[ 2794.356341] Modules linked in: netconsole nls_iso8859_1 nls_cp437 vfat fat nls_base zaurus cdc_ether usbnet snd_pcm_oss snd_mixer_oss rfcomm hidp hid l2cap ipv6 hci_usb bluetooth usb_storage snd_intel8x0 psmouse serio_raw snd_ac97_codec ac97_bus snd_pcm snd_timer snd snd_page_alloc ehci_hcd ohci_hcd ssb usbcore evdev sg
[ 2794.357227] Pid: 8049, comm: khidpd_046db3e1 Not tainted 2.6.21-rc5-mm2 #1
[ 2794.357295] RIP: 0010:[<ffffffff8020761f>]  [<ffffffff8020761f>] _raw_spin_lock+0x1f/0x140
[ 2794.357318] RSP: 0000:ffff81000d865d10  EFLAGS: 00010282
[ 2794.357329] RAX: ffff81000d739040 RBX: 00000000000000b8 RCX: 0000000000000000
[ 2794.357396] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 00000000000000b8
[ 2794.357408] RBP: ffff81000e23dd08 R08: 0000000000000002 R09: 0000000000000000
[ 2794.357422] R10: ffffffff80318019 R11: 2222222222222222 R12: ffff81000e23dd10
[ 2794.357435] R13: 0000000000000000 R14: ffff81000e16b928 R15: ffff81000b518720
 [<ffffffff8020761f>] _raw_spin_lock+0x1f/0x140
[ 2794.359149]  RSP <ffff81000d865d10>
[ 2794.359214] CR2: 00000000000000c0
[ 2794.359268] note: khidpd_046db3e1[8049] exited with preempt_count 3
[ 2804.355026] BUG: soft lockup detected on CPU#0!
[ 2804.355037] 
[ 2804.355039] Call Trace:
[ 2804.355051]  <IRQ>  [<ffffffff802c7659>] softlockup_tick+0xf9/0x140
[ 2804.355140]  [<ffffffff8029ba37>] update_process_times+0x57/0x90
[ 2804.355157]  [<ffffffff8027b1e4>] smp_local_timer_interrupt+0x34/0x60
[ 2804.355171]  [<ffffffff8027b5ba>] smp_send_timer_broadcast_ipi+0x3a/0x60
[ 2804.355188]  [<ffffffff80271423>] timer_interrupt+0x23/0x30
[ 2804.355259]  [<ffffffff8020fe0e>] handle_IRQ_event+0x1e/0x60
[ 2804.355275]  [<ffffffff802c919a>] handle_edge_irq+0xfa/0x150
[ 2804.355291]  [<ffffffff80270180>] do_IRQ+0x110/0x190
[ 2804.355306]  [<ffffffff8025f666>] ret_from_intr+0x0/0xf
[ 2804.355371]  <EOI>  [<ffffffff8024e22c>] shrink_dcache_parent+0x2c/0x120
[ 2804.355399]  [<ffffffff802076ac>] _raw_spin_lock+0xac/0x140
[ 2804.355413]  [<ffffffff802076b9>] _raw_spin_lock+0xb9/0x140
[ 2804.355484]  [<ffffffff8024e22c>] shrink_dcache_parent+0x2c/0x120
[ 2804.355499]  [<ffffffff80312456>] proc_flush_task+0x76/0x220
[ 2804.355518]  [<ffffffff80216f56>] release_task+0x316/0x360
[ 2804.355532]  [<ffffffff8022796f>] do_wait+0x80f/0xc10
[ 2804.355607]  [<ffffffff80290d90>] default_wake_function+0x0/0x10
[ 2804.355624]  [<ffffffff8025f11e>] system_call+0x7e/0x83
[ 2804.355639] 
[ 2804.355646] INFO: lockdep is turned off.
[ 2821.783782] BUG: spinlock lockup on CPU#0, init/1, ffffffff806b0e00
[ 2821.783793] 
[ 2821.783794] Call Trace:
[ 2821.783830]  [<ffffffff802076fa>] _raw_spin_lock+0xfa/0x140
[ 2821.783845]  [<ffffffff8024e22c>] shrink_dcache_parent+0x2c/0x120
[ 2821.783866]  [<ffffffff80312456>] proc_flush_task+0x76/0x220
[ 2821.783895]  [<ffffffff80216f56>] release_task+0x316/0x360
[ 2821.783910]  [<ffffffff8022796f>] do_wait+0x80f/0xc10
[ 2821.783939]  [<ffffffff80290d90>] default_wake_function+0x0/0x10
[ 2821.783956]  [<ffffffff8025f11e>] system_call+0x7e/0x83
[ 2821.783983] 
[ 2821.783989] INFO: lockdep is turned off.

-- 
Zan Lynx <zlynx@acm.org>

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: 2.6.21-rc5-mm2 OOPS and spinlock lockup
  2007-03-28 20:20 ` 2.6.21-rc5-mm2 OOPS and spinlock lockup Zan Lynx
@ 2007-03-28 20:50   ` Andrew Morton
  0 siblings, 0 replies; 29+ messages in thread
From: Andrew Morton @ 2007-03-28 20:50 UTC (permalink / raw)
  To: Zan Lynx; +Cc: linux-kernel, Maneesh Soni, Dipankar Sarma

On Wed, 28 Mar 2007 14:20:16 -0600
Zan Lynx <zlynx@acm.org> wrote:

> On Mon, 2007-03-26 at 21:16 -0800, Andrew Morton wrote:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc5/2.6.21-rc5-mm2/
> > 
> > 
> > - This is the same as 2.6.12-rc5-mm1, except the staircase deadline CPU
> >   scheduler has been added.
> 
> Here is the last bit of netconsole dump I had from my laptop when the
> kernel died just now.
> 
> Note that the kernel is compiled with SMP but the laptop is one core
> only. I have CONFIG_DEBUG_SPINLOCK=y and CONFIG_DEBUG_SPINLOCK_SLEEP=y
> 
> It's AMD-64.
> 
> [ 2597.436421] Hangcheck: hangcheck value past margin!
> [ 2794.356033] Unable to handle kernel NULL pointer dereference at 00000000000000c0 RIP: 
> [ 2794.356058]  [<ffffffff8020761f>] _raw_spin_lock+0x1f/0x140
> [ 2794.356088] PGD 9f39067 PUD 9f38067 PMD 0 
> [ 2794.356180] Oops: 0000 [1] PREEMPT SMP 
> [ 2794.356261] last sysfs file: devices/system/cpu/cpu0/cpufreq/scaling_setspeed
> [ 2794.356328] CPU 0 
> [ 2794.356341] Modules linked in: netconsole nls_iso8859_1 nls_cp437 vfat fat nls_base zaurus cdc_ether usbnet snd_pcm_oss snd_mixer_oss rfcomm hidp hid l2cap ipv6 hci_usb bluetooth usb_storage snd_intel8x0 psmouse serio_raw snd_ac97_codec ac97_bus snd_pcm snd_timer snd snd_page_alloc ehci_hcd ohci_hcd ssb usbcore evdev sg
> [ 2794.357227] Pid: 8049, comm: khidpd_046db3e1 Not tainted 2.6.21-rc5-mm2 #1
> [ 2794.357295] RIP: 0010:[<ffffffff8020761f>]  [<ffffffff8020761f>] _raw_spin_lock+0x1f/0x140
> [ 2794.357318] RSP: 0000:ffff81000d865d10  EFLAGS: 00010282
> [ 2794.357329] RAX: ffff81000d739040 RBX: 00000000000000b8 RCX: 0000000000000000
> [ 2794.357396] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 00000000000000b8
> [ 2794.357408] RBP: ffff81000e23dd08 R08: 0000000000000002 R09: 0000000000000000
> [ 2794.357422] R10: ffffffff80318019 R11: 2222222222222222 R12: ffff81000e23dd10
> [ 2794.357435] R13: 0000000000000000 R14: ffff81000e16b928 R15: ffff81000b518720
>  [<ffffffff8020761f>] _raw_spin_lock+0x1f/0x140
> [ 2794.359149]  RSP <ffff81000d865d10>
> [ 2794.359214] CR2: 00000000000000c0
> [ 2794.359268] note: khidpd_046db3e1[8049] exited with preempt_count 3
> [ 2804.355026] BUG: soft lockup detected on CPU#0!
> [ 2804.355037] 
> [ 2804.355039] Call Trace:
> [ 2804.355051]  <IRQ>  [<ffffffff802c7659>] softlockup_tick+0xf9/0x140
> [ 2804.355140]  [<ffffffff8029ba37>] update_process_times+0x57/0x90
> [ 2804.355157]  [<ffffffff8027b1e4>] smp_local_timer_interrupt+0x34/0x60
> [ 2804.355171]  [<ffffffff8027b5ba>] smp_send_timer_broadcast_ipi+0x3a/0x60
> [ 2804.355188]  [<ffffffff80271423>] timer_interrupt+0x23/0x30
> [ 2804.355259]  [<ffffffff8020fe0e>] handle_IRQ_event+0x1e/0x60
> [ 2804.355275]  [<ffffffff802c919a>] handle_edge_irq+0xfa/0x150
> [ 2804.355291]  [<ffffffff80270180>] do_IRQ+0x110/0x190
> [ 2804.355306]  [<ffffffff8025f666>] ret_from_intr+0x0/0xf
> [ 2804.355371]  <EOI>  [<ffffffff8024e22c>] shrink_dcache_parent+0x2c/0x120
> [ 2804.355399]  [<ffffffff802076ac>] _raw_spin_lock+0xac/0x140
> [ 2804.355413]  [<ffffffff802076b9>] _raw_spin_lock+0xb9/0x140
> [ 2804.355484]  [<ffffffff8024e22c>] shrink_dcache_parent+0x2c/0x120
> [ 2804.355499]  [<ffffffff80312456>] proc_flush_task+0x76/0x220
> [ 2804.355518]  [<ffffffff80216f56>] release_task+0x316/0x360
> [ 2804.355532]  [<ffffffff8022796f>] do_wait+0x80f/0xc10
> [ 2804.355607]  [<ffffffff80290d90>] default_wake_function+0x0/0x10
> [ 2804.355624]  [<ffffffff8025f11e>] system_call+0x7e/0x83


Thanks.  This might have been caused by fix-sysfs-reclaim-crash.patch,
which I have now dropped.  If you're able to reproduce the crash, please
see if reverting that patch (reproduced below) fixes it.  

If it isn't reproducibl, please keep an eye out for problems in next -mm.


From: Maneesh Soni <maneesh@in.ibm.com>

Maybe.

  happens without i_mutex. It also nullifies s_dentry just to indicate that
  the associated dentry is evicted. sysfs_readdir() access the s_dentry,
  and gets the inode number from the associated dentry, if there is one, else
  it invokes iunique(). This can create a race situation, and crash while
  accessing the dentry/inode in sysfs_readdir().

o The following patch always use i_unique() to get the inode number. This
  is ok as sysfs doesnot have permanent inode numbering. It could be slower
  but avoids the above mentioned race.

o This also avoids the now unnecessary s_dentry in sysfs_d_iput().

Signed-off-by: Maneesh Soni <maneesh@in.ibm.com>
Cc: Ethan Solomita <solo@google.com>
Cc: Dipankar Sarma <dipankar@in.ibm.com>
Cc: Greg KH <greg@kroah.com>
Cc: Martin Bligh <mbligh@google.com>
Cc: Rohit Seth <rohitseth@google.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/sysfs/dir.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff -puN fs/sysfs/dir.c~fix-sysfs-reclaim-crash fs/sysfs/dir.c
--- a/fs/sysfs/dir.c~fix-sysfs-reclaim-crash
+++ a/fs/sysfs/dir.c
@@ -20,7 +20,6 @@ static void sysfs_d_iput(struct dentry *
 
 	if (sd) {
 		BUG_ON(sd->s_dentry != dentry);
-		sd->s_dentry = NULL;
 		sysfs_put(sd);
 	}
 	iput(inode);
@@ -538,10 +537,7 @@ static int sysfs_readdir(struct file * f
 
 				name = sysfs_get_name(next);
 				len = strlen(name);
-				if (next->s_dentry)
-					ino = next->s_dentry->d_inode->i_ino;
-				else
-					ino = iunique(sysfs_sb, 2);
+				ino = iunique(sysfs_sb, 2);
 
 				if (filldir(dirent, name, len, filp->f_pos, ino,
 						 dt_type(next)) < 0)
_


^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [FIXED] Re: tty OOPS (Re: 2.6.21-rc5-mm2)
  2007-03-28 20:15             ` [FIXED] " Andreas Mohr
@ 2007-03-28 21:08               ` Ethan Solomita
  2007-03-28 21:27               ` Ethan Solomita
  1 sibling, 0 replies; 29+ messages in thread
From: Ethan Solomita @ 2007-03-28 21:08 UTC (permalink / raw)
  To: Andreas Mohr
  Cc: Alexey Dobriyan, Andrew Morton, Maneesh Soni, Greg KH, linux-kernel

Andreas Mohr wrote:
> Hi,
>
> On Wed, Mar 28, 2007 at 10:56:32PM +0400, Alexey Dobriyan wrote:
>   
>> The only suspicious new patch in -rc5-mm1 to me is
>> fix-sysfs-reclaim-crash.patch which removes "sd->s_dentry = NULL;". Note
>> that whole sysfs_drop_dentry() is NOP if ->s_dentry is NULL.
>>
>> Could you try to revert it?
>>
>> 	Alexey, who knows very little about sysfs internals
>>     
>
> Apparently that's still too much knowledge ;)
>
> Or, in other words: 6 reboots already and not a single problem!
>
> So yes, the removal of the NULLing line in this patch most likely
> has caused this issue on my box.
> Now the question is whether something as simple as that is a fully
> correct fix or whether something should be done entirely differently.
> I'll let people more familiar with those parts decide about it...
>   

    Sorry -- I've only just been cc'd on this mail thread. Are we 
claiming that this patch/fix has caused a new problem, or successfully 
fixed an old problem?

    Thanks!
    -- Ethan


^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [FIXED] Re: tty OOPS (Re: 2.6.21-rc5-mm2)
  2007-03-28 20:15             ` [FIXED] " Andreas Mohr
  2007-03-28 21:08               ` Ethan Solomita
@ 2007-03-28 21:27               ` Ethan Solomita
  1 sibling, 0 replies; 29+ messages in thread
From: Ethan Solomita @ 2007-03-28 21:27 UTC (permalink / raw)
  To: Andreas Mohr
  Cc: Alexey Dobriyan, Andrew Morton, Maneesh Soni, Greg KH, linux-kernel

    Apologies -- I didn't notice lkml on the cc list. I'll catch up from 
lkml directly.
    -- Ethan


^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: tty OOPS (Re: 2.6.21-rc5-mm2)
  2007-03-28 20:07             ` Andrew Morton
@ 2007-03-29 12:48               ` Maneesh Soni
  0 siblings, 0 replies; 29+ messages in thread
From: Maneesh Soni @ 2007-03-29 12:48 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Alexey Dobriyan, Andreas Mohr, Greg KH, linux-kernel,
	Dipankar Sarma, ego

On Wed, Mar 28, 2007 at 01:07:56PM -0700, Andrew Morton wrote:
> On Wed, 28 Mar 2007 22:56:32 +0400
> Alexey Dobriyan <adobriyan@gmail.com> wrote:
> 
> > On Wed, Mar 28, 2007 at 10:38:14PM +0400, Alexey Dobriyan wrote:
> > > On Wed, Mar 28, 2007 at 08:04:46PM +0200, Andreas Mohr wrote:
> > > > [unrelated maintainers removed, Alexey added]
> > > >
> > > > On Wed, Mar 28, 2007 at 07:45:24PM +0200, Andreas Mohr wrote:
> > > > > Hi,
> > > > >
> > > > > just wanted to add that when analyzing the backtrace I found the comment
> > > > > at drivers/char/vt.c/con_close() to be VERY suspicious...
> > > > > (need to take tty_mutex to prevent concurrent thread tty access).
> > > > > This might just be what happened here despite trying to protect against it.
> > > >
> > > > OK, can we assume that one of
> > > >
> > > > +protect-tty-drivers-list-with-tty_mutex.patch
> > > > +tty-minor-merge-correction.patch
> > > > +tty-in-tiocsctty-when-we-steal-a-tty-hang-it-up-fix.patch
> > > >
> > > > is responsible / not implemented fully?
> > >
> > > #2 is just comment removal.
> > >
> > > I may state the obvious, but __iget() in sysfs_drop_dentry() gets NULL
> > > inode and you aren't failing on spin_lock one line above because of UP
> > > without spinlock debugging.
> > 
> > The only suspicious new patch in -rc5-mm1 to me is
> > fix-sysfs-reclaim-crash.patch which removes "sd->s_dentry = NULL;". Note
> > that whole sysfs_drop_dentry() is NOP if ->s_dentry is NULL.
> > 
> > Could you try to revert it?
> > 
> > 	Alexey, who knows very little about sysfs internals
> 
> cc's added.
> 
> 
> Also added is the sad little missive I sent to the USB guys last night,
> which is similar-looking:
> 
> 
> 
> Begin forwarded message:
> 
> Date: Wed, 28 Mar 2007 00:34:45 -0700
> From: Andrew Morton <akpm@linux-foundation.org>
> To: linux-usb-devel@lists.sourceforge.net
> Subject: usb/sysfs oops in 2.6.21-rc5-mm1
> 
> 
> 
> I think the connector wasn't pushed in terribly well, so there might have
> been some contact bounce.
> 
> 
> [15813.836000] ipw2200: Firmware error detected.  Restarting.
> [17200.268000] hub 2-0:1.0: port 1 disabled by hub (EMI?), re-enabling...
> [17200.268000] usb 2-1: USB disconnect, address 4
> [17200.268000] BUG: unable to handle kernel NULL pointer dereference at virtual address 00000024
> [17200.268000]  printing eip:
> [17200.268000] c016e447
> [17200.268000] *pde = 00000000
> [17200.268000] Oops: 0000 [#1]
> [17200.268000] last sysfs file: block/sr0/size
> [17200.268000] Modules linked in: udf i915 drm ipw2200 sonypi ipv6 autofs4 hidp l2cap sunrpc nf_conntrack_netbios_ns ipt_REJECT nf_conntrack_ipv4 xt_state nf_conntrack nfnetlink xt_tcpudp iptable_filter ip_tables x_tables cpufreq_ondemand video sbs button battery asus_acpi ac nvram hci_usb bluetooth ieee80211 ohci1394 ieee1394 joydev ieee80211_crypt snd_hda_intel snd_hda_codec ehci_hcd uhci_hcd sg snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device snd_pcm_oss snd_mixer_oss snd_pcm snd_timer snd sr_mod cdrom piix soundcore i2c_i801 snd_page_alloc i2c_core pcspkr generic ext3 jbd ide_disk ide_core
> [17200.268000] CPU:    0
> [17200.268000] EIP:    0060:[<c016e447>]    Not tainted VLI
> [17200.268000] EFLAGS: 00010246   (2.6.21-rc5-mm1 #1)
> [17200.268000] EIP is at __iget+0x3/0x48
> [17200.268000] eax: 00000000   ebx: 00000000   ecx: 00000000   edx: c8a90514
> [17200.268000] esi: c8a90514   edi: 00000000   ebp: c8cea5e4   esp: c210fe5c
> [17200.268000] ds: 007b   es: 007b   fs: 00d8  gs: 0000  ss: 0068
> [17200.268000] Process khubd (pid: 155, ti=c210e000 task=c209b6f0 task.ti=c210e000)
> [17200.268000] Stack: c2493a14 c0192933 c8cea5e8 c0338373 c0338373 c8cea5e4 c0192a90 c889ba24 
> [17200.268000]        c033836f c8a90514 c8cea58c c889ba08 c8556a40 df8918c0 c24e6418 c0230d46 
> [17200.268000]        c889ba08 c889ba08 c0230dd8 c889ba08 c889ba00 df8918c0 c24e6418 c0230ffa 
> [17200.268000] Call Trace:
> [17200.268000]  [<c0192933>] sysfs_drop_dentry+0x2b/0xc3
> [17200.268000]  [<c0192a90>] sysfs_hash_and_remove+0x86/0x12c
> [17200.268000]  [<c0230d46>] device_remove_file+0x19/0x25
> [17200.268000]  [<c0230dd8>] device_del+0x26/0x240
> [17200.268000]  [<c0230ffa>] device_unregister+0x8/0x10
> [17200.268000]  [<c026739a>] usb_remove_ep_files+0x4d/0x60
> [17200.268000]  [<c0260031>] usb_new_device+0x199/0x1ab
> [17200.268000]  [<c0266d14>] usb_remove_sysfs_intf_files+0x1e/0x43
> [17200.268000]  [<c026312d>] usb_disable_device+0x55/0xbb
> [17200.268000]  [<c0260415>] usb_disconnect+0x87/0x100
> [17200.268000]  [<c0260842>] hub_thread+0x361/0xa70
> [17200.268000]  [<c016d394>] d_lookup+0x16/0x31
> [17200.268000]  [<c01174df>] __wake_up_common+0x31/0x4f
> [17200.268000]  [<c0128754>] autoremove_wake_function+0x0/0x35
> [17200.268000]  [<c02604e1>] hub_thread+0x0/0xa70
> [17200.268000]  [<c01285f7>] kthread+0xa0/0xc9
> [17200.268000]  [<c0128557>] kthread+0x0/0xc9
> [17200.268000]  [<c010464f>] kernel_thread_helper+0x7/0x10
> [17200.268000]  =======================
> [17200.268000] Code: 00 00 00 89 d8 81 ce 00 02 00 00 e8 3e ba 01 00 8b 43 20 31 c9 89 f2 89 04 24 89 d8 e8 19 25 01 00 58 5b 5e c3 90 90 90 53 89 c3 <83> 78 24 00 74 05 ff 40 24 eb 38 ff 40 24 f6 80 2c 01 00 00 0f 
> [17200.268000] EIP: [<c016e447>] __iget+0x3/0x48 SS:ESP 0068:c210fe5c
> [17327.844000] ipw2200: Firmware error detected.  Restarting.

This is indeed because of my patch in -mm1. Gautham has also got this 
recreated in his CPU hotplug testing and he has thankfully provided me
a crashdump.

In the dump, so far it looks like that we have a sysfs_dirent (corresponding to
file /sys/devices/system/cpu/cpu1/microcode/processor_flags), with a corrupted
s_dentry.

crash> struct sysfs_dirent c7721f2c
struct sysfs_dirent {
  s_count = {
    counter = 1
  },
  s_sibling = {
    next = 0xc7721f30,
    prev = 0xc7721f30
  },
  s_children = {
    next = 0xc7721f38,
    prev = 0xc7721f38
  },
  s_element = 0xc05ec7a4,
  s_type = 4,
  s_mode = 33024,
  s_dentry = 0xc790d254,
  s_iattr = 0x0,
  s_event = {
    counter = 1
  }
}

crash> struct dentry.d_count 0xc790d254
  d_count = {
    counter = 0
  },

crash> struct dentry.d_flags 0xc790d254
  d_flags = 0,

I am still looking at this problem and will update further.

Thanks
Maneesh


--
Maneesh Soni
Linux Technology Center,
IBM India Systems and Technology Lab, 
Bangalore, India

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: 2.6.21-rc5-mm2
  2007-03-29 17:53 ` 2.6.21-rc5-mm2 Badari Pulavarty
@ 2007-03-29 17:23   ` Andrew Morton
  0 siblings, 0 replies; 29+ messages in thread
From: Andrew Morton @ 2007-03-29 17:23 UTC (permalink / raw)
  To: Badari Pulavarty; +Cc: lkml, John W. Linville

On Thu, 29 Mar 2007 09:53:27 -0800 Badari Pulavarty <pbadari@gmail.com> wrote:

> On Mon, 2007-03-26 at 21:16 -0800, Andrew Morton wrote:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc5/2.6.21-rc5-mm2/
> > 
> > 
> > - This is the same as 2.6.12-rc5-mm1, except the staircase deadline CPU
> >   scheduler has been added.
> 
> make allyesconfig - didn't give me a clean build :(
> (not crucial for me to get it right -- but FYI).
> 
> Thanks,
> Badari
> 
>   CHK     include/linux/version.h
>   CHK     include/linux/utsrelease.h
>   CHK     include/linux/compile.h
>   CC      drivers/net/e100.o
>   LD      drivers/net/wireless/built-in.o
>   CC      drivers/net/epic100.o
>   CC      drivers/net/sis190.o
> drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
> drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_chip_switch_radio_on'
>   CC      drivers/net/sis900.o
> drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
> drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
>
> [zillions more errors]

yeah, not surprised.

John, please test allyesconfig ;)

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: 2.6.21-rc5-mm2
  2007-03-27  5:16 2.6.21-rc5-mm2 Andrew Morton
                   ` (4 preceding siblings ...)
  2007-03-28 20:20 ` 2.6.21-rc5-mm2 OOPS and spinlock lockup Zan Lynx
@ 2007-03-29 17:53 ` Badari Pulavarty
  2007-03-29 17:23   ` 2.6.21-rc5-mm2 Andrew Morton
  2007-03-29 18:20 ` 2.6.21-rc5-mm2 - compile error on x86-64 Helge Hafting
  6 siblings, 1 reply; 29+ messages in thread
From: Badari Pulavarty @ 2007-03-29 17:53 UTC (permalink / raw)
  To: Andrew Morton; +Cc: lkml

On Mon, 2007-03-26 at 21:16 -0800, Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc5/2.6.21-rc5-mm2/
> 
> 
> - This is the same as 2.6.12-rc5-mm1, except the staircase deadline CPU
>   scheduler has been added.

make allyesconfig - didn't give me a clean build :(
(not crucial for me to get it right -- but FYI).

Thanks,
Badari

  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  CHK     include/linux/compile.h
  CC      drivers/net/e100.o
  LD      drivers/net/wireless/built-in.o
  CC      drivers/net/epic100.o
  CC      drivers/net/sis190.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_chip_switch_radio_on'
  CC      drivers/net/sis900.o
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_dma_tx_suspend'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_dma_tx_suspend' changed from 141 in drivers/net/wireless/bcm43xx/built-in.o to 108 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_tail'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_pio_tx_resume'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_pio_tx_resume' changed from 101 in drivers/net/wireless/bcm43xx/built-in.o to 89 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_phy_xmitpower'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_phy_xmitpower' changed from 1312 in drivers/net/wireless/bcm43xx/built-in.o to 1126 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_chip_disable_hwint'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_shm_write16'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_shm_write16' changed from 127 in drivers/net/wireless/bcm43xx/built-in.o to 218 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_usb_tx'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_raw_phy_unlock'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_raw_phy_unlock' changed from 238 in drivers/net/wireless/bcm43xx/built-in.o to 168 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_switch_radio_off'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_dmacontroller_base'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_chip_control_leds'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_debugfs_add_device'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_debugfs_add_device' changed from 535 in drivers/net/wireless/bcm43xx/built-in.o to 460 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_usb_disable_int'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_chip_unlock_phy_regs'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_generate_txhdr'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_generate_txhdr' changed from 900 in drivers/net/wireless/bcm43xx/built-in.o to 1217 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_chip_init'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_radio_turn_off'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_radio_turn_off' changed from 428 in drivers/net/wireless/bcm43xx/built-in.o to 238 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_rx_qual_percent'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_plcp_get_ratecode_ofdm'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_dma_tx'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_dma_tx' changed from 2312 in drivers/net/wireless/bcm43xx/built-in.o to 1652 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_chip_get_channel'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_power_saving_ctl_bits'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_power_saving_ctl_bits' changed from 119 in drivers/net/wireless/bcm43xx/built-in.o to 109 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_rf_clear'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_chip_clear'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_leds_update'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_leds_update' changed from 1040 in drivers/net/wireless/bcm43xx/built-in.o to 625 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_rf_init_al7230b'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_read_mac_addr'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_ioread32v'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_rfwritev_cr_locked'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_sysfs_register'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_sysfs_register' changed from 260 in drivers/net/wireless/bcm43xx/built-in.o to 144 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_rf_init_rf2959'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_radio_set_interference_mitigation'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_radio_set_interference_mitigation' changed from 6014 in drivers/net/wireless/bcm43xx/built-in.o to 5452 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_chip_enable_int'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_radio_init2060'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_mac_clear'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
ld: Warning: size of symbol `zd_mac_clear' changed from 126 in drivers/net/wireless/zd1211rw/built-in.o to 102 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_chip_enable_rx'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_printk_bitdump'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_printk_bitdump' changed from 242 in drivers/net/wireless/bcm43xx/built-in.o to 255 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_set_beacon_interval'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_calc_nrssi_slope'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_calc_nrssi_slope' changed from 5595 in drivers/net/wireless/bcm43xx/built-in.o to 5208 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_nrssi_hw_update'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_nrssi_hw_update' changed from 87 in drivers/net/wireless/bcm43xx/built-in.o to 86 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_radio_aci_detect'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_radio_aci_detect' changed from 318 in drivers/net/wireless/bcm43xx/built-in.o to 223 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_radio_set_tx_iq'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_dma_rx'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_dma_rx' changed from 2366 in drivers/net/wireless/bcm43xx/built-in.o to 1864 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_debugfs_log_txstat'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_debugfs_log_txstat' changed from 135 in drivers/net/wireless/bcm43xx/built-in.o to 173 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_leds_init'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_leds_init' changed from 345 in drivers/net/wireless/bcm43xx/built-in.o to 339 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_ioread16'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_usb_init'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_ioread32v_locked'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_chip_disable_rx'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_dma_init'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_dma_init' changed from 855 in drivers/net/wireless/bcm43xx/built-in.o to 635 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_leds_switch_all'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_leds_switch_all' changed from 175 in drivers/net/wireless/bcm43xx/built-in.o to 180 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_nrssi_mem_update'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_nrssi_mem_update' changed from 189 in drivers/net/wireless/bcm43xx/built-in.o to 98 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_radio_set_txpower_a'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_radio_set_txpower_a' changed from 667 in drivers/net/wireless/bcm43xx/built-in.o to 603 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_radio_aci_scan'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_radio_aci_scan' changed from 690 in drivers/net/wireless/bcm43xx/built-in.o to 531 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_radio_init2050'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_radio_init2050' changed from 2418 in drivers/net/wireless/bcm43xx/built-in.o to 2363 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_phy_write'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_phy_write' changed from 59 in drivers/net/wireless/bcm43xx/built-in.o to 111 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_read_regdomain'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_debugfs_init'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_calc_nrssi_threshold'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_calc_nrssi_threshold' changed from 833 in drivers/net/wireless/bcm43xx/built-in.o to 696 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_rx_rate'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_raw_phy_lock'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_raw_phy_lock' changed from 263 in drivers/net/wireless/bcm43xx/built-in.o to 191 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_pio_tx'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_pio_tx' changed from 519 in drivers/net/wireless/bcm43xx/built-in.o to 343 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_nrssi_hw_write'
  CC      drivers/net/yellowfin.o
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_controller_restart'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_controller_restart' changed from 102 in drivers/net/wireless/bcm43xx/built-in.o to 48 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_shm_write32'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_shm_write32' changed from 208 in drivers/net/wireless/bcm43xx/built-in.o to 275 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `_zd_iowrite32v_locked'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_radio_write16'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_radio_write16' changed from 59 in drivers/net/wireless/bcm43xx/built-in.o to 53 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_iowrite32a'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_nrssi_hw_read'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_nrssi_hw_read' changed from 44 in drivers/net/wireless/bcm43xx/built-in.o to 43 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_printk_dump'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_printk_dump' changed from 122 in drivers/net/wireless/bcm43xx/built-in.o to 125 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_rfwrite_cr_locked'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_radio_unlock'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_radio_unlock' changed from 72 in drivers/net/wireless/bcm43xx/built-in.o to 64 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_chip_switch_radio_off'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_rx_strength_percent'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_usb_enable_rx'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_write_mac_addr'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_dummy_transmission'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_dummy_transmission' changed from 758 in drivers/net/wireless/bcm43xx/built-in.o to 555 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_rfwritev_locked'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_chip_set_channel'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_ioread32'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
ld: Warning: size of symbol `zd_ioread32' changed from 88 in drivers/net/wireless/zd1211rw/built-in.o to 89 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_radio_read16'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_radio_read16' changed from 341 in drivers/net/wireless/bcm43xx/built-in.o to 162 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_phy_read'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_phy_read' changed from 56 in drivers/net/wireless/bcm43xx/built-in.o to 97 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_shm_read16'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_shm_read16' changed from 126 in drivers/net/wireless/bcm43xx/built-in.o to 200 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_pio_tx_suspend'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_pio_tx_suspend' changed from 69 in drivers/net/wireless/bcm43xx/built-in.o to 68 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `bcm43xx_tsf_read'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_tsf_read' changed from 361 in drivers/net/wireless/bcm43xx/built-in.o to 326 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `bcm43xx_conf_tx':
drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c:398: multiple definition of `zd_rf_init'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
  CC      drivers/net/acenic.o
  CC      drivers/net/natsemi.o
drivers/net/wireless/mac80211/built-in.o:(.bss+0x400e8): multiple definition of `zd_workqueue'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:1665: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_dmacontroller_tx_reset'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_dmacontroller_tx_reset' changed from 270 in drivers/net/wireless/bcm43xx/built-in.o to 262 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_usb_ioread16v'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_pio_free'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_pio_free' changed from 246 in drivers/net/wireless/bcm43xx/built-in.o to 104 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_phy_init_tssi2dbm_table'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_phy_init_tssi2dbm_table' changed from 832 in drivers/net/wireless/bcm43xx/built-in.o to 708 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_dma_free'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_dma_free' changed from 314 in drivers/net/wireless/bcm43xx/built-in.o to 176 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_hexdump'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_dma_tx_resume'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_dma_tx_resume' changed from 139 in drivers/net/wireless/bcm43xx/built-in.o to 105 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_phy_init'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_phy_init' changed from 1727 in drivers/net/wireless/bcm43xx/built-in.o to 1452 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_rf_set_channel'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_pio_freeze_txqueues'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_pio_freeze_txqueues' changed from 279 in drivers/net/wireless/bcm43xx/built-in.o to 124 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_mac_suspend'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_mac_suspend' changed from 232 in drivers/net/wireless/bcm43xx/built-in.o to 220 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_usb_scnprint_id'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_switch_radio_on'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_plcp_get_ratecode_cck'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_chip_init_hw'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_pio_thaw_txqueues'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_pio_thaw_txqueues' changed from 426 in drivers/net/wireless/bcm43xx/built-in.o to 272 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_tsf_write'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_tsf_write' changed from 296 in drivers/net/wireless/bcm43xx/built-in.o to 200 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_iowrite16a_locked'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_usb_enable_int'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_chip_set_multicast_hash'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_mac_enable'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_mac_enable' changed from 201 in drivers/net/wireless/bcm43xx/built-in.o to 191 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_rf_init_al2230'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_debugfs_exit'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_rf_init_hw'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_usb_disable_rx'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_pio_init'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_pio_init' changed from 389 in drivers/net/wireless/bcm43xx/built-in.o to 218 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_iowrite16'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_debugfs_remove_device'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_debugfs_remove_device' changed from 173 in drivers/net/wireless/bcm43xx/built-in.o to 142 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_usb_iowrite16v'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_chip_disable_int'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_radio_turn_on'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_radio_turn_on' changed from 559 in drivers/net/wireless/bcm43xx/built-in.o to 357 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_wireless_core_reset'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_wireless_core_reset' changed from 388 in drivers/net/wireless/bcm43xx/built-in.o to 237 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_iowrite32'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_dmacontroller_rx_reset'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_dmacontroller_rx_reset' changed from 154 in drivers/net/wireless/bcm43xx/built-in.o to 149 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_chip_enable_hwint'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
ld: Warning: size of symbol `zd_chip_enable_hwint' changed from 80 in drivers/net/wireless/zd1211rw/built-in.o to 79 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_rf_name'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_radio_selectchannel'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_radio_selectchannel' changed from 1268 in drivers/net/wireless/bcm43xx/built-in.o to 1107 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_usb_clear'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_chip_lock_phy_regs'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_pio_rx'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_pio_rx' changed from 1004 in drivers/net/wireless/bcm43xx/built-in.o to 764 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_default_baseband_attenuation'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_default_baseband_attenuation' changed from 127 in drivers/net/wireless/bcm43xx/built-in.o to 31 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_usb_rfwrite'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_get_e2p_mac_addr'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_default_radio_attenuation'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_default_radio_attenuation' changed from 521 in drivers/net/wireless/bcm43xx/built-in.o to 351 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_mac_init_hw'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
ld: Warning: size of symbol `zd_mac_init_hw' changed from 410 in drivers/net/wireless/zd1211rw/built-in.o to 279 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_rf_scnprint_id'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_sysfs_unregister'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_sysfs_unregister' changed from 96 in drivers/net/wireless/bcm43xx/built-in.o to 50 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_shm_read32'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_shm_read32' changed from 210 in drivers/net/wireless/bcm43xx/built-in.o to 261 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_rx'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_rx' changed from 1652 in drivers/net/wireless/bcm43xx/built-in.o to 1723 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `zd_iowrite32a_locked'
drivers/net/wireless/zd1211rw/built-in.o:drivers/net/wireless/zd1211rw/zd_chip.c:89: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_radio_lock'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_radio_lock' changed from 66 in drivers/net/wireless/bcm43xx/built-in.o to 61 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_radio_set_txpower_bg'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_radio_set_txpower_bg' changed from 645 in drivers/net/wireless/bcm43xx/built-in.o to 404 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_phy_set_baseband_attenuation'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_phy_set_baseband_attenuation' changed from 243 in drivers/net/wireless/bcm43xx/built-in.o to 145 in drivers/net/wireless/mac80211/built-in.o
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_leds_exit'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
drivers/net/wireless/mac80211/built-in.o: In function `rtl8225_write':
drivers/net/wireless/mac80211/rtl818x/rtl8187_rtl8225.c:496: multiple definition of `bcm43xx_default_txctl1'
drivers/net/wireless/bcm43xx/built-in.o:drivers/net/wireless/bcm43xx/bcm43xx_main.c:696: first defined here
ld: Warning: size of symbol `bcm43xx_default_txctl1' changed from 141 in drivers/net/wireless/bcm43xx/built-in.o to 45 in drivers/net/wireless/mac80211/built-in.o
drivers/net/natsemi.c: In function ‘natsemi_resume’:
drivers/net/natsemi.c:3255: warning: ignoring return value of ‘pci_enable_device’, declared with attribute warn_unused_result
  CC      drivers/net/ns83820.o
  CC      drivers/net/fealnx.o
make[3]: *** [drivers/net/wireless/built-in.o] Error 1
make[2]: *** [drivers/net/wireless] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2



^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: 2.6.21-rc5-mm2 - compile error on x86-64
  2007-03-27  5:16 2.6.21-rc5-mm2 Andrew Morton
                   ` (5 preceding siblings ...)
  2007-03-29 17:53 ` 2.6.21-rc5-mm2 Badari Pulavarty
@ 2007-03-29 18:20 ` Helge Hafting
  2007-03-29 21:28   ` Andrew Morton
  6 siblings, 1 reply; 29+ messages in thread
From: Helge Hafting @ 2007-03-29 18:20 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel

I tried compiling this on x86-64, and got this compile error:
  CC      init/version.o
  CC      init/missing_syscalls.o
In file included from init/missing_syscalls.c:97:
init/missing_syscalls.h:279:2: warning: #warning syscall ssetmask not
implemented
init/missing_syscalls.h:1263:2: warning: #warning syscall getcpu not
implemented
init/missing_syscalls.h:1267:2: warning: #warning syscall epoll_pwait not
implemented
init/missing_syscalls.h:1271:2: warning: #warning syscall lutimesat not
implemented
init/missing_syscalls.h:1275:2: warning: #warning syscall revokeat not
implemented
init/missing_syscalls.h:1279:2: warning: #warning syscall frevoke not
implemented
  LD      init/built-in.o
  LD      .tmp_vmlinux1
fs/built-in.o: In function `proc_root_init':
/usr/src/linux/fs/proc/root.c:83: undefined reference to `proc_sys_init'
make: *** [.tmp_vmlinux1] Error 1

Helge Hafting


^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: 2.6.21-rc5-mm2 - compile error on x86-64
  2007-03-29 18:20 ` 2.6.21-rc5-mm2 - compile error on x86-64 Helge Hafting
@ 2007-03-29 21:28   ` Andrew Morton
  2007-03-29 22:10     ` Eric W. Biederman
                       ` (2 more replies)
  0 siblings, 3 replies; 29+ messages in thread
From: Andrew Morton @ 2007-03-29 21:28 UTC (permalink / raw)
  To: Helge Hafting; +Cc: linux-kernel, Eric W. Biederman

On Thu, 29 Mar 2007 20:20:20 +0200
Helge Hafting <helgehaf@aitel.hist.no> wrote:

> I tried compiling this on x86-64, and got this compile error:
>   CC      init/version.o
>   CC      init/missing_syscalls.o
> In file included from init/missing_syscalls.c:97:
> init/missing_syscalls.h:279:2: warning: #warning syscall ssetmask not
> implemented
> init/missing_syscalls.h:1263:2: warning: #warning syscall getcpu not
> implemented
> init/missing_syscalls.h:1267:2: warning: #warning syscall epoll_pwait not
> implemented
> init/missing_syscalls.h:1271:2: warning: #warning syscall lutimesat not
> implemented
> init/missing_syscalls.h:1275:2: warning: #warning syscall revokeat not
> implemented
> init/missing_syscalls.h:1279:2: warning: #warning syscall frevoke not
> implemented

yup, people will presumably work on fixing these things up after the
feature hits mainline.

>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> fs/built-in.o: In function `proc_root_init':
> /usr/src/linux/fs/proc/root.c:83: undefined reference to `proc_sys_init'

Ah.  I assume you have CONFIG_SYSCTL=y, CONFIG_PROC_SYSCTL=n?




From: Andrew Morton <akpm@linux-foundation.org>

We're using #ifdef CONFIG_SYSCTL, but we should be using CONFIG_PROC_SYSCTL,
so we get

 fs/built-in.o: In function `proc_root_init':
 /usr/src/linux/fs/proc/root.c:83: undefined reference to `proc_sys_init'

Fix that up and remove an ifdef-in-C.

Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Helge Hafting <helgehaf@aitel.hist.no>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/proc/internal.h |    4 ++++
 fs/proc/root.c     |    2 --
 2 files changed, 4 insertions(+), 2 deletions(-)

diff -puN fs/proc/root.c~proc-fix-linkage-with-config_sysctl=y-config_proc_sysctl=n fs/proc/root.c
--- a/fs/proc/root.c~proc-fix-linkage-with-config_sysctl=y-config_proc_sysctl=n
+++ a/fs/proc/root.c
@@ -79,9 +79,7 @@ void __init proc_root_init(void)
 	proc_device_tree_init();
 #endif
 	proc_bus = proc_mkdir("bus", NULL);
-#ifdef CONFIG_SYSCTL
 	proc_sys_init();
-#endif
 }
 
 static int proc_root_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat
diff -puN fs/proc/internal.h~proc-fix-linkage-with-config_sysctl=y-config_proc_sysctl=n fs/proc/internal.h
--- a/fs/proc/internal.h~proc-fix-linkage-with-config_sysctl=y-config_proc_sysctl=n
+++ a/fs/proc/internal.h
@@ -11,7 +11,11 @@
 
 #include <linux/proc_fs.h>
 
+#ifdef CONFIG_PROC_SYSCTL
 extern int proc_sys_init(void);
+#else
+static inline void proc_sys_init(void) { }
+#endif
 
 struct vmalloc_info {
 	unsigned long	used;
_


^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: 2.6.21-rc5-mm2 - compile error on x86-64
  2007-03-29 21:28   ` Andrew Morton
@ 2007-03-29 22:10     ` Eric W. Biederman
  2007-03-29 22:23       ` Andrew Morton
  2007-03-29 22:24       ` Randy Dunlap
  2007-03-31  6:27     ` Helge Hafting
  2007-03-31  6:50     ` Helge Hafting
  2 siblings, 2 replies; 29+ messages in thread
From: Eric W. Biederman @ 2007-03-29 22:10 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Helge Hafting, linux-kernel, Eric W. Biederman

Andrew Morton <akpm@linux-foundation.org> writes:
>
> Ah.  I assume you have CONFIG_SYSCTL=y, CONFIG_PROC_SYSCTL=n?
>
>
>
>
> From: Andrew Morton <akpm@linux-foundation.org>
>
> We're using #ifdef CONFIG_SYSCTL, but we should be using CONFIG_PROC_SYSCTL,
> so we get

I have no problem with the patch it is clearly more correct than what we
are doing now but I didn't think it was possible to select
CONFIG_SYSCTL and CONFIG_PROCFS without CONFIG_PROC_SYSCTL being
selected...
Do we have a constraint problem in Kconfig?  Or am I misremembering things?

>  fs/built-in.o: In function `proc_root_init':
>  /usr/src/linux/fs/proc/root.c:83: undefined reference to `proc_sys_init'
>
> Fix that up and remove an ifdef-in-C.
>
> Cc: "Eric W. Biederman" <ebiederm@xmission.com>
> Cc: Helge Hafting <helgehaf@aitel.hist.no>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Eric

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: 2.6.21-rc5-mm2 - compile error on x86-64
  2007-03-29 22:10     ` Eric W. Biederman
@ 2007-03-29 22:23       ` Andrew Morton
  2007-03-30  5:10         ` Eric W. Biederman
  2007-03-29 22:24       ` Randy Dunlap
  1 sibling, 1 reply; 29+ messages in thread
From: Andrew Morton @ 2007-03-29 22:23 UTC (permalink / raw)
  To: Eric W. Biederman; +Cc: Helge Hafting, linux-kernel

On Thu, 29 Mar 2007 16:10:50 -0600
ebiederm@xmission.com (Eric W. Biederman) wrote:

> Andrew Morton <akpm@linux-foundation.org> writes:
> >
> > Ah.  I assume you have CONFIG_SYSCTL=y, CONFIG_PROC_SYSCTL=n?
> >
> >
> >
> >
> > From: Andrew Morton <akpm@linux-foundation.org>
> >
> > We're using #ifdef CONFIG_SYSCTL, but we should be using CONFIG_PROC_SYSCTL,
> > so we get
> 
> I have no problem with the patch it is clearly more correct than what we
> are doing now but I didn't think it was possible to select
> CONFIG_SYSCTL and CONFIG_PROCFS without CONFIG_PROC_SYSCTL being
> selected...
> Do we have a constraint problem in Kconfig?  Or am I misremembering things?
> 

config PROC_SYSCTL
        bool "Sysctl support (/proc/sys)" if EMBEDDED
        depends on PROC_FS
        select SYSCTL
        default y

CONFIG_PROC_SYSCTL depends on CONFIG_PROC_FS
CONFIG_PROC_SYSCTL selects CONFIG_SYSCTL

So I don't see anything preventing CONFIG_SYSCTL=y, CONFIG_PROC_FS=y,
CONFIG_PROC_SYSCTL=n.  I assume we can make this combination compile, link
and run easily enough.  I dunno if it makes any actual sense though?


I'd have thought that PROC_SYSCTL should just depend on SYSCTL.  But
SYSCTL's Kconfig setup is weird.


^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: 2.6.21-rc5-mm2 - compile error on x86-64
  2007-03-29 22:10     ` Eric W. Biederman
  2007-03-29 22:23       ` Andrew Morton
@ 2007-03-29 22:24       ` Randy Dunlap
  1 sibling, 0 replies; 29+ messages in thread
From: Randy Dunlap @ 2007-03-29 22:24 UTC (permalink / raw)
  To: Eric W. Biederman; +Cc: Andrew Morton, Helge Hafting, linux-kernel

On Thu, 29 Mar 2007 16:10:50 -0600 Eric W. Biederman wrote:

> Andrew Morton <akpm@linux-foundation.org> writes:
> >
> > Ah.  I assume you have CONFIG_SYSCTL=y, CONFIG_PROC_SYSCTL=n?
> >
> >
> >
> >
> > From: Andrew Morton <akpm@linux-foundation.org>
> >
> > We're using #ifdef CONFIG_SYSCTL, but we should be using CONFIG_PROC_SYSCTL,
> > so we get
> 
> I have no problem with the patch it is clearly more correct than what we
> are doing now but I didn't think it was possible to select
> CONFIG_SYSCTL and CONFIG_PROCFS without CONFIG_PROC_SYSCTL being
> selected...
> Do we have a constraint problem in Kconfig?  Or am I misremembering things?

Hi Eric,

Looks like you are just misremembering things...

> >  fs/built-in.o: In function `proc_root_init':
> >  /usr/src/linux/fs/proc/root.c:83: undefined reference to `proc_sys_init'
> >
> > Fix that up and remove an ifdef-in-C.
> >
> > Cc: "Eric W. Biederman" <ebiederm@xmission.com>
> > Cc: Helge Hafting <helgehaf@aitel.hist.no>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: 2.6.21-rc5-mm2 - compile error on x86-64
  2007-03-29 22:23       ` Andrew Morton
@ 2007-03-30  5:10         ` Eric W. Biederman
  0 siblings, 0 replies; 29+ messages in thread
From: Eric W. Biederman @ 2007-03-30  5:10 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Helge Hafting, linux-kernel

Andrew Morton <akpm@linux-foundation.org> writes:

>
> config PROC_SYSCTL
>         bool "Sysctl support (/proc/sys)" if EMBEDDED
>         depends on PROC_FS
>         select SYSCTL
>         default y
>
> CONFIG_PROC_SYSCTL depends on CONFIG_PROC_FS
> CONFIG_PROC_SYSCTL selects CONFIG_SYSCTL
>
> So I don't see anything preventing CONFIG_SYSCTL=y, CONFIG_PROC_FS=y,
> CONFIG_PROC_SYSCTL=n.  I assume we can make this combination compile, link
> and run easily enough.  I dunno if it makes any actual sense though?
>
>
> I'd have thought that PROC_SYSCTL should just depend on SYSCTL.  But
> SYSCTL's Kconfig setup is weird.

Yes. My memory is now coming back.  I did a few weird things in there 
when I was making the binary interface optional, and it looks like
I never updated the #ifdef in fs/proc/root.c  The primary intent
was to allow the proc support without the binary interface but I
guess the other configuration makes some sense as well in an embedded
scenario when you are trying to be as efficient as possible.  As I
recall the binary interface is less resource intensive then the /proc
interface.

Eric


^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: 2.6.21-rc5-mm2 - compile error on x86-64
  2007-03-29 21:28   ` Andrew Morton
  2007-03-29 22:10     ` Eric W. Biederman
@ 2007-03-31  6:27     ` Helge Hafting
  2007-03-31  6:53       ` Eric W. Biederman
  2007-03-31  6:50     ` Helge Hafting
  2 siblings, 1 reply; 29+ messages in thread
From: Helge Hafting @ 2007-03-31  6:27 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, Eric W. Biederman

On Thu, Mar 29, 2007 at 02:28:16PM -0700, Andrew Morton wrote:
> On Thu, 29 Mar 2007 20:20:20 +0200
> Helge Hafting <helgehaf@aitel.hist.no> wrote:
> 
[...]
> yup, people will presumably work on fixing these things up after the
> feature hits mainline.
> 
> >   LD      init/built-in.o
> >   LD      .tmp_vmlinux1
> > fs/built-in.o: In function `proc_root_init':
> > /usr/src/linux/fs/proc/root.c:83: undefined reference to `proc_sys_init'
> 
> Ah.  I assume you have CONFIG_SYSCTL=y, CONFIG_PROC_SYSCTL=n?

Correct. I seem to remember that the latter is considered 
"deprecated, but some programs may still depend on it".  So I disabled it to 
see what broke.  udev complained about the missing /proc/sys/kernel/hotplug,
but was happy to use /sys/kernel/uevent_helper instead.  I didn't
notice other problems, so I left things like that.

Helge Hafting

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: 2.6.21-rc5-mm2 - compile error on x86-64
  2007-03-29 21:28   ` Andrew Morton
  2007-03-29 22:10     ` Eric W. Biederman
  2007-03-31  6:27     ` Helge Hafting
@ 2007-03-31  6:50     ` Helge Hafting
  2 siblings, 0 replies; 29+ messages in thread
From: Helge Hafting @ 2007-03-31  6:50 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, Eric W. Biederman

The patch did not apply, but mm3 compiled so I'll try that instead.
Helge Hafting

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: 2.6.21-rc5-mm2 - compile error on x86-64
  2007-03-31  6:27     ` Helge Hafting
@ 2007-03-31  6:53       ` Eric W. Biederman
  0 siblings, 0 replies; 29+ messages in thread
From: Eric W. Biederman @ 2007-03-31  6:53 UTC (permalink / raw)
  To: Helge Hafting; +Cc: Andrew Morton, linux-kernel

Helge Hafting <helgehaf@aitel.hist.no> writes:

> Correct. I seem to remember that the latter is considered 
> "deprecated, but some programs may still depend on it".  So I disabled it to 
> see what broke.  udev complained about the missing /proc/sys/kernel/hotplug,
> but was happy to use /sys/kernel/uevent_helper instead.  I didn't
> notice other problems, so I left things like that.

Well if anything it is the other way around.  The preferred interface to
sysctls is /proc/sys.  There is the whole thing where people aren't to
happy with non-process related things in /proc, so in that sense there
is a bit of deprecation, but /proc and /proc/sys are fully supported.

The plethora of configuration is what remains when I dug into the binary
sys_sysctl interface and tested the assertion that no one uses it, and
it has been deprecated for years and we could just kill it.

We can now remove the binary sys_sysctl syscall while keeping /proc/sys
support.  Someday I might even get ambitious and add the appropriate
deprecated warnings so we can kill the binary interface.

I got as far as seeing that there were a small handful of real
programs that use sys_sysctl.  I looked at how were giving notice
and realized that was insufficient to tell users we were deprecating
the thing.  I didn't see much point (except being able to immediate
drop support) to removing sys_sysctl and since we would have to go
a couple of years still supporting it to remove it properly I got
lazy and stopped.

Maybe myself or someone else can get ambitious and deprecate
sys_sysctl properly and we can remove it one of these years...

Eric

^ permalink raw reply	[flat|nested] 29+ messages in thread

end of thread, other threads:[~2007-03-31  6:55 UTC | newest]

Thread overview: 29+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-03-27  5:16 2.6.21-rc5-mm2 Andrew Morton
2007-03-27 10:04 ` 2.6.21-rc5-mm2 William Lee Irwin III
2007-03-28 17:02 ` 2.6.21-rc5-mm2 Andreas Mohr
2007-03-28 17:33   ` 2.6.21-rc5-mm2 Andreas Mohr
2007-03-28 17:45     ` 2.6.21-rc5-mm2 Andreas Mohr
2007-03-28 18:04       ` tty OOPS (Re: 2.6.21-rc5-mm2) Andreas Mohr
2007-03-28 18:38         ` Alexey Dobriyan
2007-03-28 18:56           ` Alexey Dobriyan
2007-03-28 20:07             ` Andrew Morton
2007-03-29 12:48               ` Maneesh Soni
2007-03-28 20:15             ` [FIXED] " Andreas Mohr
2007-03-28 21:08               ` Ethan Solomita
2007-03-28 21:27               ` Ethan Solomita
2007-03-28 17:42 ` 2.6.21-rc5-mm2 Christian
2007-03-28 17:55   ` 2.6.21-rc5-mm2 Pallipadi, Venkatesh
2007-03-28 18:36 ` 2.6.21-rc5-mm2 Badari Pulavarty
2007-03-28 20:20 ` 2.6.21-rc5-mm2 OOPS and spinlock lockup Zan Lynx
2007-03-28 20:50   ` Andrew Morton
2007-03-29 17:53 ` 2.6.21-rc5-mm2 Badari Pulavarty
2007-03-29 17:23   ` 2.6.21-rc5-mm2 Andrew Morton
2007-03-29 18:20 ` 2.6.21-rc5-mm2 - compile error on x86-64 Helge Hafting
2007-03-29 21:28   ` Andrew Morton
2007-03-29 22:10     ` Eric W. Biederman
2007-03-29 22:23       ` Andrew Morton
2007-03-30  5:10         ` Eric W. Biederman
2007-03-29 22:24       ` Randy Dunlap
2007-03-31  6:27     ` Helge Hafting
2007-03-31  6:53       ` Eric W. Biederman
2007-03-31  6:50     ` Helge Hafting

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).