LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: syrjala@sci.fi
To: "Antonino A. Daplas" <adaplas@gmail.com>
Cc: Adrian Bunk <bunk@stusta.de>, Richard Purdie <rpurdie@rpsys.net>,
	linux-kernel@vger.kernel.org
Subject: Re: drivers/video/aty/atyfb_base.c: array overruns
Date: Sat, 31 Mar 2007 17:25:14 +0300	[thread overview]
Message-ID: <20070331142514.GA21030@sci.fi> (raw)
In-Reply-To: <1175304210.4663.2.camel@daplas>

On Sat, Mar 31, 2007 at 09:23:29AM +0800, Antonino A. Daplas wrote:
> On Mon, 2007-03-19 at 10:22 +0100, Adrian Bunk wrote:
> > The Coverity checker spotted the following two array overruns in 
> > drivers/video/aty/atyfb_base.c:
> > 
> > <--  snip  -->
> > 
> > ...
> > static const u32 lt_lcd_regs[] = {
> >         CONFIG_PANEL_LG,
> >         LCD_GEN_CNTL_LG,
> >         DSTN_CONTROL_LG,
> >         HFB_PITCH_ADDR_LG,
> >         HORZ_STRETCHING_LG,
> >         VERT_STRETCHING_LG,
> >         0, /* EXT_VERT_STRETCH */
> >         LT_GIO_LG,
> >         POWER_MANAGEMENT_LG
> > };
> 
> We can pad this array with zeroes, as a stop-gap measure. Ville, what do
> you think?

Actually this array overrun can never happen. LCD_MISC_CNTL is accessed
in the in the pmac backlight code and the backlight device is not
registered for the Rage LT chip (only user of lt_lcd_regs[]).

> > 
> > void aty_st_lcd(int index, u32 val, const struct atyfb_par *par)
> > {
> >         if (M64_HAS(LT_LCD_REGS)) {
> >                 aty_st_le32(lt_lcd_regs[index], val, par);
> > ...
> > }
> > ...
> > u32 aty_ld_lcd(int index, const struct atyfb_par *par)
> > {
> >         if (M64_HAS(LT_LCD_REGS)) {
> >                 return aty_ld_le32(lt_lcd_regs[index], par);
> > ...
> > }
> > ...
> > static int aty_bl_update_status(struct backlight_device *bd)
> > {
> >         struct atyfb_par *par = class_get_devdata(&bd->class_dev);
> >         unsigned int reg = aty_ld_lcd(LCD_MISC_CNTL, par);
> > ...
> >         aty_st_lcd(LCD_MISC_CNTL, reg, par);
> > 
> >         return 0;
> > }
> > ...
> > 
> > <--  snip  -->
> > 
> > LCD_MISC_CNTL = 0x14 = 20 > 8
> > 
> > cu
> > Adrian
> > 
> 

-- 
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/

      reply	other threads:[~2007-03-31 14:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-19  9:22 Adrian Bunk
2007-03-31  1:23 ` Antonino A. Daplas
2007-03-31 14:25   ` syrjala [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070331142514.GA21030@sci.fi \
    --to=syrjala@sci.fi \
    --cc=adaplas@gmail.com \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    --subject='Re: drivers/video/aty/atyfb_base.c: array overruns' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).