LKML Archive on
help / color / mirror / Atom feed
From: Adrian Bunk <>
To: Andrew Morton <>
Cc: "Rafael J. Wysocki" <>,
	LKML <>,
	Tigran Aivazian <>,
	Pavel Machek <>, Maxim <>
Subject: Re: [PATCH] Fix microcode-related suspend problem
Date: Sat, 31 Mar 2007 23:23:37 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sat, Mar 31, 2007 at 01:35:32PM -0700, Andrew Morton wrote:
> On Sat, 31 Mar 2007 22:04:15 +0200 "Rafael J. Wysocki" <> wrote:
> > This patch appeard on LMKL six days ago and there have not been any negative
> > comments since then, so I think I can try to make it official.
> > 
> > ---
> > From: Rafael J. Wysocki <>
> > 
> > Fix the regression resulting from the recent change of suspend code ordering
> > that causes systems based on Intel x86 CPUs using the microcode driver to
> > hang during the resume.
> > 
> > The problem occurs since the microcode driver uses request_firmware() in its
> > CPU hotplug notifier, which is called after tasks has been frozen and hangs.
> > It can be fixed by telling the microcode driver to use the microcode stored in
> > memory during the resume instead of trying to load it from disk.
> arch/i386/kernel/microcode.c: In function 'microcode_init_cpu':
> arch/i386/kernel/microcode.c:628: error: 'suspend_cpu_hotplug' undeclared (first use in this function)
> arch/i386/kernel/microcode.c:628: error: (Each undeclared identifier is reported only once
> arch/i386/kernel/microcode.c:628: error: for each function it appears in.)
> arch/i386/kernel/microcode.c: In function 'mc_sysdev_add':
> arch/i386/kernel/microcode.c:717: error: 'suspend_cpu_hotplug' undeclared (first use in this function)
> arch/i386/kernel/microcode.c: In function 'mc_sysdev_remove':
> arch/i386/kernel/microcode.c:745: error: 'suspend_cpu_hotplug' undeclared (first use in this function)
> Given this, and the overall intrusiveness of the change, I'd worry about
> trying to get this into 2.6.21.

It fixes a regression, and we are still at least one month away from the 
release of 2.6.21.

2.6.20 was released with too many known regressions [1], let's not 
repeat this mistake with 2.6.21.


[1] at least the CONFIG_USB_SUSPEND powerdown regression and the
    pktcdvd+libata not working regression shouldn't have been in
    a released kernel


       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

  parent reply	other threads:[~2007-03-31 21:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-31 20:04 Rafael J. Wysocki
2007-03-31 20:35 ` Andrew Morton
2007-03-31 20:52   ` Rafael J. Wysocki
2007-03-31 21:23   ` Adrian Bunk [this message]
2007-03-31 23:26     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] Fix microcode-related suspend problem' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).