LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: tglx@linutronix.de, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Deprecate SA_xxx interrupt flags -V2
Date: Fri, 6 Apr 2007 21:29:37 +0200 [thread overview]
Message-ID: <20070406192937.GA19093@elte.hu> (raw)
In-Reply-To: <20070406122228.3dc06c79.akpm@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> wrote:
> Yeah. I tried something like this and code broke. For example,
> arch/mips/sni/irq.c has
>
> struct irqaction sni_isa_irq = {
> .handler = sni_isa_irq_handler,
> .name = "ISA",
> .flags = SA_SHIRQ
> };
>
> there are presumably only a few such stragglers left in the tree but
> there are probably more instances out-of-tree.
i quick grep suggests that this seems to be the only one left with a
similar pattern:
dione:~/linux/ find . -name '*.[ch]' | xargs grep -E '\..*=.*\<SA_' |
grep -vE '\;|\(|=='
./arch/mips/sni/irq.c: .flags = SA_SHIRQ
so the patch is fine to me:
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
next prev parent reply other threads:[~2007-04-06 19:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-14 8:33 [patch 0/3] Scheduled removal of SA_xxx interrupt flags Thomas Gleixner
2007-01-14 8:33 ` [patch 1/3] " Thomas Gleixner
2007-01-23 20:02 ` Andrew Morton
2007-01-23 20:31 ` Thomas Gleixner
2007-04-06 13:49 ` [PATCH] Deprecate SA_xxx interrupt flags -V2 Thomas Gleixner
2007-04-06 19:22 ` Andrew Morton
2007-04-06 19:29 ` Ingo Molnar [this message]
2007-04-06 19:36 ` Thomas Gleixner
2007-04-06 20:03 ` [PATCH] Replace deprecated SA_xxx interrupt flags Thomas Gleixner
2007-04-06 20:08 ` [PATCH-mm] Replace more " Thomas Gleixner
2007-01-14 8:33 ` [patch 2/3] Scheduled removal of SA_xxx interrupt flags fixups Thomas Gleixner
2007-01-14 12:42 ` Ingo Molnar
2007-01-14 14:25 ` Thomas Gleixner
2007-01-14 14:25 ` Ingo Molnar
2007-01-14 8:33 ` [patch-mm 3/3] Scheduled removal of SA_xxx interrupt flags fixups 2 (mm) Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070406192937.GA19093@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--subject='Re: [PATCH] Deprecate SA_xxx interrupt flags -V2' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).