LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Jordan Crouse" <jordan.crouse@amd.com>
To: "Jean Delvare" <khali@linux-fr.org>
Cc: "Lennart Sorensen" <lsorense@csclub.uwaterloo.ca>,
	"Haavard Skinnemoen" <hskinnemoen@atmel.com>,
	"David Brownell" <david-b@pacbell.net>,
	"Bryan Wu" <bryan.wu@analog.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Deepak Saxena" <dsaxena@plexity.net>,
	linux-kernel@vger.kernel.org,
	"Christer Weinigel" <wingel@nano-system.com>
Subject: Re: Bitbanging i2c bus driver using the GPIO API
Date: Thu, 19 Apr 2007 08:27:46 -0600	[thread overview]
Message-ID: <20070419142746.GF11323@cosmic.amd.com> (raw)
In-Reply-To: <20070419085413.1520feef@hyperion.delvare>

On 19/04/07 08:54 +0200, Jean Delvare wrote:
> Hi Len,
> 
> On Wed, 18 Apr 2007 13:42:56 -0400, Lennart Sorensen wrote:
> > On Sat, Apr 14, 2007 at 07:28:07PM +0200, Jean Delvare wrote:
> > > Otherwise it looks OK to me, I take the patch. If others have comments
> > > or objections, just speak up and submit incremental patches as needed.
> > > 
> > > Now I would like to see platform code actually using this.
> > 
> > Any idea how similar this new driver is to the scx200_i2c driver?  As
> > far as I can tell that driver is already a bit banged i2c over gpio
> > lines.
> 
> The major difference is that the implementation in scx200_i2c is
> hardware-specific, while the i2c-gpio driver is a generic one, so it's
> a lot better.
> 
> What this means is that i2c-gpio obsoletes scx200_i2c, so I am inclined
> to delete scx200_i2c right away. I'm not even sure anyone still uses it
> now that scx200_acb has been fixed and is reported to work very well.
> If anyone really needs to do I2C over GPIO pins on SCx200, this should
> be reimplemented on top of i2c-gpio.

It would also force us to move the Geode GPIO pins to the generic 
infrastructure, so that would be good.  I say delete it - if anybody needs
that functionality, then we'll do it the right way.

Jordan



  reply	other threads:[~2007-04-19 14:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-14 12:56 [PATCH v3] " Haavard Skinnemoen
2007-04-14 14:34 ` Haavard Skinnemoen
2007-04-14 17:28   ` Jean Delvare
2007-04-18 17:42     ` Lennart Sorensen
2007-04-19  6:54       ` Jean Delvare
2007-04-19 14:27         ` Jordan Crouse [this message]
2007-04-19 20:59         ` Lennart Sorensen
2007-04-20 17:49           ` Jean Delvare
2007-04-22 15:41             ` Lennart Sorensen
2007-04-22 23:41               ` Jordan Crouse
2007-04-23  9:42               ` [PATCH v3] " Jean Delvare
2007-04-23 14:47                 ` Jordan Crouse
2007-04-26 12:56                   ` Jean Delvare
2007-04-26 13:29                     ` Lennart Sorensen
2007-04-26 13:39                       ` Jordan Crouse
2007-04-26 14:03                         ` Lennart Sorensen
2007-04-27  8:02                           ` Jean Delvare
2007-04-27 14:19                             ` Lennart Sorensen
2007-04-27 14:49                             ` Jordan Crouse
2007-04-27 18:53                               ` Lennart Sorensen
2007-05-06  9:24                                 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070419142746.GF11323@cosmic.amd.com \
    --to=jordan.crouse@amd.com \
    --cc=akpm@linux-foundation.org \
    --cc=bryan.wu@analog.com \
    --cc=david-b@pacbell.net \
    --cc=dsaxena@plexity.net \
    --cc=hskinnemoen@atmel.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lsorense@csclub.uwaterloo.ca \
    --cc=wingel@nano-system.com \
    --subject='Re: Bitbanging i2c bus driver using the GPIO API' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).