LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Satyam Sharma" <satyam.sharma@gmail.com>
Cc: "Tilman Schmidt" <tilman@imap.cc>,
	"David Miller" <davem@davemloft.net>,
	linux-kernel@vger.kernel.org, kkeil@suse.de,
	i4ldeveloper@listserv.isdn4linux.de, akpm@linux-foundation.org
Subject: Re: [PATCH] Remove "obsolete" label from ISDN4Linux (v3)
Date: Sun, 22 Apr 2007 17:20:17 +0100	[thread overview]
Message-ID: <20070422172017.52f21a90@the-village.bc.nu> (raw)
In-Reply-To: <a781481a0704220848t16cc8ed2l3cb5ee52d9b405e1@mail.gmail.com>

> simple and fundamental (which you haven't answered as yet). Why, or
> rather how, were the writers of newer APIs _allowed_ to push *their*
> stuff into the kernel _without_ even bothering to convert the
> *existing* users of the older APIs in the kernel? This goes against

Because to convert the existing ISDN4Linux heap into the new APIs would
require someone with all the cards involved and a lot of time (as the
card drivers need a *lot* of work by now to bring them up to todays work)

> the spirit of pretty much how anything is done in here ... one can't
> really find fault with the original author of I4L for not using APIs
> that didn't even exist when he wrote I4L.

Of course not - and I4L as originally merged is very different to I4L as
it is now - both because it was maintained and because other people fixed
things when it was easy to do so (eg the tty layer changes).

> and working kernel subsystem to their newer APIs. If we allow
> something like this (or if this was allowed in the past), then we
> could be setting a very unfortunate precedent.

"Precedent", that implies it is a new behaviour - which it isn't. We
regularly break old driver code when it is neccessary in order to make
general progress. Grep for "BROKEN" in the kernel tree.

> I really don't have any specific knowledge of the I4L codebase, so
> perhaps you and Dave do have better reasons to keep it marked as
> obsolete (and *allow* it get broken by API changes in the future).

If the changes to make it use pci_get_ were trivial I'd simply have
pushed them, but they are not due to the rather bizarre structure of some
of the drivers - ditto some of the other changes.

You, and anyone else who wants to, are free to work on I4L and fix it,
improve it and make it better. 

Alan

  reply	other threads:[~2007-04-22 16:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-15 11:43 any value to fixing apparent bugs in old ISDN4Linux? Robert P. J. Day
2007-01-15 13:57 ` Karsten Keil
2007-01-15 17:09 ` Tilman Schmidt
2007-01-15 17:17   ` Robert P. J. Day
2007-01-15 17:29     ` Karsten Keil
2007-02-21  0:29       ` [PATCH] Remove "obsolete" label from ISDN4Linux (was: any value to fixing apparent bugs in old ISDN4Linux?) Tilman Schmidt
2007-03-28 22:18       ` [Repost][PATCH] Remove "obsolete" label from ISDN4Linux Tilman Schmidt
2007-04-21 13:07       ` [PATCH] Remove "obsolete" label from ISDN4Linux (v3) Tilman Schmidt
2007-04-21 20:58         ` Alan Cox
2007-04-21 22:10           ` David Miller
2007-04-22 12:27             ` Tilman Schmidt
2007-04-22 12:58               ` Alan Cox
2007-04-22 14:29                 ` Tilman Schmidt
2007-04-22 15:17                   ` Alan Cox
2007-04-22 15:48                     ` Satyam Sharma
2007-04-22 16:20                       ` Alan Cox [this message]
2007-04-23 23:58                         ` Tilman Schmidt
2007-05-28 16:32       ` [PATCH] ISDN4Linux: fix maturity label (v4) Tilman Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070422172017.52f21a90@the-village.bc.nu \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=i4ldeveloper@listserv.isdn4linux.de \
    --cc=kkeil@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=satyam.sharma@gmail.com \
    --cc=tilman@imap.cc \
    --subject='Re: [PATCH] Remove "obsolete" label from ISDN4Linux (v3)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).