W1 printk format warning

W1 printk format warning

[Randy Dunlap]

in 2.6.21-rc7-mm1.  Are you aware of this?

drivers/w1/w1.c:460: warning: too few arguments for format

	dev_dbg(&sl->dev, "%s: registering %s as %p.\n", __func__,
		&sl->dev.bus_id[0]);

Thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: W1 printk format warning

[Andrew Morton]

On Wed, 25 Apr 2007 16:21:04 -0700 Randy Dunlap <randy.dunlap@oracle.com> wrote:

> in 2.6.21-rc7-mm1.  Are you aware of this?
> 
> drivers/w1/w1.c:460: warning: too few arguments for format
> 
> 	dev_dbg(&sl->dev, "%s: registering %s as %p.\n", __func__,
> 		&sl->dev.bus_id[0]);
> 

Yeah, that's because Dan's dev_dbg-check-dev_dbg-arguments.patch added
printk arg-checking to dev_dbg() and a bunch of bugs got exposed.  I fixed
a few of them.

Incidentally, there are at least four different drivers which privately do
things like:

#if !defined(DEBUG)
#undef dev_dbg
static inline int __attribute__ ((format (printf, 2, 3))) dev_dbg(
	const struct device *_dev, const char *fmt, ...) {return 0;}
#endif

which can all be removed with Dan's (good) patch in place.

Re: W1 printk format warning

[Evgeniy Polyakov]

On Wed, Apr 25, 2007 at 04:45:09PM -0700, Andrew Morton (akpm@linux-foundation.org) wrote:
> On Wed, 25 Apr 2007 16:21:04 -0700 Randy Dunlap <randy.dunlap@oracle.com> wrote:
> 
> > in 2.6.21-rc7-mm1.  Are you aware of this?
> > 
> > drivers/w1/w1.c:460: warning: too few arguments for format
> > 
> > 	dev_dbg(&sl->dev, "%s: registering %s as %p.\n", __func__,
> > 		&sl->dev.bus_id[0]);
> > 
> 
> Yeah, that's because Dan's dev_dbg-check-dev_dbg-arguments.patch added
> printk arg-checking to dev_dbg() and a bunch of bugs got exposed.  I fixed
> a few of them.

Could you post a full list for w1, if there is only one, here is a fix.

Thanks a lot, Randy.

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 63c0724..7d6876d 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -459,7 +459,7 @@ static int __w1_attach_slave_device(struct w1_slave *sl)
 		 (unsigned long long) sl->reg_num.id);
 
 	dev_dbg(&sl->dev, "%s: registering %s as %p.\n", __func__,
-		&sl->dev.bus_id[0]);
+		&sl->dev.bus_id[0], sl);
 
 	err = device_register(&sl->dev);
 	if (err < 0) {
-- 
	Evgeniy Polyakov

Re: W1 printk format warning

[Andrew Morton]

On Thu, 26 Apr 2007 22:17:44 +0400 Evgeniy Polyakov <johnpol@2ka.mipt.ru> wrote:

> On Wed, Apr 25, 2007 at 04:45:09PM -0700, Andrew Morton (akpm@linux-foundation.org) wrote:
> > On Wed, 25 Apr 2007 16:21:04 -0700 Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > 
> > > in 2.6.21-rc7-mm1.  Are you aware of this?
> > > 
> > > drivers/w1/w1.c:460: warning: too few arguments for format
> > > 
> > > 	dev_dbg(&sl->dev, "%s: registering %s as %p.\n", __func__,
> > > 		&sl->dev.bus_id[0]);
> > > 
> > 
> > Yeah, that's because Dan's dev_dbg-check-dev_dbg-arguments.patch added
> > printk arg-checking to dev_dbg() and a bunch of bugs got exposed.  I fixed
> > a few of them.
> 
> Could you post a full list for w1, if there is only one, here is a fix.
> 

There's only the one in w1, I think.  I fixed a few more but I didn't
actually go looking for more such errors.

RE: W1 printk format warning

[Williams, Dan J]

> From: Andrew Morton [mailto:akpm@linux-foundation.org]
> On Thu, 26 Apr 2007 22:17:44 +0400 Evgeniy Polyakov
<johnpol@2ka.mipt.ru>
> wrote:
> 
> > On Wed, Apr 25, 2007 at 04:45:09PM -0700, Andrew Morton (akpm@linux-
> foundation.org) wrote:
> > > On Wed, 25 Apr 2007 16:21:04 -0700 Randy Dunlap
<randy.dunlap@oracle.com>
> wrote:
> > >
> > > > in 2.6.21-rc7-mm1.  Are you aware of this?
> > > >
> > > > drivers/w1/w1.c:460: warning: too few arguments for format
> > > >
> > > > 	dev_dbg(&sl->dev, "%s: registering %s as %p.\n",
__func__,
> > > > 		&sl->dev.bus_id[0]);
> > > >
> > >
> > > Yeah, that's because Dan's dev_dbg-check-dev_dbg-arguments.patch
added
> > > printk arg-checking to dev_dbg() and a bunch of bugs got exposed.
I fixed
> > > a few of them.
> >
> > Could you post a full list for w1, if there is only one, here is a
fix.
> >
> 
> There's only the one in w1, I think.  I fixed a few more but I didn't
> actually go looking for more such errors.

Feel free to bug me if there is more fallout that is not otherwise
picked up...

--
Dan