From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755969AbXD0PBP (ORCPT ); Fri, 27 Apr 2007 11:01:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755968AbXD0PBP (ORCPT ); Fri, 27 Apr 2007 11:01:15 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:36538 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755930AbXD0PBN (ORCPT ); Fri, 27 Apr 2007 11:01:13 -0400 Date: Fri, 27 Apr 2007 17:01:24 +0200 From: Adrian Bunk To: "Robert P. J. Day" Cc: James Bottomley , Andrew Morton , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Yokota Hiroshi , GOTO Masanori Subject: Re: [2.6 patch] drivers/scsi/nsp32.c: remove kernel 2.4 code Message-ID: <20070427150124.GU3468@stusta.de> References: <20070426234742.GH3468@stusta.de> <20070427001324.GP3468@stusta.de> <1177633855.5532.8.camel@mulgrave.il.steeleye.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 27, 2007 at 10:55:54AM -0400, Robert P. J. Day wrote: > On Thu, 26 Apr 2007, James Bottomley wrote: > > > Personally, I don't like to see 2.4 and 2.6 in a new driver, and > > will tend to try to force it to be 2.6 only. For an existing > > driver, I tend to be much more tolerant: removing the huge gobs of > > code to achieve 2.6 only is usually a bit disruptive on both the > > driver and the maintainer > > > > > But if a driver is no longer actually maintained for both kernels > > > these checks become useless (and there quickly arised > > > unconditional 2.6-only code in such a driver) and can be removed. > > > > This driver is maintained by > > > > Yokota Hiroshi > > GOTO Masanori > > > > As it says in the header. It was last modified in May 2006, so it > > is maintained under the somewhat elastic standards of SCSI. I've > > cc'd them to see what they think. > > while we're on the subject, what's the policy on supporting kernel > version selection *within* the 2.5 series? as in: > > $ grep -r "KERNEL_VERSION(2,5" * > drivers/scsi/pcmcia/nsp_cs.h:#if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,5,74)) > drivers/scsi/pcmcia/nsp_cs.c:#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)) > drivers/scsi/pcmcia/nsp_cs.c:#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,5,2)) > drivers/scsi/pcmcia/nsp_cs.c:#if (LINUX_VERSION_CODE > KERNEL_VERSION(2,5,73)) > ... etc etc ... > > granted, this doesn't happen in a lot of files (almost of them > SCSI-related), but is it official policy to support code based on its > release number in the 2.5 series of releases? unless you have a good > reason, wouldn't it make more sense to compare against (2,6,0) rather > than, say, (2,5,73)? just an observation. Besides the fact that I sent a patch to remove the compat code from this driver, it simply doesn't matter whether to compare with (2,5,73) or (2,6,0), so there's no reason for changing it. > rday cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed