LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: jwboyer@linux.vnet.ibm.com, grant.likely@secretlab.ca,
akpm <akpm@linux-foundation.org>,
jketreno@linux.intel.com
Subject: [PATCH] lib/hexdump
Date: Wed, 2 May 2007 15:35:56 -0700 [thread overview]
Message-ID: <20070502153556.3c995de7.randy.dunlap@oracle.com> (raw)
From: Randy Dunlap <randy.dunlap@oracle.com>
Based on ace_dump_mem() from Grant Likely for the Xilinx
SystemACE CompactFlash interface.
Add hex_dumper() to lib/hexdump.c and linux/kernel.h.
This patch adds the function 'hex_dumper' which can be used to perform a
hex + ASCII dump of data to syslog, in an easily viewable format, thus
providing a common text hex dump format.
It does not provide a hexdump_to_buffer() function.
if someone needs that, we'll have to add it.
Example usage:
hex_dumper(KERN_DEBUG, data, length);
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
include/linux/kernel.h | 1
lib/Makefile | 2 -
lib/hexdump.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 53 insertions(+), 1 deletion(-)
--- linux-2.6.21-git4.orig/include/linux/kernel.h
+++ linux-2.6.21-git4/include/linux/kernel.h
@@ -201,6 +201,7 @@ extern enum system_states {
#define TAINT_USER (1<<6)
extern void dump_stack(void);
+extern void hex_dumper(const char *level, void *base, int len);
#ifdef DEBUG
/* If you are writing a driver, please use dev_dbg instead */
--- linux-2.6.21-git4.orig/lib/Makefile
+++ linux-2.6.21-git4/lib/Makefile
@@ -5,7 +5,7 @@
lib-y := ctype.o string.o vsprintf.o cmdline.o \
rbtree.o radix-tree.o dump_stack.o \
idr.o int_sqrt.o bitmap.o extable.o prio_tree.o \
- sha1.o irq_regs.o reciprocal_div.o
+ sha1.o irq_regs.o reciprocal_div.o hexdump.o
lib-$(CONFIG_MMU) += ioremap.o
lib-$(CONFIG_SMP) += cpumask.o
--- /dev/null
+++ linux-2.6.21-git4/lib/hexdump.c
@@ -0,0 +1,51 @@
+/*
+ * lib/hexdump.c
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation. See README and COPYING for
+ * more details.
+ */
+
+#include <linux/types.h>
+#include <linux/ctype.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+
+/**
+ * hex_dumper - print a text hex dump to syslog for a binary blob of data
+ * @level: kernel log level (e.g. KERN_DEBUG)
+ * @buf: data blob to dump
+ * @len: number of bytes in the @buf
+ *
+ * Given a buffer of u8 data, hex_dumper() will print a hex + ASCII dump
+ * to the kernel log at the specified kernel log level.
+ *
+ * E.g.:
+ * hex_dumper(KERN_DEBUG, frame->data, frame->len);
+ *
+ * Prints the offsets of the block of memory, not addresses:
+ * 0009ab42: 40414243 44454647 48494a4b 4c4d4e4f-@ABCDEFG HIJKLMNO
+ */
+void hex_dumper(const char *level, void *base, int len)
+{
+ const u8 *ptr = base;
+ int i, j;
+
+ for (i = 0; i < len; i += 16) {
+ printk("%s%.8x:", level, i);
+ for (j = 0; (j < 16) && (i + j) < len; j++) {
+ if (!(j % 4))
+ printk(" ");
+ printk("%.2x", ptr[i + j]);
+ }
+ printk("-");
+ for (j = 0; (j < 16) && (i + j) < len; j++) {
+ printk("%c", isprint(ptr[i + j]) ? ptr[i + j] : '.');
+ if (j == 7)
+ printk(" ");
+ }
+ printk("\n");
+ }
+}
+EXPORT_SYMBOL(hex_dumper);
next reply other threads:[~2007-05-02 22:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 22:35 Randy Dunlap [this message]
2007-05-02 22:45 ` Andrew Morton
2007-05-02 22:56 ` Randy Dunlap
2007-05-02 23:06 ` Andrew Morton
2007-05-02 23:15 ` Randy Dunlap
2007-05-04 0:49 ` [PATCH v2] lib/hexdump Randy Dunlap
2007-05-04 9:39 ` Pekka Enberg
2007-05-04 18:22 ` [PATCH v2] lib/hexdump update on feedback Randy Dunlap
2007-05-04 13:41 ` [PATCH v2] lib/hexdump Hugh Dickins
2007-05-03 7:01 ` [PATCH] lib/hexdump Jan Engelhardt
2007-05-03 16:26 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070502153556.3c995de7.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=grant.likely@secretlab.ca \
--cc=jketreno@linux.intel.com \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH] lib/hexdump' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).