LKML Archive on
help / color / mirror / Atom feed
From: Matthias Kaehlcke <>
To: Andrew Morton <>
Subject: Re: [PATCH 1/5] Power Management: use mutexes instead of semaphores
Date: Fri, 4 May 2007 09:08:40 +0200	[thread overview]
Message-ID: <20070504070840.GD3234@traven> (raw)
In-Reply-To: <>

El Thu, May 03, 2007 at 10:54:32PM -0700 Andrew Morton ha dit:

> On Fri, 27 Apr 2007 10:43:22 +0200 Matthias Kaehlcke <> wrote:
> > the Power Management code uses semaphores as mutexes. use the mutex
> > API instead of the (binary) semaphores
> I know it's a little thing, but given a choice between
> a) changelogs which use capital letters and fullstops and
> b) changelogs which do not,
> I think a) gives a better result.

thanks for your suggestion, i'll take it into account for future patches
> I note that none of these patches added a #include <linux/mutex.h>.  Each C
> file which uses mutexes should do that, rather than relying upon accidental
> nested includes.  I hope you're checking for that.

initially i added the include line (i think at least one patch still
contains it), but then i realized that in most cases the original code
doesn't include semaphore.h and i (mis-)interpreted that it should be
handled the same way (relying upon nested includes) for mutexes. 

do you want me to send you a version of the patches containing the


Matthias Kaehlcke
Linux Application Developer

      The assumption that what currently exists must necessarily
        exist is the acid that corrodes all visionary thinking
    using free software / Debian GNU/Linux |  : :'  :
                                                                `. `'`
gpg --keyserver --recv-keys 47D8E5D4                  `-

  reply	other threads:[~2007-05-04  7:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-27  8:38 [PATCH 0/5] use mutex instead of semaphore in several drivers Matthias Kaehlcke
2007-04-27  8:43 ` [PATCH 1/5] Power Management: use mutexes instead of semaphores Matthias Kaehlcke
2007-04-28 10:42   ` Pavel Machek
2007-05-04  5:54   ` Andrew Morton
2007-05-04  7:08     ` Matthias Kaehlcke [this message]
2007-05-04  7:18       ` Andrew Morton
2007-04-27  8:45 ` [PATCH 2/5] Kcopyd: use mutex instead of semaphore Matthias Kaehlcke
2007-04-27  8:48 ` [PATCH 3/5] sysdev: " Matthias Kaehlcke
2007-04-27  8:50 ` [PATCH 4/5] pvrusb2: " Matthias Kaehlcke
2007-04-27 13:55   ` Mike Isely
2007-04-27  8:52 ` [PATCH 5/5] scx200: " Matthias Kaehlcke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070504070840.GD3234@traven \ \ \ \ \
    --subject='Re: [PATCH 1/5] Power Management: use mutexes instead of semaphores' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).