LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Reboot PATCH (ACPI related)
@ 2007-05-12 20:10 Lukas Hejtmanek
  2007-05-13  6:44 ` Andrew Morton
  0 siblings, 1 reply; 3+ messages in thread
From: Lukas Hejtmanek @ 2007-05-12 20:10 UTC (permalink / raw)
  To: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 139 bytes --]

Hello,

why the attached patch is still not included in mainline kernel? It fixes boot
problems after suspend to RAM.

-- 
Lukáš Hejtmánek

[-- Attachment #2: reboot.patch --]
[-- Type: text/x-diff, Size: 563 bytes --]

--- arch/i386/kernel/reboot.c.old	2006-06-18 03:49:35.000000000 +0200
+++ arch/i386/kernel/reboot.c	2006-07-01 17:29:23.000000000 +0200
@@ -31,6 +31,12 @@
 #ifdef CONFIG_SMP
 static int reboot_cpu = -1;
 #endif
+#ifdef CONFIG_ACPI
+extern u32 acpi_disable(void);
+#else
+static u32 acpi_disable(void){};
+#endif
+
 static int __init reboot_setup(char *str)
 {
 	while(1) {
@@ -322,6 +328,7 @@
 
 void machine_emergency_restart(void)
 {
+	acpi_disable();
 	if (!reboot_thru_bios) {
 		if (efi_enabled) {
 			efi.reset_system(EFI_RESET_COLD, EFI_SUCCESS, 0, NULL);

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Reboot PATCH (ACPI related)
  2007-05-12 20:10 Reboot PATCH (ACPI related) Lukas Hejtmanek
@ 2007-05-13  6:44 ` Andrew Morton
  2007-05-14 11:57   ` Lukas Hejtmanek
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2007-05-13  6:44 UTC (permalink / raw)
  To: Lukas Hejtmanek; +Cc: linux-kernel, linux-acpi

On Sat, 12 May 2007 22:10:07 +0200 Lukas Hejtmanek <xhejtman@ics.muni.cz> wrote:

> why the attached patch is still not included in mainline kernel? It fixes boot
> problems after suspend to RAM.
> 
> -- 
> Lukáš Hejtmánek
> 
> 
> [reboot.patch  text/x-diff (564B)]
> --- arch/i386/kernel/reboot.c.old	2006-06-18 03:49:35.000000000 +0200
> +++ arch/i386/kernel/reboot.c	2006-07-01 17:29:23.000000000 +0200
> @@ -31,6 +31,12 @@
>  #ifdef CONFIG_SMP
>  static int reboot_cpu = -1;
>  #endif
> +#ifdef CONFIG_ACPI
> +extern u32 acpi_disable(void);
> +#else
> +static u32 acpi_disable(void){};
> +#endif
> +
>  static int __init reboot_setup(char *str)
>  {
>  	while(1) {
> @@ -322,6 +328,7 @@
>  
>  void machine_emergency_restart(void)
>  {
> +	acpi_disable();
>  	if (!reboot_thru_bios) {
>  		if (efi_enabled) {
>  			efi.reset_system(EFI_RESET_COLD, EFI_SUCCESS, 0, NULL);

We'd prefer to fix the problem, whatever it is, rather than just turning
APCI off.

Please ensure that a full bug report has been entered at bugzilla.kernel.org,
thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Reboot PATCH (ACPI related)
  2007-05-13  6:44 ` Andrew Morton
@ 2007-05-14 11:57   ` Lukas Hejtmanek
  0 siblings, 0 replies; 3+ messages in thread
From: Lukas Hejtmanek @ 2007-05-14 11:57 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, linux-acpi

On Sat, May 12, 2007 at 11:44:13PM -0700, Andrew Morton wrote:
> We'd prefer to fix the problem, whatever it is, rather than just turning
> APCI off.
> 
> Please ensure that a full bug report has been entered at bugzilla.kernel.org,
> thanks.

The patch resulted from the following bug report:
http://bugzilla.kernel.org/show_bug.cgi?id=6655

-- 
Lukáš Hejtmánek

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-05-14 12:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-05-12 20:10 Reboot PATCH (ACPI related) Lukas Hejtmanek
2007-05-13  6:44 ` Andrew Morton
2007-05-14 11:57   ` Lukas Hejtmanek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).