LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Robert Fitzsimons <robfitz@273k.net>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: video4linux@list.redhat.com, Hans Verkuil <hverkuil@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: V4L Regression (Was: Linux 2.6.22-rc1)
Date: Mon, 14 May 2007 08:49:28 +0100	[thread overview]
Message-ID: <20070514074928.GA13702@localhost> (raw)
In-Reply-To: <alpine.LFD.0.98.0705121857100.6739@woody.linux-foundation.org>

Existing v4l applications are failing with the latest release
candidate.

This is xawtv-3.95.dfsg.1, running on Linux/i686 (2.6.22-rc1)
xinerama 0: 1280x1024+0+0
/dev/video0 [v4l2]: ioctl VIDIOC_G_FBUF: Invalid argument
v4l-conf had some trouble, trying to continue anyway
ioctl: VIDIOC_G_FBUF(capability=0x0 [];flags=0x0 [];base=(nil);fmt.width=0;fmt.h
eight=0;fmt.pixelformat=0x00000000 [....];fmt.field=ANY;fmt.bytesperline=0;fmt.s
izeimage=0;fmt.colorspace=unknown;fmt.priv=0): Invalid argument
ioctl: VIDIOC_TRY_FMT(type=VIDEO_OVERLAY;fmt.win.w.left=3;fmt.win.w.top=701;fmt.
win.w.width=384;fmt.win.w.height=288;fmt.win.field=ANY;fmt.win.chromakey=0;fmt.w
in.clips=(nil);fmt.win.clipcount=0;fmt.win.bitmap=(nil)): Invalid argument
ioctl: VIDIOC_S_FMT(type=VIDEO_OVERLAY;fmt.win.w.left=3;fmt.win.w.top=701;fmt.wi
n.w.width=384;fmt.win.w.height=288;fmt.win.field=ANY;fmt.win.chromakey=0;fmt.win
.clips=(nil);fmt.win.clipcount=0;fmt.win.bitmap=(nil)): Invalid argument

After bisecting I tracked the problem down to this commit:

 206ebaf32795cf1582b1e2ff2ec6a560c9e986b8
 V4L/DVB (5272): Add V4L2_CAP_VIDEO_OUTPUT_POS capability
    
 Add V4L2_CAP_VIDEO_OUTPUT_POS capability and x, y position coordinates
 to struct v4l2_pix_format.
 This is needed to support positioning the MPEG/YUV output of the cx23415.
    
 Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
 Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>

This commit changes the ABI by adding two new fields to the existing
struct v4l2_pix_format which is used by the existing VIDIOC_G_FBUF
ioctl.  v4l applications compiled against a previous version of the
kernel will fail in the generic ioctl code due to the size mismatch of
the arguments.

Commenting out the two new fields and recompiling allows the exists
application to work correctly.

Possibly the commit should be reverted or reworked to not change the
ABI?

Robert


  parent reply	other threads:[~2007-05-14  8:13 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-13  3:20 Linux 2.6.22-rc1 Linus Torvalds
2007-05-13  9:20 ` Jan Engelhardt
2007-05-17  6:55   ` Len Brown
2007-05-13  9:29 ` Linux 2.6.22-rc1, 'nother randconfig Jan Engelhardt
2007-05-13  9:47 ` [PATCH] driver core: fix warning of temporarily unused multithreaded probing function (was: Re: Linux 2.6.22-rc1) Borislav Petkov
2007-05-14  8:06   ` Cornelia Huck
2007-05-13 12:44 ` Linux 2.6.22-rc1 Alessandro Suardi
2007-05-13 12:44 ` Indan Zupancic
2007-05-13 17:10 ` Antonino Ingargiola
2007-05-13 17:53   ` Linus Torvalds
2007-05-13 18:50     ` Antonino Ingargiola
2007-05-14  6:10       ` Jean Delvare
2007-05-14  8:34         ` Antonino Ingargiola
2007-05-14 12:14           ` Jean Delvare
2007-05-14 13:28             ` Antonino Ingargiola
2007-05-14 15:21               ` Jean Delvare
2007-05-14 16:04                 ` Antonino Ingargiola
2007-05-14 16:23                   ` Michal Piotrowski
2007-05-14 18:08                   ` Jean Delvare
2007-05-14 18:25                     ` Antonino Ingargiola
2007-05-14 16:30                 ` Linus Torvalds
2007-05-14 18:24                   ` Jean Delvare
2007-05-14 18:43                     ` Linus Torvalds
2007-05-14 19:28                       ` Jean Delvare
2007-05-14 19:53                         ` Jeff Garzik
2007-05-14 20:18                           ` Christoph Hellwig
2007-05-14 20:17                         ` Christoph Hellwig
2007-05-14 20:15                       ` Christoph Hellwig
2007-05-15 20:31             ` CONFIG_BREAK_MY_MACHINE was " Pavel Machek
2007-05-16 18:11               ` CONFIG_BREAK_MY_MACHINE Jean Delvare
2007-05-17  8:32                 ` CONFIG_BREAK_MY_MACHINE Hans de Goede
2007-05-17  8:47                   ` CONFIG_BREAK_MY_MACHINE Pavel Machek
2007-05-13 18:19 ` Linux 2.6.22-rc1 Tilman Schmidt
2007-05-13 23:20   ` David Miller
2007-05-13 23:32     ` Roland Dreier
2007-05-13 23:57     ` Tilman Schmidt
2007-05-14  4:37     ` Sam Ravnborg
2007-05-14  4:53       ` David Miller
2007-05-14  6:21     ` Satyam Sharma
2007-05-14 17:21   ` Jan Engelhardt
2007-05-14 17:32     ` Stefan Richter
2007-05-14 20:27       ` Jan Engelhardt
2007-05-14 18:01     ` Tilman Schmidt
2007-05-14 20:33       ` Jan Engelhardt
2007-05-14 21:40         ` Tilman Schmidt
2007-05-14 22:09           ` Stefan Richter
2007-05-15  3:02             ` Satyam Sharma
2007-05-15  8:08               ` Jan Engelhardt
2007-05-14 21:54         ` Stefan Richter
2007-05-15  2:34         ` Satyam Sharma
2007-05-15  2:42           ` Satyam Sharma
2007-05-15  6:05             ` Stefan Richter
2007-05-15  6:01           ` Stefan Richter
2007-05-15  8:16           ` Jan Engelhardt
2007-05-16  1:52             ` Satyam Sharma
2007-05-16  6:29               ` Stefan Richter
2007-05-16  9:56                 ` Satyam Sharma
2007-05-15 10:43           ` Tilman Schmidt
2007-05-16  1:39             ` Satyam Sharma
2007-05-16  9:14               ` Tilman Schmidt
2007-05-16  9:17                 ` Satyam Sharma
2007-05-15  5:35         ` Michael Gerdau
2007-05-13 20:51 ` 2.6.22-rc1: loop.c Alexey Dobriyan
2007-05-14  3:52   ` Jeremy Fitzhardinge
2007-05-13 22:53 ` Linux 2.6.22-rc1 Jeff Chua
2007-05-14  1:08 ` andrew hendry
2007-05-14  7:49 ` Robert Fitzsimons [this message]
2007-05-14 11:44 ` Linux 2.6.22-rc1, 'nother randconfig David Howells
2007-05-14 17:23   ` Jan Engelhardt
2007-05-15  9:26   ` David Howells
2007-05-15  9:40     ` Jan Engelhardt
2007-05-15  4:14 ` Linux 2.6.22-rc1 andrew hendry
2007-05-15  4:38   ` Linus Torvalds
2007-05-15  5:10     ` andrew hendry
2007-05-15 15:57       ` Linus Torvalds
2007-05-15 22:50         ` andrew hendry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070514074928.GA13702@localhost \
    --to=robfitz@273k.net \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=video4linux@list.redhat.com \
    --subject='Re: V4L Regression (Was: Linux 2.6.22-rc1)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).