LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Hans de Goede <j.w.r.degoede@hhs.nl>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: CONFIG_BREAK_MY_MACHINE
Date: Wed, 16 May 2007 20:11:43 +0200	[thread overview]
Message-ID: <20070516201143.699cff02@hyperion.delvare> (raw)
In-Reply-To: <20070515203059.GI6816@ucw.cz>

On Tue, 15 May 2007 20:31:00 +0000, Pavel Machek wrote:
> Hi!
> 
> > > Hardware Monitoring support  --->
> > >   <*> Hardware Monitoring support
> > >   <*> Abit uGuru
> > >   <M> VIA686A
> > >   <*> IBM Hard Drive Active Protection System (hdaps)
> > > 
> > > But I'm quite sure that the only module used is VIA686A (I'm
> > > rebuilding to confirm).
> > 
> > This is a rather bad idea to build the abituguru and hdaps drivers into
> > your kernel if you don't have these devices. Especially abituguru, as
> > it does arbitrary port probing.
> 
> hdaps should be safe (DMI based whitelist, no?)

Correct.

> If abitguru breaks random machines, we probably should DMI whitelist,
> too.

I never said it was breaking machines, just that it was accessing
arbitrary I/O ports.

This was already discussed with the driver's author (Hans de Goede,
Cc'd) and I think we agreed on the principle, but it didn't happen yet.
This device only exists on Abit motherboards so it would be easy enough
to check the DMI vendor. A more detailed white list is also possible,
but I'm not insisting on it.

The driver could also be made to depend on X86, as this is the only
architecture where it is useful.

Hans, can you please submit a patch doing this?

Thanks,
-- 
Jean Delvare

  reply	other threads:[~2007-05-16 18:11 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-13  3:20 Linux 2.6.22-rc1 Linus Torvalds
2007-05-13  9:20 ` Jan Engelhardt
2007-05-17  6:55   ` Len Brown
2007-05-13  9:29 ` Linux 2.6.22-rc1, 'nother randconfig Jan Engelhardt
2007-05-13  9:47 ` [PATCH] driver core: fix warning of temporarily unused multithreaded probing function (was: Re: Linux 2.6.22-rc1) Borislav Petkov
2007-05-14  8:06   ` Cornelia Huck
2007-05-13 12:44 ` Linux 2.6.22-rc1 Alessandro Suardi
2007-05-13 12:44 ` Indan Zupancic
2007-05-13 17:10 ` Antonino Ingargiola
2007-05-13 17:53   ` Linus Torvalds
2007-05-13 18:50     ` Antonino Ingargiola
2007-05-14  6:10       ` Jean Delvare
2007-05-14  8:34         ` Antonino Ingargiola
2007-05-14 12:14           ` Jean Delvare
2007-05-14 13:28             ` Antonino Ingargiola
2007-05-14 15:21               ` Jean Delvare
2007-05-14 16:04                 ` Antonino Ingargiola
2007-05-14 16:23                   ` Michal Piotrowski
2007-05-14 18:08                   ` Jean Delvare
2007-05-14 18:25                     ` Antonino Ingargiola
2007-05-14 16:30                 ` Linus Torvalds
2007-05-14 18:24                   ` Jean Delvare
2007-05-14 18:43                     ` Linus Torvalds
2007-05-14 19:28                       ` Jean Delvare
2007-05-14 19:53                         ` Jeff Garzik
2007-05-14 20:18                           ` Christoph Hellwig
2007-05-14 20:17                         ` Christoph Hellwig
2007-05-14 20:15                       ` Christoph Hellwig
2007-05-15 20:31             ` CONFIG_BREAK_MY_MACHINE was " Pavel Machek
2007-05-16 18:11               ` Jean Delvare [this message]
2007-05-17  8:32                 ` CONFIG_BREAK_MY_MACHINE Hans de Goede
2007-05-17  8:47                   ` CONFIG_BREAK_MY_MACHINE Pavel Machek
2007-05-13 18:19 ` Linux 2.6.22-rc1 Tilman Schmidt
2007-05-13 23:20   ` David Miller
2007-05-13 23:32     ` Roland Dreier
2007-05-13 23:57     ` Tilman Schmidt
2007-05-14  4:37     ` Sam Ravnborg
2007-05-14  4:53       ` David Miller
2007-05-14  6:21     ` Satyam Sharma
2007-05-14 17:21   ` Jan Engelhardt
2007-05-14 17:32     ` Stefan Richter
2007-05-14 20:27       ` Jan Engelhardt
2007-05-14 18:01     ` Tilman Schmidt
2007-05-14 20:33       ` Jan Engelhardt
2007-05-14 21:40         ` Tilman Schmidt
2007-05-14 22:09           ` Stefan Richter
2007-05-15  3:02             ` Satyam Sharma
2007-05-15  8:08               ` Jan Engelhardt
2007-05-14 21:54         ` Stefan Richter
2007-05-15  2:34         ` Satyam Sharma
2007-05-15  2:42           ` Satyam Sharma
2007-05-15  6:05             ` Stefan Richter
2007-05-15  6:01           ` Stefan Richter
2007-05-15  8:16           ` Jan Engelhardt
2007-05-16  1:52             ` Satyam Sharma
2007-05-16  6:29               ` Stefan Richter
2007-05-16  9:56                 ` Satyam Sharma
2007-05-15 10:43           ` Tilman Schmidt
2007-05-16  1:39             ` Satyam Sharma
2007-05-16  9:14               ` Tilman Schmidt
2007-05-16  9:17                 ` Satyam Sharma
2007-05-15  5:35         ` Michael Gerdau
2007-05-13 20:51 ` 2.6.22-rc1: loop.c Alexey Dobriyan
2007-05-14  3:52   ` Jeremy Fitzhardinge
2007-05-13 22:53 ` Linux 2.6.22-rc1 Jeff Chua
2007-05-14  1:08 ` andrew hendry
2007-05-14  7:49 ` V4L Regression (Was: Linux 2.6.22-rc1) Robert Fitzsimons
2007-05-14 11:44 ` Linux 2.6.22-rc1, 'nother randconfig David Howells
2007-05-14 17:23   ` Jan Engelhardt
2007-05-15  9:26   ` David Howells
2007-05-15  9:40     ` Jan Engelhardt
2007-05-15  4:14 ` Linux 2.6.22-rc1 andrew hendry
2007-05-15  4:38   ` Linus Torvalds
2007-05-15  5:10     ` andrew hendry
2007-05-15 15:57       ` Linus Torvalds
2007-05-15 22:50         ` andrew hendry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070516201143.699cff02@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=j.w.r.degoede@hhs.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --subject='Re: CONFIG_BREAK_MY_MACHINE' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).