LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>,
	Richard Henderson <rth@twiddle.net>,
	linux-kernel-list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALPHA: MARVEL - check for allocated memory
Date: Thu, 17 May 2007 18:37:12 +0400	[thread overview]
Message-ID: <20070517143712.GA8991@cvg> (raw)
In-Reply-To: <20070516114455.c0ee691e.akpm@linux-foundation.org>

[Andrew Morton - Wed, May 16, 2007 at 11:44:55AM -0700]
| On Wed, 16 May 2007 22:12:14 +0400
| Cyrill Gorcunov <gorcunov@gmail.com> wrote:
| 
| > This patch adds checking for allocated memory
| > which is used to hold AGP info. Also some whitespace
| > cleanup.
| 
| The inclusion of all the whitespace fixies makes it rather hard to
| see what the patch actually does.
| 
| I'm not sure that I can be bothered with this, really.  afaict the
| checks you're adding are for boot-time allocations which we tend
| to assume won't fail, and they're kmalloc(small-amount, GFP_KERNEL)
| which is basically infallible, and it only affects, err, alpha.
| 

So you think we could leave all as is? I mean sould I just drop the patch?

		Cyrill


  reply	other threads:[~2007-05-17 14:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-16 18:12 Cyrill Gorcunov
2007-05-16 18:44 ` Andrew Morton
2007-05-17 14:37   ` Cyrill Gorcunov [this message]
2007-05-17 17:31     ` Andrew Morton
2007-05-19  8:18       ` Cyrill Gorcunov
2007-05-17 14:38   ` Cyrill Gorcunov
  -- strict thread matches above, loose matches on Subject: below --
2007-03-19 16:16 Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070517143712.GA8991@cvg \
    --to=gorcunov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rth@twiddle.net \
    --subject='Re: [PATCH] ALPHA: MARVEL - check for allocated memory' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).