LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: "Dan Williams" <dan.j.williams@intel.com>
Cc: "Heiko Carstens" <heiko.carstens@de.ibm.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"John W. Linville" <linville@tuxdriver.com>,
	"Kyle McMartin" <kyle@parisc-linux.org>,
	linux-kernel@vger.kernel.org, James.Bottomley@steeleye.com,
	"Tejun Heo" <htejun@gmail.com>, "Jeff Garzik" <jeff@garzik.org>,
	"Martin Schwidefsky" <schwidefsky@de.ibm.com>,
	geert@linux-m68k.org, zippel@linux-m68k.org, spyro@f2s.com,
	uclinux-v850@lsi.nec.co.jp, ysato@users.sourceforge.jp
Subject: Re: [patch] Introduce CONFIG_HAS_DMA.
Date: Wed, 30 May 2007 11:10:03 +0200	[thread overview]
Message-ID: <20070530111003.1d813d74@gondolin.boeblingen.de.ibm.com> (raw)
In-Reply-To: <e9c3a7c20705250936n2689c1f3wce8ccb0ee4a22b9e@mail.gmail.com>

On Fri, 25 May 2007 09:36:31 -0700,
"Dan Williams" <dan.j.williams@intel.com> wrote:

> I went back and read the thread leading up to this patch and I am of
> the opinion that John's approach (adding more stubs to
> dma-mapping-broken.h:
> http://marc.info/?l=linux-kernel&m=117219377712232&w=2)  is needed in
> _addition_ to this Kconfig option.  In my particular case I have an
> API with a DMA and a non-DMA path written in such a way that the DMA
> path can be compiled away.  Without dma-mapping-broken.h support the
> API is unnecessarily forced to violate point 2 of
> Documentation/SubmittingPatches (#ifdefs are ugly).

IMO, well-placed #ifdefs are preferrable to dragging non-working code
around. Like:

- put the DMA path in a file only build for MY_STUFF_USE_DMA
- let MY_STUFF select MY_STUFF_USE_DMA if HAS_DMA
- have a header file that points to the implementation for
  MY_STUFF_USE_DMA and uses well defined stubs for !MY_STUFF_USE_DMA,
  like returning ICannotDoThat for check_if_can_do() (kind of like what
  include/linux/sysfs.h does, for example)

This contains the #ifdefs in a header, doesn't compile stuff that won't
work anyway on !HAS_DMA, and adds the ability to disable
MY_STUFF_USE_DMA even if HAS_DMA at a later time if someone wants it.

> In other words let CONFIG_HAS_DMA prevent pure DMA code from being
> built, but do not preclude "clever" implementations from calling
> broken code.

If it calls broken code, it may not be so "clever" after all :)

What I don't like about this is

- compiles stuff that is not needed on !HAS_DMA
- worse, compiles stuff that will not work on !HAS_DMA
- does not encourage to split code properly into a DMA and a non-DMA
  part

  reply	other threads:[~2007-05-30  9:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-23  0:59 [PATCH] dma-mapping-broken.h: flesh-out DMA API stubs John W. Linville
2007-02-23  3:42 ` Heiko Carstens
2007-02-23  6:13   ` Heiko Carstens
2007-02-23  9:50     ` Heiko Carstens
2007-02-23 13:57     ` Kyle McMartin
2007-02-23 14:39       ` John W. Linville
2007-02-26 13:57         ` [patch] Introduce CONFIG_HAS_DMA Heiko Carstens
2007-05-25 16:36           ` Dan Williams
2007-05-30  9:10             ` Cornelia Huck [this message]
2007-05-30 21:40               ` Williams, Dan J
2007-05-30 22:29                 ` [PATCH] dma-mapping: prevent dma dependent code from linking on !HAS_DMA archs Dan Williams
2007-05-31  6:53                 ` [patch] Introduce CONFIG_HAS_DMA Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070530111003.1d813d74@gondolin.boeblingen.de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=James.Bottomley@steeleye.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=geert@linux-m68k.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=kyle@parisc-linux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=spyro@f2s.com \
    --cc=uclinux-v850@lsi.nec.co.jp \
    --cc=ysato@users.sourceforge.jp \
    --cc=zippel@linux-m68k.org \
    --subject='Re: [patch] Introduce CONFIG_HAS_DMA.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).