LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: "Ed L. Cashin" <ecashin@coraid.com>
Cc: linux-kernel@vger.kernel.org, Greg K-H <greg@kroah.com>
Subject: Re: [PATCH 12/12] the aoeminor doesn't need a long format
Date: Tue, 26 Jun 2007 12:51:07 -0700 [thread overview]
Message-ID: <20070626125107.ce2b4325.randy.dunlap@oracle.com> (raw)
In-Reply-To: <e4b5ee94f03480b4801b4a1ddce2d5b71073e258.1182883861.git.ecashin@coraid.com>
On Tue, 26 Jun 2007 14:50:12 -0400 Ed L. Cashin wrote:
> The aoedev aoeminor member doesn't need a long format.
Was there a patch that changed aoeminor to an int?
Last I see is:
ulong aoeminor;
in linux-2.6.22-rc6/drivers/block/aoe/aoe.h.
If it's still ulong, you shouldn't change the printk format.
> Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
> ---
> drivers/block/aoe/aoeblk.c | 6 +++---
> drivers/block/aoe/aoecmd.c | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c
> index ccadd9a..e216fe0 100644
> --- a/drivers/block/aoe/aoeblk.c
> +++ b/drivers/block/aoe/aoeblk.c
> @@ -203,7 +203,7 @@ aoeblk_make_request(request_queue_t *q, struct bio *bio)
> spin_lock_irqsave(&d->lock, flags);
>
> if ((d->flags & DEVFL_UP) == 0) {
> - printk(KERN_INFO "aoe: device %ld.%ld is not up\n",
> + printk(KERN_INFO "aoe: device %ld.%d is not up\n",
> d->aoemajor, d->aoeminor);
> spin_unlock_irqrestore(&d->lock, flags);
> mempool_free(buf, d->bufpool);
> @@ -256,7 +256,7 @@ aoeblk_gdalloc(void *vp)
>
> gd = alloc_disk(AOE_PARTITIONS);
> if (gd == NULL) {
> - printk(KERN_ERR "aoe: cannot allocate disk structure for %ld.%ld\n",
> + printk(KERN_ERR "aoe: cannot allocate disk structure for %ld.%d\n",
> d->aoemajor, d->aoeminor);
> spin_lock_irqsave(&d->lock, flags);
> d->flags &= ~DEVFL_GDALLOC;
> @@ -266,7 +266,7 @@ aoeblk_gdalloc(void *vp)
>
> d->bufpool = mempool_create_slab_pool(MIN_BUFS, buf_pool_cache);
> if (d->bufpool == NULL) {
> - printk(KERN_ERR "aoe: cannot allocate bufpool for %ld.%ld\n",
> + printk(KERN_ERR "aoe: cannot allocate bufpool for %ld.%d\n",
> d->aoemajor, d->aoeminor);
> put_disk(gd);
> spin_lock_irqsave(&d->lock, flags);
> diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
> index 9de0024..dfb1184 100644
> --- a/drivers/block/aoe/aoecmd.c
> +++ b/drivers/block/aoe/aoecmd.c
> @@ -680,7 +680,7 @@ ataid_complete(struct aoedev *d, struct aoetgt *t, unsigned char *id)
> }
>
> if (d->ssize != ssize)
> - printk(KERN_INFO "aoe: %012llx e%lu.%lu v%04x has %llu sectors\n",
> + printk(KERN_INFO "aoe: %012llx e%ld.%d v%04x has %llu sectors\n",
> mac_addr(t->addr),
> d->aoemajor, d->aoeminor,
> d->fw_ver, (long long)ssize);
> @@ -805,7 +805,7 @@ aoecmd_ata_rsp(struct sk_buff *skb)
>
> if (ahin->cmdstat & 0xa9) { /* these bits cleared on success */
> printk(KERN_ERR
> - "aoe: ata error cmd=%2.2Xh stat=%2.2Xh from e%ld.%ld\n",
> + "aoe: ata error cmd=%2.2Xh stat=%2.2Xh from e%ld.%d\n",
> ahout->cmdstat, ahin->cmdstat,
> d->aoemajor, d->aoeminor);
> if (buf)
> --
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2007-06-26 19:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-26 18:50 [PATCH 01/12] bring driver version number to 47 Ed L. Cashin
2007-06-26 18:50 ` [PATCH 03/12] mac_addr: avoid 64-bit arch compiler warnings Ed L. Cashin
2007-06-26 18:50 ` [PATCH 02/12] handle multiple network paths to AoE device Ed L. Cashin
2007-07-03 4:29 ` Andrew Morton
2007-07-11 14:46 ` Ed L. Cashin
2007-07-16 22:17 ` [PATCH] stacked ifs (was Re: [PATCH 02/12] handle multiple network paths to AoE device) Ed L. Cashin
2007-07-16 22:31 ` Andrew Morton
2007-07-17 0:01 ` Greg KH
2007-07-18 15:24 ` Jan Engelhardt
2007-06-26 18:50 ` [PATCH 05/12] eliminate goto and improve readability Ed L. Cashin
2007-06-26 18:50 ` [PATCH 07/12] use a dynamic pool of sk_buffs to keep up with fast targets Ed L. Cashin
2007-07-03 4:36 ` Andrew Morton
2007-07-03 4:40 ` David Miller
2007-07-03 18:45 ` Matt Mackall
2007-07-03 19:18 ` Stephen Hemminger
2007-07-06 17:09 ` Ed L. Cashin
2007-06-26 18:50 ` [PATCH 06/12] user can ask driver to forget previously detected devices Ed L. Cashin
2007-06-26 18:50 ` [PATCH 04/12] clean up udev configuration example Ed L. Cashin
2007-06-26 18:50 ` [PATCH 12/12] the aoeminor doesn't need a long format Ed L. Cashin
2007-06-26 19:51 ` Randy Dunlap [this message]
2007-06-26 19:59 ` Ed L. Cashin
2007-06-26 18:50 ` [PATCH 10/12] add module parameter for users who need more outstanding I/O Ed L. Cashin
2007-07-03 4:41 ` Andrew Morton
2007-06-26 18:50 ` [PATCH 11/12] remove extra space in prototypes for consistency Ed L. Cashin
2007-06-26 18:50 ` [PATCH 09/12] remove race between use and initialization of locks Ed L. Cashin
2007-07-03 4:38 ` Andrew Morton
2007-06-26 18:50 ` [PATCH 08/12] only schedule work once Ed L. Cashin
2007-07-03 4:37 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070626125107.ce2b4325.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=ecashin@coraid.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH 12/12] the aoeminor doesn'\''t need a long format' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).