LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Jeff Dike <jdike@addtoit.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: Re: [uml-devel] [PATCH 4/5] UML - Simplify helper stack handling
Date: Tue, 26 Jun 2007 15:07:47 -0700	[thread overview]
Message-ID: <20070626150747.5110e614.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070626215328.GA23077@c2.user-mode-linux.org>

On Tue, 26 Jun 2007 17:53:28 -0400
Jeff Dike <jdike@addtoit.com> wrote:

> On Tue, Jun 26, 2007 at 01:35:50PM -0700, Andrew Morton wrote:
> > >  	sprintf(title, data->title, data->device);
> > > -	pid = run_helper(NULL, NULL, argv, NULL);
> > > +	pid = run_helper(NULL, NULL, argv);
> > >  	if (pid < 0) {
> > >  		err = pid;
> > >  		printk(UM_KERN_ERR "xterm_open : run_helper failed, "
> > 
> > Something's gone wrong here.  My copy of this file has
> > 
> >         pid = run_helper(NULL, NULL, argv, &stack);
> 
> Looks like you're applying patches out of order.

Yes, I am.  After a few days off and a few more days being lazy I have
600-odd patches (and followups thereto) to process.

- If I do them in-order, I merge stuff which is out of date or wrong

- If I do them in reverse-order, I can miss dependencies.

On balance, reverse-order seems to be better.

>  This is from the
> 14th, while a patch from the 13th ("UML - xterm driver tidying") has
> -       pid = run_helper(NULL, NULL, argv, &stack);
> 	...
> +       pid = run_helper(NULL, NULL, argv, NULL);
> 
> If you don't want to fiddle with this, just drop it and I'll rediff
> against the next -mm and resend.

I sorted it out, thanks.

  reply	other threads:[~2007-06-26 22:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-14 20:26 Jeff Dike
2007-06-26 20:35 ` Andrew Morton
2007-06-26 21:53   ` [uml-devel] " Jeff Dike
2007-06-26 22:07     ` Andrew Morton [this message]
2007-06-28  6:37 ` Andrew Morton
2007-07-03 15:28   ` [uml-devel] " Blaisorblade
2007-07-03 15:58     ` Andrew Morton
2007-07-03 17:26     ` Jeff Dike
2007-08-05 20:41   ` Luca Tettamanti
2007-08-05 20:54     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070626150747.5110e614.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    --subject='Re: [uml-devel] [PATCH 4/5] UML - Simplify helper stack handling' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).