LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Juan Antonio Martinez <jonsito@teleline.es>
Cc: linux-kernel@vger.kernel.org
Subject: Re: ppdev - libieee1284.so  conflicts with 2.6.21
Date: Mon, 2 Jul 2007 15:47:53 -0700	[thread overview]
Message-ID: <20070702154753.56d06f10.akpm@linux-foundation.org> (raw)
In-Reply-To: <1183368129.4967.1.camel@drake.micasa.es>

On Mon, 02 Jul 2007 11:22:09 +0200
Juan Antonio Martinez <jonsito@teleline.es> wrote:

> I've reported this error to Fedora Bugzilla:
> 
> http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246406
> 
> In sort: to use libieee1284 I need to disable ppdev usage with
> kernel 2.6.21. Kernel 2.6.20 works fine
> 
> [root@drake char]# uname -a
> Linux drake.micasa.es 2.6.21-1.3228.fc7 #1 SMP Tue Jun 12 15:37:31 EDT
> 2007 i686 athlon i386 GNU/Linux
> 
> By doing "echo disallow method ppdev > /etc/ieee1284.conf" everything
> works fine on both kernels
> 
> Seems affect several distributions, not Fedora specific:
> http://bugs.archlinux.org/task/7438
> http://sourceforge.net/tracker/index.php?func=detail&aid=1739643&group_id=29314&atid=395778
> http://www.digipedia.pl/man/libieee1284.3.html
> 
> Not sure if a kernel bug or a library one, so my apologizes if
> this is not the propper list
> 

Not much has changed in ppdev.c.  Possibly this:

commit da6752964290567a6b4ea180d1becda75e810e87
Author: David Brownell <david-b@pacbell.net>
Date:   Tue May 8 00:27:42 2007 -0700

    layered parport code uses parport->dev
    
    Update some of the layered parport_driver code to use parport->dev:
    
        - i2c-parport (parent of i2c_adapter)
        - spi_butterfly (parent of spi_master, allowing cruft removal)
        - lp (creating class_device)
        - ppdev (parent of parportN device)
        - tipar (creating class_device)
    
    There are still drivers that should be updated, like some of the input
    drivers; but they won't be any worse off than they are today.

broke something.

Can you test a kernel with this change applied?

--- a/drivers/char/ppdev.c~a
+++ a/drivers/char/ppdev.c
@@ -751,7 +751,7 @@ static const struct file_operations pp_f
 
 static void pp_attach(struct parport *port)
 {
-	device_create(ppdev_class, port->dev, MKDEV(PP_MAJOR, port->number),
+	device_create(ppdev_class, NULL, MKDEV(PP_MAJOR, port->number),
 			"parport%d", port->number);
 }
 
_


  reply	other threads:[~2007-07-02 22:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-02  9:22 Juan Antonio Martinez
2007-07-02 22:47 ` Andrew Morton [this message]
2007-07-02 23:12   ` Randy Dunlap
2007-07-03  0:28     ` Adrian Bunk
2007-07-02 23:13   ` Chuck Ebbert
2007-07-03 15:57     ` Juan Antonio Martinez
2007-07-03  6:16 Juan Antonio Martinez
2007-07-03 21:31 ` Chuck Ebbert
2007-07-04 11:58   ` Jonsito

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070702154753.56d06f10.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=jonsito@teleline.es \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: ppdev - libieee1284.so  conflicts with 2.6.21' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).