LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@o2.pl>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	David Howells <dhowells@redhat.com>, Ingo Molnar <mingo@elte.hu>,
	Steven Rostedt <rostedt@goodmis.org>,
	Tejun Heo <htejun@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] make cancel_xxx_work_sync() return a boolean
Date: Tue, 3 Jul 2007 07:37:44 +0200	[thread overview]
Message-ID: <20070703053744.GB1657@ff.dom.local> (raw)
In-Reply-To: <20070701153710.GA108@tv-sign.ru>

On Sun, Jul 01, 2007 at 07:37:10PM +0400, Oleg Nesterov wrote:
> Change cancel_work_sync() and cancel_delayed_work_sync() to return a boolean
> indicating whether the work was actually cancelled. A zero return value means
> that the work was not pending/queued.
> 
> Without that kind of change it is not possible to avoid flush_workqueue()
> sometimes, see the next patch as an example.
> 
> Also, this patch unifies both functions and kills the (unlikely) busy-wait loop.
> 
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

Acked-by: Jarek Poplawski <jarkao2@o2.pl>


      reply	other threads:[~2007-07-03  5:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-01 15:37 Oleg Nesterov
2007-07-03  5:37 ` Jarek Poplawski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070703053744.GB1657@ff.dom.local \
    --to=jarkao2@o2.pl \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=htejun@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@tv-sign.ru \
    --cc=rostedt@goodmis.org \
    --subject='Re: [PATCH 2/3] make cancel_xxx_work_sync() return a boolean' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).