LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Re: [PATCH]: Check the right register for the DMA enabled flags
2007-07-03 14:11 [PATCH]: Check the right register for the DMA enabled flags Alan Cox
@ 2007-07-03 14:10 ` Jeff Garzik
2007-07-03 16:31 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2007-07-03 14:10 UTC (permalink / raw)
To: Alan Cox; +Cc: akpm, linux-kernel
Alan Cox wrote:
> Mirrors change in IT821X
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --exclude-from /usr/src/exclude --recursive linux.vanilla-2.6.22-rc6-mm1/drivers/ata/ata_generic.c linux-2.6.22-rc6-mm1/drivers/ata/ata_generic.c
> --- linux.vanilla-2.6.22-rc6-mm1/drivers/ata/ata_generic.c 2007-07-02 20:50:11.000000000 +0100
> +++ linux-2.6.22-rc6-mm1/drivers/ata/ata_generic.c 2007-07-02 21:02:10.000000000 +0100
> @@ -50,7 +50,7 @@
>
> /* Bits 5 and 6 indicate if DMA is active on master/slave */
> if (ap->ioaddr.bmdma_addr)
> - dma_enabled = ioread8(ap->ioaddr.bmdma_addr + ATA_DMA_CMD);
> + dma_enabled = ioread8(ap->ioaddr.bmdma_addr + ATA_DMA_STATUS);
applied
Please put driver or subsystem name in subject, to disambiguate. Email
subject goes straight into kernel changelog verbatim, and is in essence
a global namespace.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH]: Check the right register for the DMA enabled flags
@ 2007-07-03 14:11 Alan Cox
2007-07-03 14:10 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Alan Cox @ 2007-07-03 14:11 UTC (permalink / raw)
To: akpm, jeff, linux-kernel
Mirrors change in IT821X
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --exclude-from /usr/src/exclude --recursive linux.vanilla-2.6.22-rc6-mm1/drivers/ata/ata_generic.c linux-2.6.22-rc6-mm1/drivers/ata/ata_generic.c
--- linux.vanilla-2.6.22-rc6-mm1/drivers/ata/ata_generic.c 2007-07-02 20:50:11.000000000 +0100
+++ linux-2.6.22-rc6-mm1/drivers/ata/ata_generic.c 2007-07-02 21:02:10.000000000 +0100
@@ -50,7 +50,7 @@
/* Bits 5 and 6 indicate if DMA is active on master/slave */
if (ap->ioaddr.bmdma_addr)
- dma_enabled = ioread8(ap->ioaddr.bmdma_addr + ATA_DMA_CMD);
+ dma_enabled = ioread8(ap->ioaddr.bmdma_addr + ATA_DMA_STATUS);
for (i = 0; i < ATA_MAX_DEVICES; i++) {
struct ata_device *dev = &ap->device[i];
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH]: Check the right register for the DMA enabled flags
2007-07-03 14:10 ` Jeff Garzik
@ 2007-07-03 16:31 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2007-07-03 16:31 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Alan Cox, akpm, linux-kernel
On Tue, 03 Jul 2007 10:10:25 -0400 Jeff Garzik wrote:
> Alan Cox wrote:
> > Mirrors change in IT821X
> >
> > Signed-off-by: Alan Cox <alan@redhat.com>
> >
> > diff -u --new-file --exclude-from /usr/src/exclude --recursive linux.vanilla-2.6.22-rc6-mm1/drivers/ata/ata_generic.c linux-2.6.22-rc6-mm1/drivers/ata/ata_generic.c
> > --- linux.vanilla-2.6.22-rc6-mm1/drivers/ata/ata_generic.c 2007-07-02 20:50:11.000000000 +0100
> > +++ linux-2.6.22-rc6-mm1/drivers/ata/ata_generic.c 2007-07-02 21:02:10.000000000 +0100
> > @@ -50,7 +50,7 @@
> >
> > /* Bits 5 and 6 indicate if DMA is active on master/slave */
> > if (ap->ioaddr.bmdma_addr)
> > - dma_enabled = ioread8(ap->ioaddr.bmdma_addr + ATA_DMA_CMD);
> > + dma_enabled = ioread8(ap->ioaddr.bmdma_addr + ATA_DMA_STATUS);
>
> applied
>
> Please put driver or subsystem name in subject, to disambiguate. Email
> subject goes straight into kernel changelog verbatim, and is in essence
> a global namespace.
and please use linux-ide.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-03 16:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-03 14:11 [PATCH]: Check the right register for the DMA enabled flags Alan Cox
2007-07-03 14:10 ` Jeff Garzik
2007-07-03 16:31 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).